linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Heffner <jheffner@psc.edu>
To: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: Ion Badulescu <lists@limebrokerage.com>,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	linux-net@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Possible BUG in IPv4 TCP window handling, all recent 2.4.x/2.6.x kernels
Date: Fri, 2 Sep 2005 10:16:57 -0400	[thread overview]
Message-ID: <4629cfbdf1af310d5c6cffd7178cff5b@psc.edu> (raw)
In-Reply-To: <20050902134807.GB12617@yakov.inr.ac.ru>

On Sep 2, 2005, at 9:48 AM, Alexey Kuznetsov wrote:

> Hello!
>
>> If you overflow the socket's memory bound, it ends up calling
>> tcp_clamp_window().  (I'm not sure this is really the right thing to 
>> do
>> here before trying to collapse the queue.)
>
> Collapsing is too expensive procedure, it is rather an emergency 
> measure.
> So, tcp collapses queue, when it is necessary, but it must reduce 
> window
> as well.

Right.

I wonder if clamping the window though is too harsh.  Maybe just 
setting the rcv_ssthresh down is better?  Why the distinction between 
in-order and out-of-order data?  Because you expect in-order data to be 
a persistent case?

   -John


  reply	other threads:[~2005-09-02 14:17 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-01 22:30 Possible BUG in IPv4 TCP window handling, all recent 2.4.x/2.6.x kernels Ion Badulescu
2005-09-01 22:43 ` David S. Miller
2005-09-01 22:49   ` Jesper Juhl
2005-09-01 22:53     ` David S. Miller
2005-09-01 22:53   ` Ion Badulescu
2005-09-01 23:37     ` Jesper Juhl
2005-09-02  2:51     ` John Heffner
2005-09-02  6:28       ` David S. Miller
2005-09-02 14:05         ` lists
2005-09-02 14:10           ` John Heffner
2005-09-02 14:33             ` lists
2005-09-02 14:48               ` John Heffner
2005-09-02 15:43                 ` Ion Badulescu
2005-09-02 13:02       ` Guillaume Autran
2005-09-02 13:48         ` Ion Badulescu
2005-09-02 13:52         ` Alexey Kuznetsov
2005-09-02 14:11           ` John Heffner
2005-09-02 13:48       ` Alexey Kuznetsov
2005-09-02 14:16         ` John Heffner [this message]
2005-09-02 15:11           ` Alexey Kuznetsov
2005-09-02 18:36     ` Alexey Kuznetsov
2005-09-02 20:57       ` Ion Badulescu
2005-09-02 21:18         ` Alexey Kuznetsov
2005-09-02 23:09           ` Ion Badulescu
2005-09-28 16:31       ` Ion Badulescu
2005-09-29 15:17         ` Alexey Kuznetsov
2005-09-29 15:34           ` Guillaume Autran
2005-09-29 16:04           ` John Heffner
2005-09-29 18:16             ` David S. Miller
2005-09-30  0:29           ` David S. Miller
2005-09-02  4:51 ` Noritoshi Demizu
2005-09-02  5:20   ` Stephen Hemminger
2005-09-02  5:45     ` Noritoshi Demizu
2005-09-02  6:11       ` Noritoshi Demizu
2005-09-02 12:11         ` Ion Badulescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4629cfbdf1af310d5c6cffd7178cff5b@psc.edu \
    --to=jheffner@psc.edu \
    --cc=davem@davemloft.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=lists@limebrokerage.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).