From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
Andi Kleen <ak@suse.de>, Pavel Machek <pavel@ucw.cz>,
Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
discuss@x86-64.org
Subject: Re: [PATCH][Fix][Resend] Fix Bug #4959: Page tables corrupted during resume on x86-64 (take 3)
Date: Thu, 29 Sep 2005 15:29:14 -0700 [thread overview]
Message-ID: <20050929152914.A15943@unix-os.sc.intel.com> (raw)
In-Reply-To: <200509300001.10258.rjw@sisk.pl>; from rjw@sisk.pl on Fri, Sep 30, 2005 at 12:01:08AM +0200
On Fri, Sep 30, 2005 at 12:01:08AM +0200, Rafael J. Wysocki wrote:
> On Thursday, 29 of September 2005 02:00, Siddha, Suresh B wrote:
> >
> > My patch as such shouldn't change the behavior of the existing swsup
> > code. I am making only boot_level4_pgt as initdata. But not the
> > init_level4_pgt.
>
> Suresh, unfortunately the kernel does not boot with your patch, because
Did you try just only my patch on top of 2.6.14-rc2? You can get that
patch from http://www.x86-64.org/lists/discuss/msg07313.html
> it clears init_level4_pgt.
what is wrong with zapping low mappings? Looks like someother change
you are trying assumes that low mappings are always present in init_level4_pgt,
which is wrong..
> +++ linux-2.6.14-rc2-git7/arch/x86_64/mm/init.c 2005-09-29 22:13:55.000000000 +0200
> @@ -313,7 +313,7 @@
> void __cpuinit zap_low_mappings(int cpu)
> {
> if (cpu == 0) {
> - pgd_t *pgd = pgd_offset_k(0UL);
> + pgd_t *pgd = boot_level4_pgt;
> pgd_clear(pgd);
Don't do this. Its wrong.
Please send me your patch that you are having problems with. I can take
a look at it.
thanks,
suresh
next prev parent reply other threads:[~2005-09-29 22:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-28 14:24 [PATCH][Fix][Resend] Fix Bug #4959: Page tables corrupted during resume on x86-64 (take 3) Rafael J. Wysocki
2005-09-28 19:18 ` Andi Kleen
2005-09-28 20:24 ` Rafael J. Wysocki
2005-09-28 20:33 ` [discuss] " Andi Kleen
2005-09-28 22:11 ` Rafael J. Wysocki
2005-09-28 22:35 ` Pavel Machek
2005-09-29 11:25 ` Rafael J. Wysocki
2005-09-29 0:00 ` Siddha, Suresh B
2005-09-29 10:58 ` Rafael J. Wysocki
2005-09-29 22:01 ` Rafael J. Wysocki
2005-09-29 22:29 ` Siddha, Suresh B [this message]
2005-09-29 23:04 ` Rafael J. Wysocki
2005-09-29 23:59 ` Siddha, Suresh B
2005-09-30 5:26 ` Rafael J. Wysocki
2005-09-30 6:51 ` [discuss] " Rafael J. Wysocki
2005-10-01 1:25 ` Siddha, Suresh B
2005-10-01 7:47 ` Rafael J. Wysocki
2005-10-01 10:03 ` Rafael J. Wysocki
2005-10-02 1:08 ` Siddha, Suresh B
2005-10-02 9:54 ` Rafael J. Wysocki
2005-09-29 20:02 ` Andrew Morton
2005-09-29 21:35 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050929152914.A15943@unix-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).