From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
discuss@x86-64.org, ak@suse.de, Pavel Machek <pavel@ucw.cz>,
Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [discuss] Re: [PATCH][Fix][Resend] Fix Bug #4959: Page tables corrupted during resume on x86-64 (take 3)
Date: Sat, 1 Oct 2005 18:08:04 -0700 [thread overview]
Message-ID: <20051001180804.A12268@unix-os.sc.intel.com> (raw)
In-Reply-To: <200510011203.20828.rjw@sisk.pl>; from rjw@sisk.pl on Sat, Oct 01, 2005 at 12:03:20PM +0200
On Sat, Oct 01, 2005 at 12:03:20PM +0200, Rafael J. Wysocki wrote:
> It shows that there's something wrong with get_smp_config(), but it shouldn't
> have been called in the first place, as it was a non-SMP kernel.
>
> The appended patch fixes the issue for me, but still if I run an SMP kernel on this
> box, it crashes in get_smp_config().
>
> If you want me to debug this further, please tell me what to do next.
Rafael, can you check if the appended patch fixes your issue.
thanks,
suresh
--- linux-2.6.14-rc2/arch/x86_64/kernel/mpparse.c~ 2005-10-01 17:16:59.452285584 -0700
+++ linux-2.6.14-rc2/arch/x86_64/kernel/mpparse.c 2005-10-01 17:22:21.053394784 -0700
@@ -549,7 +549,7 @@
* Read the physical hardware table. Anything here will
* override the defaults.
*/
- if (!smp_read_mpc((void *)(unsigned long)mpf->mpf_physptr)) {
+ if (!smp_read_mpc(phys_to_virt(mpf->mpf_physptr))) {
smp_found_config = 0;
printk(KERN_ERR "BIOS bug, MP table errors detected!...\n");
printk(KERN_ERR "... disabling SMP support. (tell your hw vendor)\n");
next prev parent reply other threads:[~2005-10-02 1:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-28 14:24 [PATCH][Fix][Resend] Fix Bug #4959: Page tables corrupted during resume on x86-64 (take 3) Rafael J. Wysocki
2005-09-28 19:18 ` Andi Kleen
2005-09-28 20:24 ` Rafael J. Wysocki
2005-09-28 20:33 ` [discuss] " Andi Kleen
2005-09-28 22:11 ` Rafael J. Wysocki
2005-09-28 22:35 ` Pavel Machek
2005-09-29 11:25 ` Rafael J. Wysocki
2005-09-29 0:00 ` Siddha, Suresh B
2005-09-29 10:58 ` Rafael J. Wysocki
2005-09-29 22:01 ` Rafael J. Wysocki
2005-09-29 22:29 ` Siddha, Suresh B
2005-09-29 23:04 ` Rafael J. Wysocki
2005-09-29 23:59 ` Siddha, Suresh B
2005-09-30 5:26 ` Rafael J. Wysocki
2005-09-30 6:51 ` [discuss] " Rafael J. Wysocki
2005-10-01 1:25 ` Siddha, Suresh B
2005-10-01 7:47 ` Rafael J. Wysocki
2005-10-01 10:03 ` Rafael J. Wysocki
2005-10-02 1:08 ` Siddha, Suresh B [this message]
2005-10-02 9:54 ` Rafael J. Wysocki
2005-09-29 20:02 ` Andrew Morton
2005-09-29 21:35 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051001180804.A12268@unix-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).