Re: [usb-storage] usb: drivers/usb/storage/libusual

From: Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Greg KH <greg@kroah.com>,
	usb-storage@lists.one-eyed-alien.net,
	linux-kernel@vger.kernel.org,
	linux-usb-devel@lists.sourceforge.net
Subject: Re: [usb-storage] usb: drivers/usb/storage/libusual
Date: Sat, 8 Oct 2005 19:14:13 -0700	[thread overview]
Message-ID: <20051009021413.GA25979@one-eyed-alien.net> (raw)
In-Reply-To: <20051008140132.49f9eec3.zaitcev@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 2258 bytes --]

On Sat, Oct 08, 2005 at 02:01:32PM -0700, Pete Zaitcev wrote:
> This patch adds a shim driver libusual, which routes devices between
> usb-storage and ub according to the common table, based on unusual_devs.h.
> The help and example syntax is in Kconfig.
> 
> Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
> 
> ---
> 
> I think libusual is ready for Andrew's tree now. I realize that the use
> of request_module is an inkblot in this copybook, so maybe it's not the
> time for Linus' tree yet. Another concern I have is if we have any races
> with hotplug, udev, and HAL.
> 
> I haven't heard from Adrian yet, but I suppose it's a good sign.
> No word from Matt Dharm either, which is not so good... But I do have
> Alan Stern's buy-in.

Well, I guess it's time for me to comment, then.   I have been watching
with great interest.

I have to say, I totally agree that this is a problem that needs solving.
The current situation is a mess....

But, I'm not sure this is much better.  It's certainly different, but I
fear that we're going to spend a lot of time explaining to end-users a new
and less-than-totally-obvious system.

Technically, this is much better than what we have.  I'm just not sure
about the "end user experience".

And I think I'm totally convinced now that request_module() needs some
serious help.  Either it needs to go away entirely, or be replaced by a
helper, such that request_module() gets a module loaded, but module
binding to a device is controlled via another mechanism.

Overall, send it to Andrew's tree.  But I'd really like to see it live
there for an extended period of time before going to Linus.  And I'd also
like to see some ideas for the final solution, which would apply to HID
devices with the same problem.

I hate solving problems twice.  It creates twice as much work for everyone,
including distro folks and end-users.  Let's figure this out as a more
generic driver-binding problem for all drivers once and for all.

Matt

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

How would you like this tie wrapped around your hairy round head?
					-- Greg
User Friendly, 9/2/1998

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]