From: Phil Dibowitz <phil@ipom.com>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net,
linux-usb-storage@lists.one-eyed-alien.net
Subject: Re: [linux-usb-devel] RFC drivers/usb/storage/libusual
Date: Fri, 30 Sep 2005 00:09:05 -0700 [thread overview]
Message-ID: <433CE491.90305@ipom.com> (raw)
In-Reply-To: <20050927205559.078ba9ed.zaitcev@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
Pete Zaitcev wrote:
> Patch is attached. I would like someone to look it over and challenge it.
> The thing looks too complex to me, but I see no other way. Anyone?
OK, so I'm not very familiar with a lot of the code affected here, but
since it diddles with unusual_devs, I feel I should chime in. But I'll
chime in with a question. ;)
A quick look over the patch shows that there are now two kinds of
unusual_dev entries: unusual_dev() and unusual_dev_fl(), where the
latter is for entries that don't need to specify SC or PR (i.e., just
had US_SC_DEVICE, US_PR_DEVICE in them). While I think that's a
reasonable change, it's not clear to me why that's useful to the rest of
the patch, or it's just making unusual_devs.h artificially shorter?
--
Phil Dibowitz phil@ipom.com
Freeware and Technical Pages Insanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
"They that can give up essential liberty to obtain a little temporary
safety deserve neither liberty nor safety."
- Benjamin Franklin, 1759
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]
next prev parent reply other threads:[~2005-09-30 7:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-28 3:55 RFC drivers/usb/storage/libusual Pete Zaitcev
2005-09-28 8:52 ` [linux-usb-devel] " Greg KH
2005-09-28 19:40 ` Alan Stern
2005-09-29 0:01 ` Pete Zaitcev
2005-10-10 21:15 ` Rusty Russell
2005-10-07 7:24 ` Pete Zaitcev
2005-10-07 14:41 ` [usb-storage] " Alan Stern
2005-10-08 7:35 ` Pete Zaitcev
2005-10-08 15:17 ` Alan Stern
2005-10-08 21:01 ` usb: drivers/usb/storage/libusual Pete Zaitcev
2005-10-09 2:14 ` [usb-storage] " Matthew Dharm
2005-10-09 8:09 ` Pete Zaitcev
2005-09-28 16:56 ` [linux-usb-devel] RFC drivers/usb/storage/libusual Alan Stern
2005-09-29 2:21 ` Pete Zaitcev
2005-09-30 7:09 ` Phil Dibowitz [this message]
2005-10-01 0:26 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433CE491.90305@ipom.com \
--to=phil@ipom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=linux-usb-storage@lists.one-eyed-alien.net \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).