linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] signal handling: revert sigkill priority fix
@ 2005-11-05 11:29 Heiko Carstens
  0 siblings, 0 replies; only message in thread
From: Heiko Carstens @ 2005-11-05 11:29 UTC (permalink / raw)
  To: Andrew Morton, linux-kernel
  Cc: Roland McGrath, Kirill Korotaev, Alexey Kuznetsov

From: Heiko Carstens <heiko.carstens@de.ibm.com>

This patch reverts commit c33880aaddbbab1ccf36f4457ed1090621f2e39a since
it's not needed anymore. As pointed out by Roland McGrath the real fix
is to deliver all signals before returning to user space.
See http://www.ussg.iu.edu/hypermail/linux/kernel/0509.2/0683.html
A fix for s390 is in the -mm tree.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---

 kernel/signal.c |   11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index 1bf3c39..2429204 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -513,16 +513,7 @@ static int __dequeue_signal(struct sigpe
 {
 	int sig = 0;
 
-	/* SIGKILL must have priority, otherwise it is quite easy
-	 * to create an unkillable process, sending sig < SIGKILL
-	 * to self */
-	if (unlikely(sigismember(&pending->signal, SIGKILL))) {
-		if (!sigismember(mask, SIGKILL))
-			sig = SIGKILL;
-	}
-
-	if (likely(!sig))
-		sig = next_signal(pending, mask);
+	sig = next_signal(pending, mask);
 	if (sig) {
 		if (current->notifier) {
 			if (sigismember(current->notifier_mask, sig)) {

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2005-11-05 11:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-05 11:29 [PATCH] signal handling: revert sigkill priority fix Heiko Carstens

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).