From: Mark Brown <broonie@sirena.org.uk>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, Tim Hockin <thockin@hockin.org>,
Harald Welte <laforge@gnumonks.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] natsemi: NAPI support
Date: Mon, 5 Dec 2005 23:23:01 +0000 [thread overview]
Message-ID: <20051205232301.GA4551@sirena.org.uk> (raw)
In-Reply-To: <20051204231209.GA28949@electric-eye.fr.zoreil.com>
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
On Mon, Dec 05, 2005 at 12:12:09AM +0100, Francois Romieu wrote:
> -> netif_poll_disable() may sleep while a spinlock is held.
So it can, thanks.
> Btw, the poll/close routines seem racy with each other.
I had been under the impression that the stack was supposed to make sure
that no poll() is running before the driver close() gets called? I
could well be missing something there, though. Indeed, now that I think
about it the calls netif_poll_disable() in suspend() ought to mean that
we don't need to look at hands_off inside poll().
--
"You grabbed my hand and we fell into it, like a daydream - or a fever."
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 307 bytes --]
next prev parent reply other threads:[~2005-12-05 23:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-04 22:47 [PATCH] natsemi: NAPI support Mark Brown
[not found] ` <20051204231209.GA28949@electric-eye.fr.zoreil.com>
2005-12-05 23:23 ` Mark Brown [this message]
2005-12-06 0:19 ` Francois Romieu
2005-12-06 21:17 ` Mark Brown
2005-12-06 21:56 ` Francois Romieu
2005-12-09 10:48 ` Mark Brown
2005-12-12 23:55 ` Mark Brown
2005-12-13 0:25 ` Jeff Garzik
2005-12-13 22:59 ` Mark Brown
2005-12-21 23:48 ` Resubmit: " Mark Brown
2006-01-04 7:32 ` Mark Brown
2006-01-04 13:40 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051205232301.GA4551@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=jgarzik@pobox.com \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=thockin@hockin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).