From: Petr Baudis <pasky@ucw.cz>
To: Kurt Wall <kwallinator@gmail.com>
Cc: zippel@linux-m68k.org, linux-kernel@vger.kernel.org,
sam@ravnborg.org, kbuild-devel@lists.sourceforge.net
Subject: Re: [PATCH 3/3] [kconfig] Direct use of lxdialog routines by menuconfig
Date: Mon, 12 Dec 2005 12:20:33 +0100 [thread overview]
Message-ID: <20051212112033.GB8025@pasky.or.cz> (raw)
In-Reply-To: <200512112218.27286.kwallinator@gmail.com>
Dear diary, on Mon, Dec 12, 2005 at 04:18:26AM CET, I got a letter
where Kurt Wall <kwallinator@gmail.com> said that...
> On Sunday 11 December 2005 07:46 pm, Petr Baudis wrote:
> > After three years, the zombie walks again! This patch (against the latest
> > git tree) cleans up interaction between kconfig's mconf (menuconfig
> > frontend) and lxdialog. Its commandline interface disappears in this patch,
> > instead a .so is packed from the lxdialog objects and the relevant
> > functions are called directly from mconf.
>
> > @@ -808,18 +684,22 @@ static void conf(struct menu *menu)
> > }
> > break;
> > case 4:
> > - if (type == 't')
> > + if (active_type == 't')
> > sym_set_tristate_value(sym, no);
> > break;
> > case 5:
> > - if (type == 't')
> > + if (active_type == 't')
> > sym_set_tristate_value(sym, mod);
> > break;
> > case 6:
> > - if (type == 't')
> > + if (active_type == 't') {
> > sym_toggle_tristate_value(sym);
> > - else if (type == 'm')
> > - conf(submenu);
> > + } else if (active_type == 'm') {
> > + if (single_menu_mode)
> > + submenu->data = (void *) !submenu->data;
>
> Shouldn't this be:
> submenu->data = (void *) (long) !submenu->data;
You are right, it should be so at least for consistency - it'll be fixed
in the next resend of the patch. I can't see why is it needed, though -
shouldn't the int be padded to void* anyway?
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
VI has two modes: the one in which it beeps and the one in which
it doesn't.
next prev parent reply other threads:[~2005-12-12 11:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-12 0:41 [PATCH 0/3] Link lxdialog with mconf directly Petr Baudis
2005-12-12 0:46 ` [PATCH 1/3] [kbuild] Allow building of standalone .so libraries Petr Baudis
2005-12-12 0:46 ` [PATCH 2/3] [kbuild] Possibility to sanely link against off-directory .so Petr Baudis
2005-12-12 0:46 ` [PATCH 3/3] [kconfig] Direct use of lxdialog routines by menuconfig Petr Baudis
2005-12-12 3:18 ` Kurt Wall
2005-12-12 11:20 ` Petr Baudis [this message]
2005-12-13 2:59 ` Kurt Wall
2005-12-14 22:18 ` Roman Zippel
2005-12-16 20:29 ` Sam Ravnborg
2005-12-14 22:57 ` Jesper Juhl
2005-12-12 19:14 ` [PATCH 0/3] Link lxdialog with mconf directly Sam Ravnborg
2005-12-12 20:08 ` Petr Baudis
2005-12-12 20:40 ` Sam Ravnborg
2005-12-16 21:26 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051212112033.GB8025@pasky.or.cz \
--to=pasky@ucw.cz \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=kwallinator@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).