From: Kurt Wall <kwallinator@gmail.com>
To: Petr Baudis <pasky@ucw.cz>
Cc: zippel@linux-m68k.org, linux-kernel@vger.kernel.org,
sam@ravnborg.org, kbuild-devel@lists.sourceforge.net
Subject: Re: [PATCH 3/3] [kconfig] Direct use of lxdialog routines by menuconfig
Date: Mon, 12 Dec 2005 21:59:03 -0500 [thread overview]
Message-ID: <200512122159.03296.kwallinator@gmail.com> (raw)
In-Reply-To: <20051212112033.GB8025@pasky.or.cz>
On Monday 12 December 2005 06:20 am, Petr Baudis wrote:
> Dear diary, on Mon, Dec 12, 2005 at 04:18:26AM CET, I got a letter
> where Kurt Wall <kwallinator@gmail.com> said that...
>
[...]
> > > + submenu->data = (void *) !submenu->data;
> >
> > Shouldn't this be:
> > submenu->data = (void *) (long) !submenu->data;
>
> You are right, it should be so at least for consistency - it'll be fixed
> in the next resend of the patch. I can't see why is it needed, though -
> shouldn't the int be padded to void* anyway?
The cast to long quiets a warning from gcc. Without the cast, it
complains:
$ make menuconfig
HOSTCC scripts/kconfig/mconf.o
scripts/kconfig/mconf.c: In function `conf':
scripts/kconfig/mconf.c:699: warning: cast to pointer from integer of
different size
HOSTLD scripts/kconfig/mconf
scripts/kconfig/mconf arch/x86_64/Kconfig
I like the changes, though -- menuconfig is much snappier and easier on
the eyes without the nasty flashing.
Kurt
--
"I'd love to go out with you, but it's my parakeet's bowling night."
next prev parent reply other threads:[~2005-12-13 2:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-12 0:41 [PATCH 0/3] Link lxdialog with mconf directly Petr Baudis
2005-12-12 0:46 ` [PATCH 1/3] [kbuild] Allow building of standalone .so libraries Petr Baudis
2005-12-12 0:46 ` [PATCH 2/3] [kbuild] Possibility to sanely link against off-directory .so Petr Baudis
2005-12-12 0:46 ` [PATCH 3/3] [kconfig] Direct use of lxdialog routines by menuconfig Petr Baudis
2005-12-12 3:18 ` Kurt Wall
2005-12-12 11:20 ` Petr Baudis
2005-12-13 2:59 ` Kurt Wall [this message]
2005-12-14 22:18 ` Roman Zippel
2005-12-16 20:29 ` Sam Ravnborg
2005-12-14 22:57 ` Jesper Juhl
2005-12-12 19:14 ` [PATCH 0/3] Link lxdialog with mconf directly Sam Ravnborg
2005-12-12 20:08 ` Petr Baudis
2005-12-12 20:40 ` Sam Ravnborg
2005-12-16 21:26 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200512122159.03296.kwallinator@gmail.com \
--to=kwallinator@gmail.com \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pasky@ucw.cz \
--cc=sam@ravnborg.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).