* [PATCH] ia64: eliminate softlockup warning
@ 2005-12-14 23:07 hawkes
2005-12-14 23:16 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: hawkes @ 2005-12-14 23:07 UTC (permalink / raw)
To: Tony Luck, Andrew Morton, linux-ia64, linux-kernel
Cc: Jack Steiner, Keith Owens, hawkes
Fix an unnecessary softlockup watchdog warning in the ia64
uncached_build_memmap() that occurs occasionally at 256p and always at
512p. The problem occurs at boot time.
It would be good if we had a cleaner mechanism to temporarily silence
the watchdog thread, e.g.,
http://marc.theaimsgroup.com/?l=linux-kernel&m=111552476401175&w=2
but until that patch gets merged, this fix will have to suffice.
Signed-off-by: John Hawkes <hawkes@sgi.com>
Index: linux/arch/ia64/kernel/uncached.c
===================================================================
--- linux.orig/arch/ia64/kernel/uncached.c 2005-12-06 15:12:14.000000000 -0800
+++ linux/arch/ia64/kernel/uncached.c 2005-12-14 14:50:55.000000000 -0800
@@ -210,6 +210,7 @@
dprintk(KERN_ERR "uncached_build_memmap(%lx %lx)\n", start, end);
+ touch_softlockup_watchdog();
memset((char *)start, 0, length);
node = paddr_to_nid(start - __IA64_UNCACHED_OFFSET);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ia64: eliminate softlockup warning
2005-12-14 23:07 [PATCH] ia64: eliminate softlockup warning hawkes
@ 2005-12-14 23:16 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2005-12-14 23:16 UTC (permalink / raw)
To: hawkes; +Cc: tony.luck, linux-ia64, linux-kernel, steiner, kaos, hawkes
hawkes@sgi.com wrote:
>
> Fix an unnecessary softlockup watchdog warning in the ia64
> uncached_build_memmap() that occurs occasionally at 256p and always at
> 512p. The problem occurs at boot time.
>
> It would be good if we had a cleaner mechanism to temporarily silence
> the watchdog thread, e.g.,
> http://marc.theaimsgroup.com/?l=linux-kernel&m=111552476401175&w=2
> but until that patch gets merged, this fix will have to suffice.
>
That patch is for the hangcheck timer driver which is unrelated to the
softlockup detector.
>
> Index: linux/arch/ia64/kernel/uncached.c
> ===================================================================
> --- linux.orig/arch/ia64/kernel/uncached.c 2005-12-06 15:12:14.000000000 -0800
> +++ linux/arch/ia64/kernel/uncached.c 2005-12-14 14:50:55.000000000 -0800
> @@ -210,6 +210,7 @@
>
> dprintk(KERN_ERR "uncached_build_memmap(%lx %lx)\n", start, end);
>
> + touch_softlockup_watchdog();
> memset((char *)start, 0, length);
>
> node = paddr_to_nid(start - __IA64_UNCACHED_OFFSET);
Yes, additions like this are a bit awkward, but they're not _that_ bad. It
says "this code is doing something unusual". It's an explicit marker which
we can grep for and which conveys useful information about an exceptional
kernel state.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ia64: eliminate softlockup warning
@ 2005-12-14 23:23 hawkes
0 siblings, 0 replies; 3+ messages in thread
From: hawkes @ 2005-12-14 23:23 UTC (permalink / raw)
To: Tony Luck, Andrew Morton, linux-ia64, linux-kernel
Cc: Jack Steiner, Keith Owens, hawkes
Fix an unnecessary softlockup watchdog warning in the ia64
uncached_build_memmap() that occurs occasionally at 256p and always at
512p. The problem occurs at boot time.
It would be good if we had a cleaner mechanism to temporarily silence
the watchdog thread, e.g.,
http://marc.theaimsgroup.com/?l=linux-kernel&m=111552476401175&w=2
but until that patch gets merged, this fix will have to suffice.
Signed-off-by: John Hawkes <hawkes@sgi.com>
Index: linux/arch/ia64/kernel/uncached.c
===================================================================
--- linux.orig/arch/ia64/kernel/uncached.c 2005-12-06 15:12:14.000000000 -0800
+++ linux/arch/ia64/kernel/uncached.c 2005-12-14 14:50:55.000000000 -0800
@@ -210,6 +210,7 @@
dprintk(KERN_ERR "uncached_build_memmap(%lx %lx)\n", start, end);
+ touch_softlockup_watchdog();
memset((char *)start, 0, length);
node = paddr_to_nid(start - __IA64_UNCACHED_OFFSET);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-12-14 23:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-14 23:07 [PATCH] ia64: eliminate softlockup warning hawkes
2005-12-14 23:16 ` Andrew Morton
2005-12-14 23:23 hawkes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).