From: Andrew Morton <akpm@osdl.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
uclinux-v850@lsi.nec.co.j
Subject: Re: [RFC: 2.6 patch] include/linux/irq.h: #include <linux/smp.h>
Date: Wed, 21 Dec 2005 02:41:33 -0800 [thread overview]
Message-ID: <20051221024133.93b75576.akpm@osdl.org> (raw)
In-Reply-To: <20051221012750.GD5359@stusta.de>
Adrian Bunk <bunk@stusta.de> wrote:
>
> The #include <asm/smp.h> in irq.h was intruduced in 2.6.15-rc.
>
> Since include/linux/irq.h needs code from asm/smp.h only in the
> CONFIG_SMP=y case and linux/smp.h #include's asm/smp.h only in the
> CONFIG_SMP=y case, I'm suggesting this patch to #include <linux/smp.h>
> in irq.h.
>
> I've tested the compilation with both CONFIG_SMP=y and CONFIG_SMP=n
> on i386.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.15-rc6/include/linux/irq.h.old 2005-12-20 21:45:57.000000000 +0100
> +++ linux-2.6.15-rc6/include/linux/irq.h 2005-12-20 21:46:08.000000000 +0100
> @@ -10,7 +10,7 @@
> */
>
> #include <linux/config.h>
> -#include <asm/smp.h> /* cpu_online_map */
> +#include <linux/smp.h>
>
> #if !defined(CONFIG_ARCH_S390)
Yes, it's basically always wrong to include asm/foo.h when linux/foo.h
exists.
next prev parent reply other threads:[~2005-12-21 10:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-21 1:27 [RFC: 2.6 patch] include/linux/irq.h: #include <linux/smp.h> Adrian Bunk
2005-12-21 10:41 ` Andrew Morton [this message]
2005-12-21 11:04 ` Russell King
2005-12-21 21:33 ` Adrian Bunk
2005-12-21 21:48 ` Russell King
2005-12-21 22:11 ` Adrian Bunk
2005-12-21 22:21 ` Russell King
2005-12-21 22:33 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051221024133.93b75576.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=uclinux-v850@lsi.nec.co.j \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).