* [PATCH] Input: fix an OOPS in HID driver
@ 2005-12-17 2:31 Dmitry Torokhov
2005-12-17 10:22 ` Vojtech Pavlik
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2005-12-17 2:31 UTC (permalink / raw)
To: Linus Torvalds; +Cc: LKML, Andrew Morton, Vojtech Pavlik
Subject:
This patch fixes an OOPS in HID driver when connecting simulation
devices generating unknown simulation events.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
drivers/usb/input/hid-input.c | 1 +
1 files changed, 1 insertion(+)
Index: work/drivers/usb/input/hid-input.c
===================================================================
--- work.orig/drivers/usb/input/hid-input.c
+++ work/drivers/usb/input/hid-input.c
@@ -137,6 +137,7 @@ static void hidinput_configure_usage(str
switch (usage->hid & 0xffff) {
case 0xba: map_abs(ABS_RUDDER); break;
case 0xbb: map_abs(ABS_THROTTLE); break;
+ default: goto unknown;
}
break;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Input: fix an OOPS in HID driver
2005-12-17 2:31 [PATCH] Input: fix an OOPS in HID driver Dmitry Torokhov
@ 2005-12-17 10:22 ` Vojtech Pavlik
2005-12-17 16:40 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: Vojtech Pavlik @ 2005-12-17 10:22 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Linus Torvalds, LKML, Andrew Morton
On Fri, Dec 16, 2005 at 09:31:04PM -0500, Dmitry Torokhov wrote:
> Subject:
>
> This patch fixes an OOPS in HID driver when connecting simulation
> devices generating unknown simulation events.
>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Yup, needed indeed. I'm not sure if we want an 'unknown': 'ignore'
might be safer.
> ---
>
> drivers/usb/input/hid-input.c | 1 +
> 1 files changed, 1 insertion(+)
>
> Index: work/drivers/usb/input/hid-input.c
> ===================================================================
> --- work.orig/drivers/usb/input/hid-input.c
> +++ work/drivers/usb/input/hid-input.c
> @@ -137,6 +137,7 @@ static void hidinput_configure_usage(str
> switch (usage->hid & 0xffff) {
> case 0xba: map_abs(ABS_RUDDER); break;
> case 0xbb: map_abs(ABS_THROTTLE); break;
> + default: goto unknown;
> }
> break;
>
>
>
--
Vojtech Pavlik
SuSE Labs, SuSE CR
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Input: fix an OOPS in HID driver
2005-12-17 10:22 ` Vojtech Pavlik
@ 2005-12-17 16:40 ` Dmitry Torokhov
2005-12-17 16:42 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2005-12-17 16:40 UTC (permalink / raw)
To: Vojtech Pavlik; +Cc: Linus Torvalds, LKML, Andrew Morton
On Saturday 17 December 2005 05:22, Vojtech Pavlik wrote:
> On Fri, Dec 16, 2005 at 09:31:04PM -0500, Dmitry Torokhov wrote:
> > Subject:
> >
> > This patch fixes an OOPS in HID driver when connecting simulation
> > devices generating unknown simulation events.
> >
> > Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
>
> Yup, needed indeed. I'm not sure if we want an 'unknown': 'ignore'
> might be safer.
Well, 'unknown' restores the previous behavior (before simulation codes
were added to the driver) so it is pretty safe, however 'ignore' is indeed
more correct I think.
I will send an updated patch. Linus, if you already applied the original
one just ignore the new one - we can change it post 2.6.15 when we add
more simulation codes to HID driver.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Input: fix an OOPS in HID driver
2005-12-17 16:40 ` Dmitry Torokhov
@ 2005-12-17 16:42 ` Dmitry Torokhov
2005-12-22 0:15 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2005-12-17 16:42 UTC (permalink / raw)
To: Vojtech Pavlik; +Cc: Linus Torvalds, LKML, Andrew Morton
This patch fixes an OOPS in HID driver when connecting simulation
devices generating unknown simulation events.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Acked-by: Vojtech Pavlik <vojtech@suse.cz>
---
drivers/usb/input/hid-input.c | 1 +
1 files changed, 1 insertion(+)
Index: work/drivers/usb/input/hid-input.c
===================================================================
--- work.orig/drivers/usb/input/hid-input.c
+++ work/drivers/usb/input/hid-input.c
@@ -137,6 +137,7 @@ static void hidinput_configure_usage(str
switch (usage->hid & 0xffff) {
case 0xba: map_abs(ABS_RUDDER); break;
case 0xbb: map_abs(ABS_THROTTLE); break;
+ default: goto ignore;
}
break;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Input: fix an OOPS in HID driver
2005-12-17 16:42 ` Dmitry Torokhov
@ 2005-12-22 0:15 ` Adrian Bunk
2005-12-22 4:08 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-12-22 0:15 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Vojtech Pavlik, Linus Torvalds, LKML, Andrew Morton
On Sat, Dec 17, 2005 at 11:42:54AM -0500, Dmitry Torokhov wrote:
> This patch fixes an OOPS in HID driver when connecting simulation
> devices generating unknown simulation events.
>...
This patch now went into Linus' tree.
It seems this patch should also go into 2.6.14.5?
If you agree, please submit it to stable@kernel.org .
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Input: fix an OOPS in HID driver
2005-12-22 0:15 ` Adrian Bunk
@ 2005-12-22 4:08 ` Dmitry Torokhov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2005-12-22 4:08 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Vojtech Pavlik, Linus Torvalds, LKML, Andrew Morton
On Wednesday 21 December 2005 19:15, Adrian Bunk wrote:
> On Sat, Dec 17, 2005 at 11:42:54AM -0500, Dmitry Torokhov wrote:
>
> > This patch fixes an OOPS in HID driver when connecting simulation
> > devices generating unknown simulation events.
> >...
>
> This patch now went into Linus' tree.
>
> It seems this patch should also go into 2.6.14.5?
> If you agree, please submit it to stable@kernel.org .
>
Yes, you are right, I will send it there in a minute.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-12-22 4:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-17 2:31 [PATCH] Input: fix an OOPS in HID driver Dmitry Torokhov
2005-12-17 10:22 ` Vojtech Pavlik
2005-12-17 16:40 ` Dmitry Torokhov
2005-12-17 16:42 ` Dmitry Torokhov
2005-12-22 0:15 ` Adrian Bunk
2005-12-22 4:08 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).