* 2.6-git: BITS_PER_LONG
@ 2006-01-07 14:49 Russell King
2006-01-09 17:57 ` Christoph Lameter
0 siblings, 1 reply; 3+ messages in thread
From: Russell King @ 2006-01-07 14:49 UTC (permalink / raw)
To: Linux Kernel List, Christoph Lameter
Hi.
With the latest git, I'm seeing a number of:
include/asm-generic/atomic.h:20:5: warning: "BITS_PER_LONG" is not defined
What's intended here? Should asm-generic/atomic.h include asm/types.h?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.6-git: BITS_PER_LONG
2006-01-07 14:49 2.6-git: BITS_PER_LONG Russell King
@ 2006-01-09 17:57 ` Christoph Lameter
2006-01-09 18:32 ` Russell King
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Lameter @ 2006-01-09 17:57 UTC (permalink / raw)
To: Russell King; +Cc: Linux Kernel List
On Sat, 7 Jan 2006, Russell King wrote:
> Hi.
>
> With the latest git, I'm seeing a number of:
>
> include/asm-generic/atomic.h:20:5: warning: "BITS_PER_LONG" is not defined
>
> What's intended here? Should asm-generic/atomic.h include asm/types.h?
asm/types.h should be included by asm/atomic.h. Which arch is this?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.6-git: BITS_PER_LONG
2006-01-09 17:57 ` Christoph Lameter
@ 2006-01-09 18:32 ` Russell King
0 siblings, 0 replies; 3+ messages in thread
From: Russell King @ 2006-01-09 18:32 UTC (permalink / raw)
To: Christoph Lameter; +Cc: Linux Kernel List
On Mon, Jan 09, 2006 at 09:57:29AM -0800, Christoph Lameter wrote:
> On Sat, 7 Jan 2006, Russell King wrote:
> > With the latest git, I'm seeing a number of:
> >
> > include/asm-generic/atomic.h:20:5: warning: "BITS_PER_LONG" is not defined
> >
> > What's intended here? Should asm-generic/atomic.h include asm/types.h?
>
> asm/types.h should be included by asm/atomic.h.
Disagree - nothing in asm/atomic.h needs asm/types.h. If
asm-generic/atomic.h has this requirement, it should be the one
including asm/types.h (or should it be linux/types.h ?)
> Which arch is this?
ARM.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-01-09 18:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-07 14:49 2.6-git: BITS_PER_LONG Russell King
2006-01-09 17:57 ` Christoph Lameter
2006-01-09 18:32 ` Russell King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).