Re: [PATCH 05/20] V4L/DVB (3343) Add support for DViCO FusionHDTV DVB-T USB devices

Re: [PATCH 05/20] V4L/DVB (3343) Add support for DViCO FusionHDTV DVB-T USB devices

[Andrew Morton]

mchehab@infradead.org wrote:
>
> +	.urb = {
>  +		.type = DVB_USB_BULK,
>  +		.count = 5,
>  +		.endpoint = 0x04,
>  +		.u = {
>  +			.bulk = {
>  +				.buffersize = 8192,
>  +			}
>  +		}
>  +	},

Note that we don't need to go through this pain any more.  With the
gcc-2.95 abandonment we can do

	.u.bulk.buffersize = 8192;

Re: [PATCH 09/20] V4L/DVB (3344d) Stradis video little cleanup

[Andrew Morton]

mchehab@infradead.org wrote:
>
>  +errosd:
>  +	vfree(saa->osdbuf);
>  +	saa->osdbuf = NULL;
>  +erraud:
>  +	vfree(saa->audbuf);
>  +	saa->audbuf = NULL;
>  +errvid:
>  +	vfree(saa->vidbuf);
>  +	saa->vidbuf = NULL;
>  +err:
>  +	return -ENOMEM;
>   }

vfree(NULL) is legal, so this could be:

error:
	vfree(saa->osdbuf);
	vfree(saa->audbuf);
	vfree(saa->vidbuf);
	saa->vidbuf = NULL;
	saa->osdbuf = NULL;
	saa->audbuf = NULL;

Re: [PATCH 13/20] V4L/DVB (3345) Fixes some bad global variables

[Andrew Morton]

mchehab@infradead.org wrote:
>
> +int msp_debug    = 0;    /* msp_debug output */
>  +int msp_once     = 0;    /* no continous stereo monitoring */
>  +int msp_amsound  = 0;    /* hard-wire AM sound at 6.5 Hz (france),
>   			       the autoscan seems work well only with FM... */
>  -int standard = 1;    /* Override auto detect of audio standard, if needed. */
>  -int dolby    = 0;
>  +int msp_standard = 1;    /* Override auto detect of audio msp_standard, if needed. */
>  +int msp_dolby    = 0;

argh, I removed all the "= 0"s and they've come back.