* [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION
@ 2006-01-12 10:51 Adrian Bunk
2006-01-12 21:52 ` Sam Ravnborg
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2006-01-12 10:51 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Matthew Wilcox, grundler, parisc-linux, linux-kernel
This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.15-mm3-hppa/arch/parisc/Makefile.old 2006-01-12 03:11:45.000000000 +0100
+++ linux-2.6.15-mm3-hppa/arch/parisc/Makefile 2006-01-12 03:12:35.000000000 +0100
@@ -35,12 +35,8 @@
OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
-GCC_VERSION := $(call cc-version)
-ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
-$(error Sorry, couldn't find ($(cc-version)).)
-endif
-ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
-$(error Sorry, your compiler is too old ($(GCC_VERSION)). GCC v3.3 or above is required.)
+ifneq ($(shell if [ $(call cc-version) -lt 0303 ] ; then echo "bad"; fi ;),)
+$(error Sorry, your compiler is too old. GCC v3.3 or above is required.)
endif
cflags-y := -pipe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION
2006-01-12 10:51 [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION Adrian Bunk
@ 2006-01-12 21:52 ` Sam Ravnborg
2006-01-12 21:54 ` [parisc-linux] " Kyle McMartin
0 siblings, 1 reply; 6+ messages in thread
From: Sam Ravnborg @ 2006-01-12 21:52 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Matthew Wilcox, grundler, parisc-linux, linux-kernel
On Thu, Jan 12, 2006 at 11:51:57AM +0100, Adrian Bunk wrote:
> This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
I assume the parisc people will take this one.
Sam
>
> --- linux-2.6.15-mm3-hppa/arch/parisc/Makefile.old 2006-01-12 03:11:45.000000000 +0100
> +++ linux-2.6.15-mm3-hppa/arch/parisc/Makefile 2006-01-12 03:12:35.000000000 +0100
> @@ -35,12 +35,8 @@
>
> OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
>
> -GCC_VERSION := $(call cc-version)
> -ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
> -$(error Sorry, couldn't find ($(cc-version)).)
> -endif
> -ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
> -$(error Sorry, your compiler is too old ($(GCC_VERSION)). GCC v3.3 or above is required.)
> +ifneq ($(shell if [ $(call cc-version) -lt 0303 ] ; then echo "bad"; fi ;),)
> +$(error Sorry, your compiler is too old. GCC v3.3 or above is required.)
> endif
>
> cflags-y := -pipe
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [parisc-linux] Re: [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION
2006-01-12 21:52 ` Sam Ravnborg
@ 2006-01-12 21:54 ` Kyle McMartin
2006-01-12 22:35 ` Sam Ravnborg
0 siblings, 1 reply; 6+ messages in thread
From: Kyle McMartin @ 2006-01-12 21:54 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Adrian Bunk, Matthew Wilcox, linux-kernel, parisc-linux
On Thu, Jan 12, 2006 at 10:52:37PM +0100, Sam Ravnborg wrote:
> I assume the parisc people will take this one.
>
I'm confused... you didn't mention at all what the benefit or reason
for this is in your changelog entry...
Cheers,
Kyle
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [parisc-linux] Re: [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION
2006-01-12 21:54 ` [parisc-linux] " Kyle McMartin
@ 2006-01-12 22:35 ` Sam Ravnborg
2006-01-12 23:25 ` Kyle McMartin
0 siblings, 1 reply; 6+ messages in thread
From: Sam Ravnborg @ 2006-01-12 22:35 UTC (permalink / raw)
To: Kyle McMartin; +Cc: Adrian Bunk, Matthew Wilcox, linux-kernel, parisc-linux
On Thu, Jan 12, 2006 at 04:54:09PM -0500, Kyle McMartin wrote:
> On Thu, Jan 12, 2006 at 10:52:37PM +0100, Sam Ravnborg wrote:
> > I assume the parisc people will take this one.
> >
>
> I'm confused... you didn't mention at all what the benefit or reason
> for this is in your changelog entry...
In -mm a patch appeared that took for granted that GCC_VERSION was set.
So it seems that people started to think that GCC_VERSION was part of
the kbuild PAI and realibale. The best way to avoid this confusion was
to kill GCC_VERSION alltogether.
Andrew & I did it in most cases, and Adrian cleaned up parisc and killed
the last instance og GCC_VERSION there.
No functional changes, but a nice cleanup.
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [parisc-linux] Re: [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION
2006-01-12 22:35 ` Sam Ravnborg
@ 2006-01-12 23:25 ` Kyle McMartin
0 siblings, 0 replies; 6+ messages in thread
From: Kyle McMartin @ 2006-01-12 23:25 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Adrian Bunk, Matthew Wilcox, linux-kernel, parisc-linux
On Thu, Jan 12, 2006 at 11:35:00PM +0100, Sam Ravnborg wrote:
> Andrew & I did it in most cases, and Adrian cleaned up parisc and killed
> the last instance og GCC_VERSION there.
>
> No functional changes, but a nice cleanup.
>
OK. Ack that, then, I'll merge it in my tree.
Cheers,
Kyle
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [parisc-linux] Re: [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION
2006-12-01 18:23 ` Grant Grundler
@ 2006-12-08 4:24 ` Kyle McMartin
0 siblings, 0 replies; 6+ messages in thread
From: Kyle McMartin @ 2006-12-08 4:24 UTC (permalink / raw)
To: Grant Grundler
Cc: Adrian Bunk, Andrew Morton, Kyle McMartin, linux-kernel,
Sam Ravnborg, parisc-linux
On Fri, Dec 01, 2006 at 11:23:55AM -0700, Grant Grundler wrote:
> I've committed a variant of this to git://git.parisc-linux.org/git/linux-2.6.git
> I didn't test the failure case - only that it doesn't trigger with
> my current gcc 4.x compilers.
>
> I expect Kyle will push parisc tree to linus in the near future.
>
> Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
>
I like the version ggg committed to our cvs better (and I verified it
correctly functions with gcc-3.0 from Debian woody.)
Picked into my tree.
Cheers,
Kyle
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-12-08 4:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-12 10:51 [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION Adrian Bunk
2006-01-12 21:52 ` Sam Ravnborg
2006-01-12 21:54 ` [parisc-linux] " Kyle McMartin
2006-01-12 22:35 ` Sam Ravnborg
2006-01-12 23:25 ` Kyle McMartin
2006-12-01 11:49 Adrian Bunk
2006-12-01 18:23 ` Grant Grundler
2006-12-08 4:24 ` [parisc-linux] " Kyle McMartin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).