* [PATCH] mempolicy.c compile fix
2006-01-18 8:50 2.6.16-rc1-mm1 Andrew Morton
@ 2006-01-18 10:45 ` Dominik Karall
2006-01-18 10:55 ` 2.6.16-rc1-mm1 Dominik Karall
` (7 subsequent siblings)
8 siblings, 0 replies; 24+ messages in thread
From: Dominik Karall @ 2006-01-18 10:45 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
On Wednesday, 18. January 2006 09:50, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.
>6.16-rc1-mm1/
CC mm/mempolicy.o
mm/mempolicy.c:547: Fehler: Syntaxfehler vor »}«-Zeichen
make[1]: *** [mm/mempolicy.o] Fehler 1
make: *** [mm] Fehler 2
Patch attached.
greets,
dominik
[-- Attachment #2: trivial_compile_fix_mempolicy.diff --]
[-- Type: text/x-diff, Size: 306 bytes --]
--- linux-2.6.11.5/mm/mempolicy.orig.c 2006-01-18 11:36:48.000000000 +0100
+++ linux-2.6.11.5/mm/mempolicy.c 2006-01-18 11:36:54.000000000 +0100
@@ -543,7 +543,6 @@
if ((flags & MPOL_MF_MOVE_ALL) || page_mapcount(page) ==1)
if (isolate_lru_page(page))
list_add(&page->lru, pagelist);
- }
}
/*
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc1-mm1
2006-01-18 8:50 2.6.16-rc1-mm1 Andrew Morton
2006-01-18 10:45 ` [PATCH] mempolicy.c compile fix Dominik Karall
@ 2006-01-18 10:55 ` Dominik Karall
2006-01-18 13:19 ` snd_pcm_format_name() problems [Re: 2.6.16-rc1-mm1] Jiri Slaby
2006-01-18 11:10 ` 2.6.16-rc1-mm1 Reuben Farrelly
` (6 subsequent siblings)
8 siblings, 1 reply; 24+ messages in thread
From: Dominik Karall @ 2006-01-18 10:55 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On Wednesday, 18. January 2006 09:50, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.
>6.16-rc1-mm1/
LD .tmp_vmlinux1
sound/built-in.o:(__ksymtab+0x670): undefined reference to
`snd_pcm_format_name'
make: *** [.tmp_vmlinux1] Fehler 1
If needed, I can provide my config as well.
hth,
dominik
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc1-mm1
2006-01-18 8:50 2.6.16-rc1-mm1 Andrew Morton
2006-01-18 10:45 ` [PATCH] mempolicy.c compile fix Dominik Karall
2006-01-18 10:55 ` 2.6.16-rc1-mm1 Dominik Karall
@ 2006-01-18 11:10 ` Reuben Farrelly
2006-01-18 11:27 ` 2.6.16-rc1-mm1 Andrew Morton
2006-01-18 11:53 ` [PATCH] migrate_page_add mangled brackets during merge Andy Whitcroft
` (5 subsequent siblings)
8 siblings, 1 reply; 24+ messages in thread
From: Reuben Farrelly @ 2006-01-18 11:10 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Dave Jones
On 18/01/2006 9:50 p.m., Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.6.16-rc1-mm1/
>
> - There are a lot of reiser3 features and fixes here. Please test with
> caution, but please test.
>
> - Due to various vendor and glibc release timings I'm aiming to get the *at
> functions (vfa-at-functions-core.patch) and the pselect/ppoll syscalls into
> 2.6.16. This is rather late in the piece and I'd ask interested parties to
> review and comment on those patches asap please.
>
> Ulrich would also like to get the unshare syscall into 2.6.16 but I don't
> recall having seen that code get a decent review and there's quite some
> potential for slipups in this area to cause very bad problems indeed. So
> we're a bit stuck on that one.
>
> - Before I die I'd like to get an x86 allmodconfig build with gcc-3.2.1
> which emits no warnings. Once we have that we can worry about gcc-4 and
> other architectures. Patches will be gratefully leapt upon.
My box came up first time lucky on this release, but I got a new oops:
NET: Registered protocol family 1
NET: Registered protocol family 17
BUG: swapper/1, active lock [b19e6428(b19e6400-b19e6600)] freed!
[<b01040d1>] show_trace+0xd/0xf
[<b0104172>] dump_stack+0x17/0x19
[<b0131c6d>] mutex_debug_check_no_locks_freed+0xff/0x18e
[<b01544b3>] kfree+0x34/0x6a
[<b02a6109>] cpufreq_add_dev+0x127/0x379
[<b023abcb>] sysdev_driver_register+0x70/0xb0
[<b02a67df>] cpufreq_register_driver+0x68/0xfe
[<b03cc19d>] acpi_cpufreq_init+0xd/0xf
[<b01003cc>] init+0xff/0x325
[<b0100d25>] kernel_thread_helper+0x5/0xb
[b19e6428] {cpufreq_add_dev}
.. held by: swapper: 1 [efe14ab0, 115]
... acquired at: cpufreq_add_dev+0x9d/0x379
p4-clockmod: P4/Xeon(TM) CPU On-Demand Clock Modulation available
Starting balanced_irq
The box carried on and booted up normally after that and seems otherwise OK.
I'm yet to test this release out more throughly for some other problems I have
seen recently as they require multiple reboots etc etc, but this one was more
obvious :)
reuben
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc1-mm1
2006-01-18 11:10 ` 2.6.16-rc1-mm1 Reuben Farrelly
@ 2006-01-18 11:27 ` Andrew Morton
2006-01-18 19:09 ` 2.6.16-rc1-mm1 Dave Jones
0 siblings, 1 reply; 24+ messages in thread
From: Andrew Morton @ 2006-01-18 11:27 UTC (permalink / raw)
To: Reuben Farrelly; +Cc: linux-kernel, davej, Ingo Molnar
Reuben Farrelly <reuben-lkml@reub.net> wrote:
>
> My box came up first time lucky on this release, but I got a new oops:
>
> NET: Registered protocol family 1
> NET: Registered protocol family 17
> BUG: swapper/1, active lock [b19e6428(b19e6400-b19e6600)] freed!
> [<b01040d1>] show_trace+0xd/0xf
> [<b0104172>] dump_stack+0x17/0x19
> [<b0131c6d>] mutex_debug_check_no_locks_freed+0xff/0x18e
> [<b01544b3>] kfree+0x34/0x6a
> [<b02a6109>] cpufreq_add_dev+0x127/0x379
> [<b023abcb>] sysdev_driver_register+0x70/0xb0
> [<b02a67df>] cpufreq_register_driver+0x68/0xfe
> [<b03cc19d>] acpi_cpufreq_init+0xd/0xf
> [<b01003cc>] init+0xff/0x325
> [<b0100d25>] kernel_thread_helper+0x5/0xb
> [b19e6428] {cpufreq_add_dev}
> .. held by: swapper: 1 [efe14ab0, 115]
> ... acquired at: cpufreq_add_dev+0x9d/0x379
> p4-clockmod: P4/Xeon(TM) CPU On-Demand Clock Modulation available
Well yes, that code is kfree()ing a locked mutex. It's somewhat weird to
take a lock on a still-private object but whatever. The code's legal
enough.
--- devel/drivers/cpufreq/cpufreq.c~cpufreq-mutex-locking-fix 2006-01-18 03:25:33.000000000 -0800
+++ devel-akpm/drivers/cpufreq/cpufreq.c 2006-01-18 03:25:55.000000000 -0800
@@ -674,6 +674,7 @@ err_out_driver_exit:
cpufreq_driver->exit(policy);
err_out:
+ mutex_unlock(&policy->lock);
kfree(policy);
nomem_out:
_
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc1-mm1
2006-01-18 11:27 ` 2.6.16-rc1-mm1 Andrew Morton
@ 2006-01-18 19:09 ` Dave Jones
2006-01-18 21:40 ` 2.6.16-rc1-mm1 Andrew Morton
2006-01-18 23:13 ` 2.6.16-rc1-mm1 Alan Cox
0 siblings, 2 replies; 24+ messages in thread
From: Dave Jones @ 2006-01-18 19:09 UTC (permalink / raw)
To: Andrew Morton; +Cc: Reuben Farrelly, linux-kernel, Ingo Molnar, arjan
On Wed, Jan 18, 2006 at 03:27:16AM -0800, Andrew Morton wrote:
> Well yes, that code is kfree()ing a locked mutex. It's somewhat weird to
> take a lock on a still-private object but whatever. The code's legal
> enough.
>
>
> --- devel/drivers/cpufreq/cpufreq.c~cpufreq-mutex-locking-fix 2006-01-18 03:25:33.000000000 -0800
> +++ devel-akpm/drivers/cpufreq/cpufreq.c 2006-01-18 03:25:55.000000000 -0800
> @@ -674,6 +674,7 @@ err_out_driver_exit:
> cpufreq_driver->exit(policy);
>
> err_out:
> + mutex_unlock(&policy->lock);
> kfree(policy);
>
This looks odd, because we do this..
mutex_unlock(&policy->lock);
/* set default policy */
ret = cpufreq_set_policy(&new_policy);
if (ret) {
dprintk("setting policy failed\n");
goto err_out_unregister;
}
...
err_out_unregister:
spin_lock_irqsave(&cpufreq_driver_lock, flags);
for_each_cpu_mask(j, policy->cpus)
cpufreq_cpu_data[j] = NULL;
spin_unlock_irqrestore(&cpufreq_driver_lock, flags);
kobject_unregister(&policy->kobj);
wait_for_completion(&policy->kobj_unregister);
err_out_driver_exit:
if (cpufreq_driver->exit)
cpufreq_driver->exit(policy);
err_out:
kfree(policy);
With the patch above we'll mutex_unlock twice.
Is that allowed ? It sounds wrong to me.
Dave
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc1-mm1
2006-01-18 19:09 ` 2.6.16-rc1-mm1 Dave Jones
@ 2006-01-18 21:40 ` Andrew Morton
2006-01-18 21:56 ` 2.6.16-rc1-mm1 Dave Jones
2006-01-18 23:13 ` 2.6.16-rc1-mm1 Alan Cox
1 sibling, 1 reply; 24+ messages in thread
From: Andrew Morton @ 2006-01-18 21:40 UTC (permalink / raw)
To: Dave Jones; +Cc: reuben-lkml, linux-kernel, mingo, arjan
Dave Jones <davej@redhat.com> wrote:
>
> With the patch above we'll mutex_unlock twice.
I was just testing you.
> Is that allowed ? It sounds wrong to me.
It worked!
From: Andrew Morton <akpm@osdl.org>
Make the cpufreq code play nicely with the mutex debugging code: don't free a
held mutex.
Cc: Dave Jones <davej@codemonkey.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
drivers/cpufreq/cpufreq.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff -puN drivers/cpufreq/cpufreq.c~cpufreq-mutex-locking-fix drivers/cpufreq/cpufreq.c
--- devel/drivers/cpufreq/cpufreq.c~cpufreq-mutex-locking-fix 2006-01-18 13:37:09.000000000 -0800
+++ devel-akpm/drivers/cpufreq/cpufreq.c 2006-01-18 13:38:20.000000000 -0800
@@ -612,6 +612,7 @@ static int cpufreq_add_dev (struct sys_d
ret = cpufreq_driver->init(policy);
if (ret) {
dprintk("initialization failed\n");
+ mutex_unlock(&policy->lock);
goto err_out;
}
@@ -623,9 +624,10 @@ static int cpufreq_add_dev (struct sys_d
strlcpy(policy->kobj.name, "cpufreq", KOBJ_NAME_LEN);
ret = kobject_register(&policy->kobj);
- if (ret)
+ if (ret) {
+ mutex_unlock(&policy->lock);
goto err_out_driver_exit;
-
+ }
/* set up files for this cpu device */
drv_attr = cpufreq_driver->attr;
while ((drv_attr) && (*drv_attr)) {
_
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc1-mm1
2006-01-18 21:40 ` 2.6.16-rc1-mm1 Andrew Morton
@ 2006-01-18 21:56 ` Dave Jones
0 siblings, 0 replies; 24+ messages in thread
From: Dave Jones @ 2006-01-18 21:56 UTC (permalink / raw)
To: Andrew Morton; +Cc: reuben-lkml, linux-kernel, mingo, arjan
On Wed, Jan 18, 2006 at 01:40:54PM -0800, Andrew Morton wrote:
> Dave Jones <davej@redhat.com> wrote:
> >
> > With the patch above we'll mutex_unlock twice.
>
> I was just testing you.
>
> > Is that allowed ? It sounds wrong to me.
>
> It worked!
Heh. Thanks, pushed out to cpufreq.git
Dave
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: 2.6.16-rc1-mm1
2006-01-18 19:09 ` 2.6.16-rc1-mm1 Dave Jones
2006-01-18 21:40 ` 2.6.16-rc1-mm1 Andrew Morton
@ 2006-01-18 23:13 ` Alan Cox
2006-01-18 23:37 ` 2.6.16-rc1-mm1 Dave Jones
2006-01-19 7:16 ` 2.6.16-rc1-mm1 Arjan van de Ven
1 sibling, 2 replies; 24+ messages in thread
From: Alan Cox @ 2006-01-18 23:13 UTC (permalink / raw)
To: Dave Jones
Cc: Andrew Morton, Reuben Farrelly, linux-kernel, Ingo Molnar, arjan
On Mer, 2006-01-18 at 14:09 -0500, Dave Jones wrote:
> On Wed, Jan 18, 2006 at 03:27:16AM -0800, Andrew Morton wrote:
>
> > Well yes, that code is kfree()ing a locked mutex. It's somewhat weird to
> > take a lock on a still-private object but whatever. The code's legal
> > enough.
> >
If someone else can be waiting on it then it doesn't look legal ?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: 2.6.16-rc1-mm1
2006-01-18 23:13 ` 2.6.16-rc1-mm1 Alan Cox
@ 2006-01-18 23:37 ` Dave Jones
2006-01-19 7:16 ` 2.6.16-rc1-mm1 Arjan van de Ven
1 sibling, 0 replies; 24+ messages in thread
From: Dave Jones @ 2006-01-18 23:37 UTC (permalink / raw)
To: Alan Cox; +Cc: Andrew Morton, Reuben Farrelly, linux-kernel, Ingo Molnar, arjan
On Wed, Jan 18, 2006 at 11:13:41PM +0000, Alan Cox wrote:
> On Mer, 2006-01-18 at 14:09 -0500, Dave Jones wrote:
> > On Wed, Jan 18, 2006 at 03:27:16AM -0800, Andrew Morton wrote:
> >
> > > Well yes, that code is kfree()ing a locked mutex. It's somewhat weird to
> > > take a lock on a still-private object but whatever. The code's legal
> > > enough.
> > >
>
> If someone else can be waiting on it then it doesn't look legal ?
it's allocated in this function, and we only kfree it in an error path
if something goes wrong. If we get to the kfree, the policy has
never been seen anywhere outside of cpufreq_add_dev(), so nothing
else can be waiting on it.
Dave
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: 2.6.16-rc1-mm1
2006-01-18 23:13 ` 2.6.16-rc1-mm1 Alan Cox
2006-01-18 23:37 ` 2.6.16-rc1-mm1 Dave Jones
@ 2006-01-19 7:16 ` Arjan van de Ven
1 sibling, 0 replies; 24+ messages in thread
From: Arjan van de Ven @ 2006-01-19 7:16 UTC (permalink / raw)
To: Alan Cox
Cc: Dave Jones, Andrew Morton, Reuben Farrelly, linux-kernel, Ingo Molnar
On Wed, 2006-01-18 at 23:13 +0000, Alan Cox wrote:
> On Mer, 2006-01-18 at 14:09 -0500, Dave Jones wrote:
> > On Wed, Jan 18, 2006 at 03:27:16AM -0800, Andrew Morton wrote:
> >
> > > Well yes, that code is kfree()ing a locked mutex. It's somewhat weird to
> > > take a lock on a still-private object but whatever. The code's legal
> > > enough.
> > >
>
> If someone else can be waiting on it then it doesn't look legal ?
This is why Ingo made the decision to just declare it illegal period for
mutexes (and check for it in debug mode). The obvious exceptions are
error paths, but those aren't perf criticial in any way.
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH] migrate_page_add mangled brackets during merge
2006-01-18 8:50 2.6.16-rc1-mm1 Andrew Morton
` (2 preceding siblings ...)
2006-01-18 11:10 ` 2.6.16-rc1-mm1 Reuben Farrelly
@ 2006-01-18 11:53 ` Andy Whitcroft
2006-01-18 12:00 ` 2.6.16-rc1-mm1 Grant Coady
` (4 subsequent siblings)
8 siblings, 0 replies; 24+ messages in thread
From: Andy Whitcroft @ 2006-01-18 11:53 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
migrate_page_add mangled brackets during merge
It appears that there was some kind of merge mangle in migrate_page_add().
Sort out an extraneous bracket and a couple of spacing issues.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
---
mempolicy.c | 4 +---
1 files changed, 1 insertion(+), 3 deletions(-)
diff -upN reference/mm/mempolicy.c current/mm/mempolicy.c
--- reference/mm/mempolicy.c
+++ current/mm/mempolicy.c
@@ -533,17 +533,15 @@ long do_get_mempolicy(int *policy, nodem
/*
* page migration
*/
-
static void migrate_page_add(struct page *page, struct list_head *pagelist,
unsigned long flags)
{
/*
* Avoid migrating a page that is shared with others.
*/
- if ((flags & MPOL_MF_MOVE_ALL) || page_mapcount(page) ==1)
+ if ((flags & MPOL_MF_MOVE_ALL) || page_mapcount(page) == 1)
if (isolate_lru_page(page))
list_add(&page->lru, pagelist);
- }
}
/*
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc1-mm1
2006-01-18 8:50 2.6.16-rc1-mm1 Andrew Morton
` (3 preceding siblings ...)
2006-01-18 11:53 ` [PATCH] migrate_page_add mangled brackets during merge Andy Whitcroft
@ 2006-01-18 12:00 ` Grant Coady
2006-01-18 12:41 ` 2.6.16-rc1-mm1 Reuben Farrelly
` (3 subsequent siblings)
8 siblings, 0 replies; 24+ messages in thread
From: Grant Coady @ 2006-01-18 12:00 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Hi Andrew,
On 1/18/06, Andrew Morton <akpm@osdl.org> wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.6.16-rc1-mm1/
>
dmesg says a few strange things (this were in 15-mm4 too):
Driver 'w83627hf' needs updating - please use bus_type methods
grant@sempro:~$ dmesg| grep SET
**** SET: Misaligned resource pointer: efe72c22 Type 07 Len 0
**** SET: Misaligned resource pointer: efe72c22 Type 07 Len 0
**** SET: Misaligned resource pointer: efe24582 Type 07 Len 0
plus I had to turn the alsa sound driver off to get the thing to
compile, new for
16-rc1-mm1.
> - There are a lot of reiser3 features and fixes here. Please test with
> caution, but please test.
I run reiserfs3, doing allmodconfig now, I'll whinge tomorrow if it
munches the filesystem ;)
<http://bugsplatter.mine.nu/test/boxen/sempro/>
Cheers,
Grant.
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc1-mm1
2006-01-18 8:50 2.6.16-rc1-mm1 Andrew Morton
` (4 preceding siblings ...)
2006-01-18 12:00 ` 2.6.16-rc1-mm1 Grant Coady
@ 2006-01-18 12:41 ` Reuben Farrelly
2006-01-18 22:29 ` Wireless issues (was 2.6.16-rc1-mm1 Valdis.Kletnieks
` (2 subsequent siblings)
8 siblings, 0 replies; 24+ messages in thread
From: Reuben Farrelly @ 2006-01-18 12:41 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On 01/18/2006 09:50 PM, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.6.16-rc1-mm1/
>
> - There are a lot of reiser3 features and fixes here. Please test with
> caution, but please test.
Indeed there are!
This was first, about 15 mins after the partition was mounted:
Jan 19 01:24:32 tornado kernel: ReiserFS: sdb8: warning: vs-4080:
reiserfs_free_block: free_block (sdb8:9217)[dev:blocknr]: bit already cleared
Jan 19 01:24:32 tornado kernel: ReiserFS: sdb8: warning: vs-4080:
reiserfs_free_block: free_block (sdb8:9122)[dev:blocknr]: bit already cleared
Jan 19 01:24:32 tornado kernel: ReiserFS: sdb8: warning: vs-4080:
reiserfs_free_block: free_block (sdb8:9121)[dev:blocknr]: bit already cleared
Jan 19 01:24:32 tornado kernel: ReiserFS: sdb8: warning: vs-4080:
reiserfs_free_block: free_block (sdb8:9120)[dev:blocknr]: bit already cleared
Jan 19 01:24:32 tornado kernel: ReiserFS: sdb8: warning: vs-4080:
reiserfs_free_block: free_block (sdb8:9119)[dev:blocknr]: bit already cleared
Jan 19 01:24:32 tornado kernel: ReiserFS: sdb8: warning: vs-4080:
reiserfs_free_block: free_block (sdb8:9118)[dev:blocknr]: bit already cleared
Jan 19 01:24:32 tornado kernel: ReiserFS: sdb8: warning: vs-4080:
reiserfs_free_block: free_block (sdb8:9117)[dev:blocknr]: bit already cleared
Jan 19 01:24:32 tornado kernel: ReiserFS: sdb8: warning: vs-4080:
reiserfs_free_block: free_block (sdb8:9116)[dev:blocknr]: bit already cleared
Jan 19 01:24:32 tornado kernel: ReiserFS: sdb8: warning: vs-4080:
reiserfs_free_block: free_block (sdb8:8235)[dev:blocknr]: bit already cleared
Then some "bad stuff" (tm) really hit the fan:
Jan 19 01:24:35 tornado kernel: ------------[ cut here ]------------
Jan 19 01:24:35 tornado kernel: kernel BUG at fs/reiserfs/journal.c:1451!
Jan 19 01:24:35 tornado kernel: invalid opcode: 0000 [#1]
Jan 19 01:24:35 tornado kernel: SMP
Jan 19 01:24:35 tornado kernel: last sysfs file:
/devices/pci0000:00/0000:00:1f.3/i2c-0/0-002e/vrm
Jan 19 01:24:35 tornado kernel: Modules linked in: nfsd exportfs lockd sunrpc
lm85 hwmon_vid eeprom ipv6 ip_gre ipt_ECN iptable_mangle iptable_nat ip_nat
ip_conntrack nfnetlink iptable_filter ip_tables binfmt_misc serio_raw hw_random
piix i2c_i801
Jan 19 01:24:35 tornado kernel: CPU: 0
Jan 19 01:24:35 tornado kernel: EIP: 0060:[<b01af240>] Not tainted VLI
Jan 19 01:24:35 tornado kernel: EFLAGS: 00210202 (2.6.16-rc1-mm1)
Jan 19 01:24:35 tornado kernel: EIP is at flush_journal_list+0x55e/0x71d
Jan 19 01:24:35 tornado kernel: eax: 00000001 ebx: f0d0feb0 ecx: 00000000
edx: 00000000
Jan 19 01:24:35 tornado kernel: esi: b5a30724 edi: c17694c0 ebp: efd25cf8
esp: efd25cac
Jan 19 01:24:35 tornado kernel: ds: 007b es: 007b ss: 0068
Jan 19 01:24:36 tornado kernel: Process pdflush (pid: 158, threadinfo=efd25000
task=efd21030)
Jan 19 01:24:36 tornado kernel: Stack: <0>000080ad 00000001 b036f1e0 b1806060
eea1dc40 00000000 00000000 ee16d800
Jan 19 01:24:36 tornado kernel: 00000001 00000000 b03e7604 f0cf1000
00000002 00200246 f0cf914c 00000000
Jan 19 01:24:36 tornado kernel: f0cf1000 f0cf1114 c0b86f40 efd25d4c
b01aef78 00000000 000004e9 b0375600
Jan 19 01:24:36 tornado kernel: Call Trace:
Jan 19 01:24:36 tornado kernel: [<b0103bd5>] show_stack_log_lvl+0xc5/0xea
Jan 19 01:24:36 tornado kernel: [<b0103d61>] show_registers+0x167/0x1ec
Jan 19 01:24:36 tornado kernel: [<b0103f0c>] die+0x126/0x231
Jan 19 01:24:36 tornado kernel: [<b010408a>] do_trap+0x73/0x9e
Jan 19 01:24:36 tornado kernel: [<b010496a>] do_invalid_op+0x97/0xa1
Jan 19 01:24:36 tornado kernel: [<b0103717>] error_code+0x4f/0x54
Jan 19 01:24:36 tornado kernel: [<b01aef78>] flush_journal_list+0x296/0x71d
Jan 19 01:24:37 tornado kernel: [<b01af623>] flush_used_journal_lists+0x224/0x35c
Jan 19 01:24:37 tornado kernel: [<b01b148e>] do_journal_end+0x9f6/0xc20
Jan 19 01:24:37 tornado kernel: [<b01b171d>] journal_end_sync+0x65/0x77
Jan 19 01:24:37 tornado kernel: [<b01a1500>] reiserfs_sync_fs+0x57/0x64
Jan 19 01:24:37 tornado kernel: [<b01a151a>] reiserfs_write_super+0xd/0xf
Jan 19 01:24:37 tornado kernel: [<b015e6ba>] sync_supers+0xbe/0x103
Jan 19 01:24:37 tornado kernel: [<b01414c8>] wb_kupdate+0x38/0x13f
Jan 19 01:24:37 tornado kernel: [<b0141ed2>] pdflush+0xd1/0x1b4
Jan 19 01:24:37 tornado kernel: [<b012e7b7>] kthread+0xa5/0xca
Jan 19 01:24:37 tornado kernel: [<b0100d25>] kernel_thread_helper+0x5/0xb
Jan 19 01:24:37 tornado kernel: Code: 45 d0 e8 3e e8 ff ff 89 45 f0 85 c0 0f 85
0a 01 00 00 8b 4d d0 8b 81 f8 01 00 00 e9 6a fd ff ff 89 d8 e8 67 e3 ff ff 85 c0
74 0a <0f> 0b ab 05 4f 78 33 b0 31 c0 c7 45 dc 00 00 00 00 e9 1a ff ff
Jan 19 01:24:37 tornado kernel: Badness in do_exit at kernel/exit.c:799
Jan 19 01:24:37 tornado kernel: [<b01040d1>] show_trace+0xd/0xf
Jan 19 01:24:37 tornado kernel: [<b0104172>] dump_stack+0x17/0x19
Jan 19 01:24:37 tornado kernel: [<b011f87c>] do_exit+0x83a/0x83f
Jan 19 01:24:37 tornado kernel: [<b0104017>] do_trap+0x0/0x9e
Jan 19 01:24:37 tornado kernel: [<b010408a>] do_trap+0x73/0x9e
Jan 19 01:24:37 tornado kernel: [<b010496a>] do_invalid_op+0x97/0xa1
Jan 19 01:24:37 tornado kernel: [<b0103717>] error_code+0x4f/0x54
Jan 19 01:24:37 tornado kernel: [<b01aef78>] flush_journal_list+0x296/0x71d
Jan 19 01:24:37 tornado kernel: [<b01af623>] flush_used_journal_lists+0x224/0x35c
Jan 19 01:24:37 tornado kernel: [<b01b148e>] do_journal_end+0x9f6/0xc20
Jan 19 01:24:38 tornado kernel: [<b01b171d>] journal_end_sync+0x65/0x77
Jan 19 01:24:38 tornado kernel: [<b01a1500>] reiserfs_sync_fs+0x57/0x64
Jan 19 01:24:38 tornado kernel: [<b01a151a>] reiserfs_write_super+0xd/0xf
Jan 19 01:24:38 tornado kernel: [<b015e6ba>] sync_supers+0xbe/0x103
Jan 19 01:24:38 tornado kernel: [<b01414c8>] wb_kupdate+0x38/0x13f
Jan 19 01:24:38 tornado kernel: [<b0141ed2>] pdflush+0xd1/0x1b4
Jan 19 01:24:38 tornado kernel: [<b012e7b7>] kthread+0xa5/0xca
Jan 19 01:24:38 tornado kernel: [<b0100d25>] kernel_thread_helper+0x5/0xb
Think I'll go quietly retreat to -rc1 on that box now and have a fiddle with my
x86_64 box instead ;-)
reuben
^ permalink raw reply [flat|nested] 24+ messages in thread* Wireless issues (was Re: 2.6.16-rc1-mm1
2006-01-18 8:50 2.6.16-rc1-mm1 Andrew Morton
` (5 preceding siblings ...)
2006-01-18 12:41 ` 2.6.16-rc1-mm1 Reuben Farrelly
@ 2006-01-18 22:29 ` Valdis.Kletnieks
2006-01-18 22:56 ` Andrew Morton
2006-01-19 1:05 ` [-mm patch] make pcmcia_release_{io,irq} static Adrian Bunk
2006-01-19 3:11 ` 2.6.16-rc1-mm1: ia64 compile error Adrian Bunk
8 siblings, 1 reply; 24+ messages in thread
From: Valdis.Kletnieks @ 2006-01-18 22:29 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]
On Wed, 18 Jan 2006 00:50:53 PST, Andrew Morton said:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.6.16-rc1-mm1/
>
My laptop has a Dell TrueMobile 1150 wireless card, which fell over using rc1-mm1.
/sbin/pccardctl ident:
Socket 2:
product info: "Dell", "TrueMobile 1150 Series PC Card", "Version 01.01", ""
manfid: 0x0156, 0x0002
function: 6 (network)
Found in 2.6.16-rc1-mm1 dmesg:
orinoco 0.15rc3 (David Gibson <hermes@gibson.dropbear.id.au>, Pavel Roskin <proski@gnu.org>, et al)
orinoco_cs 0.15rc3 (David Gibson <hermes@gibson.dropbear.id.au>, Pavel Roskin <proski@gnu.org>, et al)
orinoco_cs: GetNextTuple(): No matching CIS configuration. Maybe you need the ignore_cis_vcc=1 parameter.
2.0: GetFirstTuple: No more items
orinoco_cs: GetNextTuple(): No matching CIS configuration. Maybe you need the ignore_cis_vcc=1 parameter.
2.0: GetFirstTuple: No more items
and a non-functioning wireless card.
A 2.6.15 dmesg says:
orinoco 0.15rc3 (David Gibson <hermes@gibson.dropbear.id.au>, Pavel Roskin <proski@gnu.org>, et al)
orinoco_cs 0.15rc3 (David Gibson <hermes@gibson.dropbear.id.au>, Pavel Roskin <proski@gnu.org>, et al)
eth3: Hardware identity 0005:0004:0005:0000
eth3: Station identity 001f:0001:0008:000a
eth3: Firmware determined as Lucent/Agere 8.10
eth3: Ad-hoc demo mode supported
eth3: IEEE standard IBSS ad-hoc mode supported
eth3: WEP supported, 104-bit key
eth3: MAC address 00:02:2D:5C:11:48
eth3: Station name "HERMES I"
eth3: ready
eth3: index 0x01: Vcc 3.3, irq 11, io 0xe100-0xe13f
I haven't tried adding ignore_cis_vcc to the boot yet, I'm on my way out the door...
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: Wireless issues (was Re: 2.6.16-rc1-mm1
2006-01-18 22:29 ` Wireless issues (was 2.6.16-rc1-mm1 Valdis.Kletnieks
@ 2006-01-18 22:56 ` Andrew Morton
2006-01-19 7:33 ` Valdis.Kletnieks
0 siblings, 1 reply; 24+ messages in thread
From: Andrew Morton @ 2006-01-18 22:56 UTC (permalink / raw)
To: Valdis.Kletnieks; +Cc: linux-kernel, Dominik Brodowski
Valdis.Kletnieks@vt.edu wrote:
>
> On Wed, 18 Jan 2006 00:50:53 PST, Andrew Morton said:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.6.16-rc1-mm1/
> >
>
> My laptop has a Dell TrueMobile 1150 wireless card, which fell over using rc1-mm1.
>
> /sbin/pccardctl ident:
>
> Socket 2:
> product info: "Dell", "TrueMobile 1150 Series PC Card", "Version 01.01", ""
> manfid: 0x0156, 0x0002
> function: 6 (network)
>
> Found in 2.6.16-rc1-mm1 dmesg:
>
> orinoco 0.15rc3 (David Gibson <hermes@gibson.dropbear.id.au>, Pavel Roskin <proski@gnu.org>, et al)
> orinoco_cs 0.15rc3 (David Gibson <hermes@gibson.dropbear.id.au>, Pavel Roskin <proski@gnu.org>, et al)
> orinoco_cs: GetNextTuple(): No matching CIS configuration. Maybe you need the ignore_cis_vcc=1 parameter.
> 2.0: GetFirstTuple: No more items
> orinoco_cs: GetNextTuple(): No matching CIS configuration. Maybe you need the ignore_cis_vcc=1 parameter.
> 2.0: GetFirstTuple: No more items
>
> and a non-functioning wireless card.
>
> A 2.6.15 dmesg says:
>
> orinoco 0.15rc3 (David Gibson <hermes@gibson.dropbear.id.au>, Pavel Roskin <proski@gnu.org>, et al)
> orinoco_cs 0.15rc3 (David Gibson <hermes@gibson.dropbear.id.au>, Pavel Roskin <proski@gnu.org>, et al)
> eth3: Hardware identity 0005:0004:0005:0000
> eth3: Station identity 001f:0001:0008:000a
> eth3: Firmware determined as Lucent/Agere 8.10
> eth3: Ad-hoc demo mode supported
> eth3: IEEE standard IBSS ad-hoc mode supported
> eth3: WEP supported, 104-bit key
> eth3: MAC address 00:02:2D:5C:11:48
> eth3: Station name "HERMES I"
> eth3: ready
> eth3: index 0x01: Vcc 3.3, irq 11, io 0xe100-0xe13f
There are orinoco changes in git-pcmcia.patch. Could you try reverting
add-support-for-possio-gcc-aka-pcmcia-siemens-mc45.patch and then
git-pcmcia.patch?
> I haven't tried adding ignore_cis_vcc to the boot yet, I'm on my way out the door...
That shouldn't be necessary.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: Wireless issues (was Re: 2.6.16-rc1-mm1
2006-01-18 22:56 ` Andrew Morton
@ 2006-01-19 7:33 ` Valdis.Kletnieks
2006-01-19 9:33 ` Wireless issues (was Re: 2.6.16-rc1-mm1) Dominik Brodowski
0 siblings, 1 reply; 24+ messages in thread
From: Valdis.Kletnieks @ 2006-01-19 7:33 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Dominik Brodowski
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
On Wed, 18 Jan 2006 14:56:19 PST, Andrew Morton said:
> There are orinoco changes in git-pcmcia.patch. Could you try reverting
> add-support-for-possio-gcc-aka-pcmcia-siemens-mc45.patch and then
> git-pcmcia.patch?
It turns out that we lost the initialization for the 'config_info_t conf;', so
the compare to conf.Vcc was broken. Here's a works-for-me patch.
Signed-Off-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
---
--- linux-2.6.16-rc1-mm1/drivers/net/wireless/orinoco_cs.c.v1 2006-01-19 01:52:03.000000000 -0500
+++ linux-2.6.16-rc1-mm1/drivers/net/wireless/orinoco_cs.c 2006-01-19 02:21:25.000000000 -0500
@@ -205,6 +205,10 @@ orinoco_cs_config(struct pcmcia_device *
/* Configure card */
link->state |= DEV_CONFIG;
+ /* Look up the current Vcc */
+ CS_CHECK(GetConfigurationInfo,
+ pcmcia_get_configuration_info(link, &conf));
+
/*
* In this loop, we scan the CIS for configuration table
* entries, each of which describes a valid card
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: Wireless issues (was Re: 2.6.16-rc1-mm1)
2006-01-19 7:33 ` Valdis.Kletnieks
@ 2006-01-19 9:33 ` Dominik Brodowski
0 siblings, 0 replies; 24+ messages in thread
From: Dominik Brodowski @ 2006-01-19 9:33 UTC (permalink / raw)
To: Valdis.Kletnieks; +Cc: Andrew Morton, linux-kernel
Hi,
On Thu, Jan 19, 2006 at 02:33:39AM -0500, Valdis.Kletnieks@vt.edu wrote:
> On Wed, 18 Jan 2006 14:56:19 PST, Andrew Morton said:
>
> > There are orinoco changes in git-pcmcia.patch. Could you try reverting
> > add-support-for-possio-gcc-aka-pcmcia-siemens-mc45.patch and then
> > git-pcmcia.patch?
>
> It turns out that we lost the initialization for the 'config_info_t conf;', so
> the compare to conf.Vcc was broken. Here's a works-for-me patch.
Sorry about that, I accidentally removed this in orinoco_cs and spectrum_cs
where it is still needed, while the removal is safe in many other places.
git-pcmcia will be updated accordingly (i.e. with the initialization not
being removed in the first place) soon.
Many thanks,
Dominik
^ permalink raw reply [flat|nested] 24+ messages in thread
* [-mm patch] make pcmcia_release_{io,irq} static
2006-01-18 8:50 2.6.16-rc1-mm1 Andrew Morton
` (6 preceding siblings ...)
2006-01-18 22:29 ` Wireless issues (was 2.6.16-rc1-mm1 Valdis.Kletnieks
@ 2006-01-19 1:05 ` Adrian Bunk
2006-01-19 11:14 ` Dominik Brodowski
2006-01-19 3:11 ` 2.6.16-rc1-mm1: ia64 compile error Adrian Bunk
8 siblings, 1 reply; 24+ messages in thread
From: Adrian Bunk @ 2006-01-19 1:05 UTC (permalink / raw)
To: Andrew Morton, Dominik Brodowski; +Cc: linux-kernel
On Wed, Jan 18, 2006 at 12:50:53AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.15-mm4:
>...
> git-pcmcia.patch
>...
> git trees
>...
We can now make pcmcia_release_{io,irq} static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc1-mm1-full/drivers/pcmcia/pcmcia_resource.c.old 2006-01-18 23:15:05.000000000 +0100
+++ linux-2.6.16-rc1-mm1-full/drivers/pcmcia/pcmcia_resource.c 2006-01-18 23:15:23.000000000 +0100
@@ -511,7 +511,7 @@
* don't bother checking the port ranges against the current socket
* values.
*/
-int pcmcia_release_io(struct pcmcia_device *p_dev, io_req_t *req)
+static int pcmcia_release_io(struct pcmcia_device *p_dev, io_req_t *req)
{
struct pcmcia_socket *s = p_dev->socket;
config_t *c = p_dev->function_config;
@@ -537,7 +537,7 @@
} /* pcmcia_release_io */
-int pcmcia_release_irq(struct pcmcia_device *p_dev, irq_req_t *req)
+static int pcmcia_release_irq(struct pcmcia_device *p_dev, irq_req_t *req)
{
struct pcmcia_socket *s = p_dev->socket;
config_t *c= p_dev->function_config;
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [-mm patch] make pcmcia_release_{io,irq} static
2006-01-19 1:05 ` [-mm patch] make pcmcia_release_{io,irq} static Adrian Bunk
@ 2006-01-19 11:14 ` Dominik Brodowski
0 siblings, 0 replies; 24+ messages in thread
From: Dominik Brodowski @ 2006-01-19 11:14 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel
On Thu, Jan 19, 2006 at 02:05:36AM +0100, Adrian Bunk wrote:
> On Wed, Jan 18, 2006 at 12:50:53AM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.15-mm4:
> >...
> > git-pcmcia.patch
> >...
> > git trees
> >...
>
>
> We can now make pcmcia_release_{io,irq} static.
Applied, thanks.
Dominik
^ permalink raw reply [flat|nested] 24+ messages in thread
* 2.6.16-rc1-mm1: ia64 compile error
2006-01-18 8:50 2.6.16-rc1-mm1 Andrew Morton
` (7 preceding siblings ...)
2006-01-19 1:05 ` [-mm patch] make pcmcia_release_{io,irq} static Adrian Bunk
@ 2006-01-19 3:11 ` Adrian Bunk
2006-01-19 3:27 ` Greg KH
2006-01-19 3:31 ` Mark Maule
8 siblings, 2 replies; 24+ messages in thread
From: Adrian Bunk @ 2006-01-19 3:11 UTC (permalink / raw)
To: Andrew Morton, Mark Maule, Greg Kroah-Hartman
Cc: linux-kernel, tony.luck, linux-ia64
On Wed, Jan 18, 2006 at 12:50:53AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.15-mm4:
>...
> +gregkh-pci-pci-msi-vector-targeting-abstractions.patch
>...
> PCI tree updates
>...
This patch breaks the ia64 defconfig:
<-- snip -->
...
CC arch/ia64/dig/machvec.o
In file included from arch/ia64/dig/machvec.c:3:
include/asm/machvec_init.h:32: error: 'ia64_msi_init' undeclared here (not in a function)
make[1]: *** [arch/ia64/dig/machvec.o] Error 1
<-- snip -->
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: 2.6.16-rc1-mm1: ia64 compile error
2006-01-19 3:11 ` 2.6.16-rc1-mm1: ia64 compile error Adrian Bunk
@ 2006-01-19 3:27 ` Greg KH
2006-01-19 3:31 ` Mark Maule
1 sibling, 0 replies; 24+ messages in thread
From: Greg KH @ 2006-01-19 3:27 UTC (permalink / raw)
To: Adrian Bunk
Cc: Andrew Morton, Mark Maule, linux-kernel, tony.luck, linux-ia64
On Thu, Jan 19, 2006 at 04:11:55AM +0100, Adrian Bunk wrote:
> On Wed, Jan 18, 2006 at 12:50:53AM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.15-mm4:
> >...
> > +gregkh-pci-pci-msi-vector-targeting-abstractions.patch
> >...
> > PCI tree updates
> >...
>
> This patch breaks the ia64 defconfig:
>
> <-- snip -->
>
> ...
> CC arch/ia64/dig/machvec.o
> In file included from arch/ia64/dig/machvec.c:3:
> include/asm/machvec_init.h:32: error: 'ia64_msi_init' undeclared here (not in a function)
> make[1]: *** [arch/ia64/dig/machvec.o] Error 1
Yeah, I had to drop the 3rd patch in that series that wsa ia64 specific
due to major conflicts. Mark said he would give me updated patches
soon.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: 2.6.16-rc1-mm1: ia64 compile error
2006-01-19 3:11 ` 2.6.16-rc1-mm1: ia64 compile error Adrian Bunk
2006-01-19 3:27 ` Greg KH
@ 2006-01-19 3:31 ` Mark Maule
1 sibling, 0 replies; 24+ messages in thread
From: Mark Maule @ 2006-01-19 3:31 UTC (permalink / raw)
To: Adrian Bunk
Cc: Andrew Morton, Greg Kroah-Hartman, linux-kernel, tony.luck, linux-ia64
yes, I discovered this last night for generic builds. I'm fixing up the MSI
patches and will send them out in the morning.
sn2_defconfig and zx1_defconfig builds work, more generic ones do not.
Sorry 'bout that.
Mark
On Thu, Jan 19, 2006 at 04:11:55AM +0100, Adrian Bunk wrote:
> On Wed, Jan 18, 2006 at 12:50:53AM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.15-mm4:
> >...
> > +gregkh-pci-pci-msi-vector-targeting-abstractions.patch
> >...
> > PCI tree updates
> >...
>
> This patch breaks the ia64 defconfig:
>
> <-- snip -->
>
> ...
> CC arch/ia64/dig/machvec.o
> In file included from arch/ia64/dig/machvec.c:3:
> include/asm/machvec_init.h:32: error: 'ia64_msi_init' undeclared here (not in a function)
> make[1]: *** [arch/ia64/dig/machvec.o] Error 1
>
> <-- snip -->
>
> cu
> Adrian
^ permalink raw reply [flat|nested] 24+ messages in thread