From: Andrew Morton <akpm@osdl.org>
To: Ingo Oeser <ioe-lkml@rameria.de>
Cc: linux-kernel@vger.kernel.org, dsingleton@mvista.com,
drepper@gmail.com, mingo@elte.hu
Subject: Re: [robust-futex-4] futex: robust futex support
Date: Fri, 20 Jan 2006 14:18:01 -0800 [thread overview]
Message-ID: <20060120141801.71d842f7.akpm@osdl.org> (raw)
In-Reply-To: <200601201841.24565.ioe-lkml@rameria.de>
Ingo Oeser <ioe-lkml@rameria.de> wrote:
>
> > > + list_for_each_entry_safe(this, next, head, list) {
> > > + list_del(&this->list);
> > > + kmem_cache_free(robust_futex_cachep, this);
> > > + }
> >
> > If we're throwing away the entire contents of the list, there's no need to
> > detach items as we go.
>
> Couldn't even detach the list elements first by
>
> list_splice_init(&mapping->robust_head->robust_list, head);
>
> and free the list from "head" after releasing the mutex?
> This would reduce lock contention, no?
Yes, it would reduce lock contention nicely.
next prev parent reply other threads:[~2006-01-20 22:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-14 1:00 [robust-futex-1] futex: robust futex support David Singleton
2006-01-15 0:02 ` Ulrich Drepper
2006-01-15 0:04 ` david singleton
2006-01-15 5:18 ` Ulrich Drepper
2006-01-15 20:00 ` David Singleton
2006-01-17 2:27 ` [robust-futex-3] " david singleton
2006-01-17 17:32 ` Ulrich Drepper
2006-01-17 17:50 ` Ulrich Drepper
2006-01-19 2:26 ` [robust-futex-4] " david singleton
2006-01-19 5:22 ` Andrew Morton
2006-01-20 0:47 ` [robust-futex-5] " david singleton
2006-01-20 17:41 ` [robust-futex-4] " Ingo Oeser
2006-01-20 22:18 ` Andrew Morton [this message]
2006-01-21 2:30 ` david singleton
2006-01-23 18:20 ` Todd Kneisel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060120141801.71d842f7.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=drepper@gmail.com \
--cc=dsingleton@mvista.com \
--cc=ioe-lkml@rameria.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).