From: Ulrich Drepper <drepper@gmail.com>
To: david singleton <dsingleton@mvista.com>
Cc: akpm@osdl.org, mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [robust-futex-3] futex: robust futex support
Date: Tue, 17 Jan 2006 09:32:29 -0800 [thread overview]
Message-ID: <a36005b50601170932r1f0a9eb8kea35015ede1e9b8f@mail.gmail.com> (raw)
In-Reply-To: <C59522FA-8700-11DA-B27C-000A959BB91E@mvista.com>
On 1/16/06, david singleton <dsingleton@mvista.com> wrote:
> I've fixed another memory leak in free_robust_list. The entries in
> the slab caches
> now look correct through the full test suite up to 7500 threads. Does
> your glibc
> work correctly with this patch?
I'll see shortly.
But looking at the patch, I don't understand the use of
FUTEX_ATTR_SHARED. The EADDRNOTAVAIL error is something the kernel
has to return if the address is not that of an object in a shared
memory region. It's not information directly provided by the user of
futex_register.
So, I suggest removing the attr parameter from futex_register and
after get_futex_key, when you know where the futex is actually
located, return -EADDRNOTAVAIL if the futex is in private memory.
next prev parent reply other threads:[~2006-01-17 17:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-14 1:00 [robust-futex-1] futex: robust futex support David Singleton
2006-01-15 0:02 ` Ulrich Drepper
2006-01-15 0:04 ` david singleton
2006-01-15 5:18 ` Ulrich Drepper
2006-01-15 20:00 ` David Singleton
2006-01-17 2:27 ` [robust-futex-3] " david singleton
2006-01-17 17:32 ` Ulrich Drepper [this message]
2006-01-17 17:50 ` Ulrich Drepper
2006-01-19 2:26 ` [robust-futex-4] " david singleton
2006-01-19 5:22 ` Andrew Morton
2006-01-20 0:47 ` [robust-futex-5] " david singleton
2006-01-20 17:41 ` [robust-futex-4] " Ingo Oeser
2006-01-20 22:18 ` Andrew Morton
2006-01-21 2:30 ` david singleton
2006-01-23 18:20 ` Todd Kneisel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a36005b50601170932r1f0a9eb8kea35015ede1e9b8f@mail.gmail.com \
--to=drepper@gmail.com \
--cc=akpm@osdl.org \
--cc=dsingleton@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).