* Guillemot joystick not working since 2.6.14
@ 2006-01-22 11:50 Marek Vašut
2006-01-22 19:55 ` Alexey Dobriyan
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vašut @ 2006-01-22 11:50 UTC (permalink / raw)
To: linux-kernel
Hi,
I found a problem with guillemot "force feedback joystick". It´s not working
since 2.6.13.2-mm3. 2.6.14.2 wasn´t working too. 2.6.15-mm2 is the same. When
I plug it in, it prints "configuration #1 chosen from 1 choice" "registered
new driver iforce" and >"iforce: probe of 4-2:1.0 failed with error -12"<
It was working well on 2.6.13.1, but now it doesnt. I am not able to debug the
kernel. Could you please fix this or tell me what am I doing wrong? Thanks.
Marex
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Guillemot joystick not working since 2.6.14
2006-01-22 11:50 Guillemot joystick not working since 2.6.14 Marek Vašut
@ 2006-01-22 19:55 ` Alexey Dobriyan
2006-01-23 5:48 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Alexey Dobriyan @ 2006-01-22 19:55 UTC (permalink / raw)
To: Marek Va?ut; +Cc: linux-kernel
On Sun, Jan 22, 2006 at 12:50:26PM +0100, Marek Va?ut wrote:
> I found a problem with guillemot "force feedback joystick". It?s not working
> since 2.6.13.2-mm3. 2.6.14.2 wasn?t working too. 2.6.15-mm2 is the same. When
> I plug it in, it prints "configuration #1 chosen from 1 choice" "registered
> new driver iforce" and >"iforce: probe of 4-2:1.0 failed with error -12"<
> It was working well on 2.6.13.1, but now it doesnt. I am not able to debug the
> kernel. Could you please fix this or tell me what am I doing wrong? Thanks.
Please try this patch
--- a/drivers/input/joystick/iforce/iforce-main.c
+++ b/drivers/input/joystick/iforce/iforce-main.c
@@ -345,7 +345,7 @@ int iforce_init_device(struct iforce *if
int i;
input_dev = input_allocate_device();
- if (input_dev)
+ if (!input_dev)
return -ENOMEM;
init_waitqueue_head(&iforce->wait);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Guillemot joystick not working since 2.6.14
2006-01-22 19:55 ` Alexey Dobriyan
@ 2006-01-23 5:48 ` Dmitry Torokhov
2006-01-23 15:28 ` [PATCH] iforce: fix -ENOMEM check Alexey Dobriyan
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2006-01-23 5:48 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Marek Va?ut, linux-kernel
On Sunday 22 January 2006 14:55, Alexey Dobriyan wrote:
> On Sun, Jan 22, 2006 at 12:50:26PM +0100, Marek Va?ut wrote:
> > I found a problem with guillemot "force feedback joystick". It?s not working
> > since 2.6.13.2-mm3. 2.6.14.2 wasn?t working too. 2.6.15-mm2 is the same. When
> > I plug it in, it prints "configuration #1 chosen from 1 choice" "registered
> > new driver iforce" and >"iforce: probe of 4-2:1.0 failed with error -12"<
> > It was working well on 2.6.13.1, but now it doesnt. I am not able to debug the
> > kernel. Could you please fix this or tell me what am I doing wrong? Thanks.
>
> Please try this patch
>
> --- a/drivers/input/joystick/iforce/iforce-main.c
> +++ b/drivers/input/joystick/iforce/iforce-main.c
> @@ -345,7 +345,7 @@ int iforce_init_device(struct iforce *if
> int i;
>
> input_dev = input_allocate_device();
> - if (input_dev)
> + if (!input_dev)
> return -ENOMEM;
>
> init_waitqueue_head(&iforce->wait);
>
Doh! Could you please add your signoff so I'd add it to the input tree?
Anyway, dynalloc went in 2.6.15 so something else is amiss...
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] iforce: fix -ENOMEM check
2006-01-23 5:48 ` Dmitry Torokhov
@ 2006-01-23 15:28 ` Alexey Dobriyan
2006-01-25 5:51 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Alexey Dobriyan @ 2006-01-23 15:28 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Marek Va?ut, linux-kernel
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
drivers/input/joystick/iforce/iforce-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/input/joystick/iforce/iforce-main.c
+++ b/drivers/input/joystick/iforce/iforce-main.c
@@ -345,7 +345,7 @@ int iforce_init_device(struct iforce *if
int i;
input_dev = input_allocate_device();
- if (input_dev)
+ if (!input_dev)
return -ENOMEM;
init_waitqueue_head(&iforce->wait);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iforce: fix -ENOMEM check
2006-01-23 15:28 ` [PATCH] iforce: fix -ENOMEM check Alexey Dobriyan
@ 2006-01-25 5:51 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2006-01-25 5:51 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Marek Va?ut, linux-kernel
On Monday 23 January 2006 10:28, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> drivers/input/joystick/iforce/iforce-main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/input/joystick/iforce/iforce-main.c
> +++ b/drivers/input/joystick/iforce/iforce-main.c
> @@ -345,7 +345,7 @@ int iforce_init_device(struct iforce *if
> int i;
>
> input_dev = input_allocate_device();
> - if (input_dev)
> + if (!input_dev)
> return -ENOMEM;
>
> init_waitqueue_head(&iforce->wait);
>
>
Applied to the input tree, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-01-25 5:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-22 11:50 Guillemot joystick not working since 2.6.14 Marek Vašut
2006-01-22 19:55 ` Alexey Dobriyan
2006-01-23 5:48 ` Dmitry Torokhov
2006-01-23 15:28 ` [PATCH] iforce: fix -ENOMEM check Alexey Dobriyan
2006-01-25 5:51 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).