From: Andi Kleen <ak@suse.de>
To: Dan Aloni <da-x@monatomic.org>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
Keith Owens <kaos@sgi.com>
Subject: Re: [PATCH] x86_64: Remove useless KDB vector
Date: Mon, 23 Jan 2006 15:18:52 +0100 [thread overview]
Message-ID: <200601231518.53190.ak@suse.de> (raw)
In-Reply-To: <20060123135551.GA14271@localdomain>
On Monday 23 January 2006 14:55, Dan Aloni wrote:
> > It was set as an NMI, but the NMI bit always forces an interrupt
> > to end up at vector 2. So it was never used. Remove.
>
> So with this function removed, what is the proper fix for using
> the kdb x86_64 patch (forward-ported from 2.6.14) on 2.6.16-rc1?
> Can I expect it to work properly if I just remove the function
> call?
Add this code snippet to arch/x86_64/kdb/kdbasupport.c
#include <asm/mach_apic.h>
#include <asm/hw_irq.h>
void smp_kdb_stop(void)
{
send_IPI_allbutself(NMI_VECTOR);
}
-Andi
prev parent reply other threads:[~2006-01-23 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-23 13:55 [PATCH] x86_64: Remove useless KDB vector Dan Aloni
2006-01-23 14:18 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601231518.53190.ak@suse.de \
--to=ak@suse.de \
--cc=da-x@monatomic.org \
--cc=kaos@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).