linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] x86_64: Remove useless KDB vector
@ 2006-01-23 13:55 Dan Aloni
  2006-01-23 14:18 ` Andi Kleen
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Aloni @ 2006-01-23 13:55 UTC (permalink / raw)
  To: Andi Kleen, Linux Kernel List; +Cc: Keith Owens

> It was set as an NMI, but the NMI bit always forces an interrupt
> to end up at vector 2. So it was never used. Remove.

So with this function removed, what is the proper fix for using 
the kdb x86_64 patch (forward-ported from 2.6.14) on 2.6.16-rc1?
Can I expect it to work properly if I just remove the function 
call?

-- 
Dan Aloni
da-x@monatomic.org, da-x@colinux.org, da-x@gmx.net, dan@xiv.co.il

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86_64: Remove useless KDB vector
  2006-01-23 13:55 [PATCH] x86_64: Remove useless KDB vector Dan Aloni
@ 2006-01-23 14:18 ` Andi Kleen
  0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2006-01-23 14:18 UTC (permalink / raw)
  To: Dan Aloni; +Cc: Linux Kernel List, Keith Owens

On Monday 23 January 2006 14:55, Dan Aloni wrote:
> > It was set as an NMI, but the NMI bit always forces an interrupt
> > to end up at vector 2. So it was never used. Remove.
> 
> So with this function removed, what is the proper fix for using 
> the kdb x86_64 patch (forward-ported from 2.6.14) on 2.6.16-rc1?
> Can I expect it to work properly if I just remove the function 
> call?

Add this code snippet to arch/x86_64/kdb/kdbasupport.c

#include <asm/mach_apic.h>
#include <asm/hw_irq.h>
void smp_kdb_stop(void)
{
       send_IPI_allbutself(NMI_VECTOR);
}


-Andi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-01-23 14:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-23 13:55 [PATCH] x86_64: Remove useless KDB vector Dan Aloni
2006-01-23 14:18 ` Andi Kleen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).