linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Greg KH <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BUG] debugfs: hard link count wrong
Date: Fri, 27 Jan 2006 08:04:23 +0100	[thread overview]
Message-ID: <20060127070423.GB9331@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20060127063804.GA4680@suse.de>

> > > Device: eh/14d  Inode: 15528       Links: 2
> > Links should be 3, I thought? For an empty directory it's 2 and as soon as
> > you create a new directory in there it should be increased by 1. Therefore
> > it should be 3. Or am I missing something?
> 
> Yeah, I think you are correct.  But I don't see where in the debugfs
> code I messed this up...
> 
> In debugfs_mkdir() we increment the parent i_nlink properly if we create
> the new subdirectory, and based on other implementations like this
> (usbfs), that logic seems to be correct.
> 
> Unless something is odd with creating a directory in the root of the fs.
> Does the subdirectory you have created have the proper number of links?

Yes, everything below the debug directory itself seems to be ok.

> > Btw.: my find version: "GNU find version 4.2.20".
> Hm, newer versions of find don't complain about this?

The latest version I could find at http://ftp.gnu.org/pub/gnu/findutils/
is 4.2.27 which still complains. No, idea from where you got the 4.2.30 :)

Thank,
Heiko

  reply	other threads:[~2006-01-27  7:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-26 14:11 [BUG] debugfs: hard link count wrong Heiko Carstens
2006-01-27  3:25 ` Greg KH
2006-01-27  5:56   ` Heiko Carstens
2006-01-27  6:38     ` Greg KH
2006-01-27  7:04       ` Heiko Carstens [this message]
2006-01-27  7:17         ` Greg KH
2006-01-27 17:43           ` Vincent Hanquez
2006-01-30  6:51             ` Heiko Carstens
2006-02-01 12:08             ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060127070423.GB9331@osiris.boeblingen.de.ibm.com \
    --to=heiko.carstens@de.ibm.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).