Re: [BUG] debugfs: hard link count wrong

[Heiko Carstens <heiko.carstens@de.ibm.com>]

> looks like all fs that use simple_fill_super got a root inode with
> i_nlink=1 at the start of day.
> 
> I've compared with shmem, the nlink is incremented to 2 by a call to
> shmem_get_inode, when filling_super.
> 
> I've test the following patch with debugfs and securityfs, and its
> seems to cure the problem.
> 
> ------
> 
> Fix incorrect nlink of root inode for filesystems that use simple_fill_super
> 
> Signed-off-by: Vincent Hanquez <vincent@snarc.org>
> 
> diff -Naur a/fs/libfs.c a/fs/libfs.c
> --- a/fs/libfs.c	2006-01-03 03:21:10.000000000 +0000
> +++ b/fs/libfs.c	2006-01-27 17:43:31.000000000 +0000
> @@ -388,6 +388,7 @@
>  	inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
>  	inode->i_op = &simple_dir_inode_operations;
>  	inode->i_fop = &simple_dir_operations;
> +	inode->i_nlink = 2;
>  	root = d_alloc_root(inode);
>  	if (!root) {
>  		iput(inode);
> 
> -

Sorry to annoy you, but does this patch look ok? Who is actually the
maintainer of libfs?
Thought it would be good to have this fixed...
Thread started here:
http://marc.theaimsgroup.com/?l=linux-kernel&m=113828486029233&w=2

Thanks,
Heiko