From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Andi Kleen <ak@suse.de>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
mingo@elte.hu, nickpiggin@yahoo.com.au,
linux-kernel@vger.kernel.org, rohit.seth@intel.com,
asit.k.mallick@intel.com
Subject: Re: [Patch] sched: new sched domain for representing multi-core
Date: Fri, 27 Jan 2006 17:45:12 -0800 [thread overview]
Message-ID: <20060127174512.A6229@unix-os.sc.intel.com> (raw)
In-Reply-To: <200601270542.12404.ak@suse.de>; from ak@suse.de on Fri, Jan 27, 2006 at 05:42:11AM +0100
On Fri, Jan 27, 2006 at 05:42:11AM +0100, Andi Kleen wrote:
> On Thursday 26 January 2006 10:51, Siddha, Suresh B wrote:
>
> With this patch does the new distance checking code in the scheduler
> from Ingo automatically discover all the relevant distances?
Yes.
>
> > +#ifdef CONFIG_SMP
> > + unsigned int cpu = (c == &boot_cpu_data) ? 0 : (c - cpu_data);
> > +#endif
>
> Wouldn't it be better to just put that information into the cpuinfo_x86?
> We're having too many per CPU arrays already.
> Actually it would be better to pass this information in some other way
> to smpboot.c than to add more and more arrays like this. It's only
> needed for the current CPU, because for the others the information
> is in cpu_llc_shared_map
In smpboot.c we require the llc id of current CPU and all other online cpus.
I will put cpu_llc_shared_map info into cpuinfo_x86 (in future with power
savings sched policy, it will be used whenever someone changes sched policy)
And will make cpu_llc_id[] as __cpuinitdata.
>
> Perhaps SMP boot up should pass around a pointer to temporary data like this?
> Or discover it in smpboot.c with a function call?
>
> > -#ifdef CONFIG_SCHED_SMT
> > +#if defined(CONFIG_SCHED_SMT)
> > sd = &per_cpu(cpu_domains, i);
> > +#elif defined(CONFIG_SCHED_MC)
>
> elif? What happens where there are both shared caches and SMT?
Lowest domain the cpu gets attached to it is SMT domain.
thanks,
suresh
next prev parent reply other threads:[~2006-01-28 1:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-26 9:51 [Patch] sched: new sched domain for representing multi-core Siddha, Suresh B
2006-01-27 0:08 ` Ingo Molnar
2006-01-27 3:51 ` Siddha, Suresh B
2006-01-28 0:00 ` Andrew Morton
2006-01-31 1:28 ` Siddha, Suresh B
2006-02-01 1:12 ` Andrew Morton
2006-02-01 1:48 ` Siddha, Suresh B
2006-02-01 2:21 ` Andrew Morton
2006-02-01 2:52 ` Siddha, Suresh B
2006-01-27 4:42 ` Andi Kleen
2006-01-28 1:45 ` Siddha, Suresh B [this message]
2006-01-29 16:56 ` Pavel Machek
2006-01-31 1:31 ` Siddha, Suresh B
2006-02-09 9:59 Samuel Thibault
2006-02-11 0:51 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060127174512.A6229@unix-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=ak@suse.de \
--cc=asit.k.mallick@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=rohit.seth@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).