From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
mingo@elte.hu, nickpiggin@yahoo.com.au, ak@suse.de,
linux-kernel@vger.kernel.org, rohit.seth@intel.com,
asit.k.mallick@intel.com
Subject: Re: [Patch] sched: new sched domain for representing multi-core
Date: Tue, 31 Jan 2006 17:48:20 -0800 [thread overview]
Message-ID: <20060131174820.A32626@unix-os.sc.intel.com> (raw)
In-Reply-To: <20060131171216.449b9e06.akpm@osdl.org>; from akpm@osdl.org on Tue, Jan 31, 2006 at 05:12:16PM -0800
On Tue, Jan 31, 2006 at 05:12:16PM -0800, Andrew Morton wrote:
> It's still not clear what's supposed to be happening here.
>
> In build_sched_domains() we still have code which does:
>
>
> for_each_cpu_mask(...) {
> ...
> #ifdef CONFIG_SCHED_MC
> ...
> #endif
> #ifdef CONFIG_SCHED_SMT
> ...
> #endif
> ...
> }
> ...
> #ifdef CONFIG_SCHED_SMT
> ...
> #endif
> ...
> #ifdef CONFIG_SCHED_MC
> ...
> #endif
>
> So in the first case the SCHED_SMT code will win and in the second case the
> SCHED_MC code will win. I think.
I am not sure what you mean here. At all the above pointed places, both
MC and SMT will win if both are configured.
> The code is so repetitive in there that
> `patch' may have put the hunks in the wrong place.
I will check your -mm tree.
>
> What is the design intention here? What do we _want_ to happen if both MC
> and SMT are enabled?
If both MC and SMT are enabled(and available on the system), then there will
be two domain levels one for MC and another one for SMT.
> Also the path tests CONFIG_SCHED_MT in a few places where it meant to use
> CONFIG_SCHED_SMT, which rather casts doubt upon the testing quality.
:( Got introduced in my last version of the patch. Thanks for fixing it.
suresh
next prev parent reply other threads:[~2006-02-01 1:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-26 9:51 [Patch] sched: new sched domain for representing multi-core Siddha, Suresh B
2006-01-27 0:08 ` Ingo Molnar
2006-01-27 3:51 ` Siddha, Suresh B
2006-01-28 0:00 ` Andrew Morton
2006-01-31 1:28 ` Siddha, Suresh B
2006-02-01 1:12 ` Andrew Morton
2006-02-01 1:48 ` Siddha, Suresh B [this message]
2006-02-01 2:21 ` Andrew Morton
2006-02-01 2:52 ` Siddha, Suresh B
2006-01-27 4:42 ` Andi Kleen
2006-01-28 1:45 ` Siddha, Suresh B
2006-01-29 16:56 ` Pavel Machek
2006-01-31 1:31 ` Siddha, Suresh B
2006-02-09 9:59 Samuel Thibault
2006-02-11 0:51 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060131174820.A32626@unix-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=asit.k.mallick@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=rohit.seth@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).