From: Jeremy Higdon <jeremy@sgi.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jes Sorensen <jes@sgi.com>, Alan Cox <alan@redhat.com>,
Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: [patch] Fix DMA timeouts with sgiioc4
Date: Thu, 2 Feb 2006 00:00:46 -0800 [thread overview]
Message-ID: <20060202080046.GB157213@sgi.com> (raw)
In-Reply-To: <58cb370e0602010444m46a39705q4a3043778df1628d@mail.gmail.com>
On Wed, Feb 01, 2006 at 01:44:01PM +0100, Bartlomiej Zolnierkiewicz wrote:
> On 2/1/06, Jeremy Higdon <jeremy@sgi.com> wrote:
> >
> > Here's one that removes xcount. It seems to work too.
> > Should we set hwif->rqsize to 256, or are we pretty safe in
> > expecting that the default won't rise? The driver should be
> > able to handle more, but this ioc4 hardware is weird, and it
> > probably wouldn't get tested if a general change were made :-)
>
> The current maximum request size is:
> * 256 for LBA28 and ATAPI devices
> * 1024 for LBA48 devices
>
> The maximum request size allowed by IDE driver for
> LBA48 devices will change to 65536 but block layer will
> continue to use 1024 as a default maximum request size,
> also IIRC sgiioc4 IDE is used only for ATAPI devices.
> So I think that there is no need to worry about ->rqsize.
Thanks Bartlomiej. You're correct in that it is ATAPI only (and
read-only also).
In this case, this is the final patch (last night's with a copyright
update and removing spurious whitespace at end of line).
thanks
jeremy
Signed-off-by: Jeremy Higdon <jeremy@sgi.com>
Fix sgiioc4 DMA timeout problem with 64KiB s/g elements.
--- a/linux/drivers/ide/pci/sgiioc4.c 2006-02-01 23:57:08.000000000 -0800
+++ b/linux/drivers/ide/pci/sgiioc4.c 2006-02-01 23:56:47.169588392 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2003 Silicon Graphics, Inc. All Rights Reserved.
+ * Copyright (c) 2003-2006 Silicon Graphics, Inc. All Rights Reserved.
*
* This program is free software; you can redistribute it and/or modify it
* under the terms of version 2 of the GNU General Public License
@@ -510,7 +510,7 @@
drive->name);
goto use_pio_instead;
} else {
- u32 xcount, bcount =
+ u32 bcount =
0x10000 - (cur_addr & 0xffff);
if (bcount > cur_len)
@@ -525,8 +525,7 @@
*table = 0x0;
table++;
- xcount = bcount & 0xffff;
- *table = cpu_to_be32(xcount);
+ *table = cpu_to_be32(bcount);
table++;
cur_addr += bcount;
@@ -680,7 +679,7 @@
return -EIO;
/* Create /proc/ide entries */
- create_proc_ide_interfaces();
+ create_proc_ide_interfaces();
return 0;
}
next prev parent reply other threads:[~2006-02-02 8:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-01 8:59 [patch] SGIIOC4 limit request size Jes Sorensen
2006-02-01 10:34 ` Bartlomiej Zolnierkiewicz
2006-02-01 10:41 ` Jes Sorensen
2006-02-01 10:49 ` Jeremy Higdon
2006-02-01 11:08 ` Bartlomiej Zolnierkiewicz
2006-02-01 11:17 ` Jeremy Higdon
2006-02-01 11:26 ` Bartlomiej Zolnierkiewicz
2006-02-01 11:36 ` Jeremy Higdon
2006-02-01 12:44 ` Bartlomiej Zolnierkiewicz
2006-02-02 8:00 ` Jeremy Higdon [this message]
2006-02-02 8:45 ` [patch] Fix DMA timeouts with sgiioc4 Jes Sorensen
2006-02-01 13:39 ` [patch] SGIIOC4 limit request size Alan Cox
2006-02-01 14:53 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060202080046.GB157213@sgi.com \
--to=jeremy@sgi.com \
--cc=alan@redhat.com \
--cc=bzolnier@gmail.com \
--cc=jes@sgi.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).