From: Jes Sorensen <jes@sgi.com>
To: Alan Cox <alan@redhat.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, Jeremy Higdon <jeremy@sgi.com>
Subject: [patch] SGIIOC4 limit request size
Date: 01 Feb 2006 03:59:16 -0500 [thread overview]
Message-ID: <yq0vevzpi8r.fsf@jaguar.mkp.net> (raw)
Hi,
This one takes care of a problem with the SGI IOC4 driver where it
hits DMA problems if the request grows too large.
Cheers,
Jes
Avoid requests larger than the number of SG table entries, to avoid
DMA timeouts.
Signed-off-by: Jes Sorensen <jes@sgi.com>
----
drivers/ide/pci/sgiioc4.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletion(-)
Index: linux-2.6/drivers/ide/pci/sgiioc4.c
===================================================================
--- linux-2.6.orig/drivers/ide/pci/sgiioc4.c
+++ linux-2.6/drivers/ide/pci/sgiioc4.c
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2003 Silicon Graphics, Inc. All Rights Reserved.
+ * Copyright (C) 2003, 2006 Silicon Graphics, Inc. All Rights Reserved.
*
* This program is free software; you can redistribute it and/or modify it
* under the terms of version 2 of the GNU General Public License
@@ -613,6 +613,12 @@
hwif->ide_dma_lostirq = &sgiioc4_ide_dma_lostirq;
hwif->ide_dma_timeout = &__ide_dma_timeout;
hwif->INB = &sgiioc4_INB;
+
+ /*
+ * Limit the request size to avoid DMA timeouts when
+ * requesting more entries than goes in the sg table.
+ */
+ hwif->rqsize = 127;
}
static int __devinit
next reply other threads:[~2006-02-01 8:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-01 8:59 Jes Sorensen [this message]
2006-02-01 10:34 ` [patch] SGIIOC4 limit request size Bartlomiej Zolnierkiewicz
2006-02-01 10:41 ` Jes Sorensen
2006-02-01 10:49 ` Jeremy Higdon
2006-02-01 11:08 ` Bartlomiej Zolnierkiewicz
2006-02-01 11:17 ` Jeremy Higdon
2006-02-01 11:26 ` Bartlomiej Zolnierkiewicz
2006-02-01 11:36 ` Jeremy Higdon
2006-02-01 12:44 ` Bartlomiej Zolnierkiewicz
2006-02-02 8:00 ` [patch] Fix DMA timeouts with sgiioc4 Jeremy Higdon
2006-02-02 8:45 ` Jes Sorensen
2006-02-01 13:39 ` [patch] SGIIOC4 limit request size Alan Cox
2006-02-01 14:53 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq0vevzpi8r.fsf@jaguar.mkp.net \
--to=jes@sgi.com \
--cc=alan@redhat.com \
--cc=jeremy@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).