* unexport lookup_hash
@ 2006-02-03 21:22 Dave Jones
2006-02-03 22:32 ` Adrian Bunk
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2006-02-03 21:22 UTC (permalink / raw)
To: Linux Kernel; +Cc: hch
I just stumbled across this whilst checking for planned feature removal,
and missed any discussion why this didn't happen, so I assume Christoph forgot.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.15.noarch/fs/namei.c~ 2006-02-03 16:20:49.000000000 -0500
+++ linux-2.6.15.noarch/fs/namei.c 2006-02-03 16:21:07.000000000 -0500
@@ -2668,7 +2668,6 @@ EXPORT_SYMBOL(follow_up);
EXPORT_SYMBOL(get_write_access); /* binfmt_aout */
EXPORT_SYMBOL(getname);
EXPORT_SYMBOL(lock_rename);
-EXPORT_SYMBOL(lookup_hash);
EXPORT_SYMBOL(lookup_one_len);
EXPORT_SYMBOL(page_follow_link_light);
EXPORT_SYMBOL(page_put_link);
--- linux-2.6.15.noarch/Documentation/feature-removal-schedule.txt~ 2006-02-03 16:21:11.000000000 -0500
+++ linux-2.6.15.noarch/Documentation/feature-removal-schedule.txt 2006-02-03 16:21:40.000000000 -0500
@@ -116,13 +116,6 @@ Who: Harald Welte <laforge@netfilter.org
---------------------------
-What: EXPORT_SYMBOL(lookup_hash)
-When: January 2006
-Why: Too low-level interface. Use lookup_one_len or lookup_create instead.
-Who: Christoph Hellwig <hch@lst.de>
-
----------------------------
-
What: CONFIG_FORCED_INLINING
When: June 2006
Why: Config option is there to see if gcc is good enough. (in january
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: unexport lookup_hash
2006-02-03 21:22 unexport lookup_hash Dave Jones
@ 2006-02-03 22:32 ` Adrian Bunk
2006-02-04 10:56 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2006-02-03 22:32 UTC (permalink / raw)
To: Dave Jones, Linux Kernel, hch
On Fri, Feb 03, 2006 at 04:22:59PM -0500, Dave Jones wrote:
> I just stumbled across this whilst checking for planned feature removal,
> and missed any discussion why this didn't happen, so I assume Christoph forgot.
>...
I did beat you by a few minutes. :-)
This patch wasn't possible before the latest -mm since
net/sunrpc/rpc_pipe.c still used it.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: unexport lookup_hash
2006-02-03 22:32 ` Adrian Bunk
@ 2006-02-04 10:56 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2006-02-04 10:56 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Dave Jones, Linux Kernel, hch
On Fri, Feb 03, 2006 at 11:32:24PM +0100, Adrian Bunk wrote:
> On Fri, Feb 03, 2006 at 04:22:59PM -0500, Dave Jones wrote:
> > I just stumbled across this whilst checking for planned feature removal,
> > and missed any discussion why this didn't happen, so I assume Christoph forgot.
> >...
>
> I did beat you by a few minutes. :-)
and your patch also makes it static which is possible now. Andrew also queued
up the patch already, so this one won't apply anymore.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-02-04 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-03 21:22 unexport lookup_hash Dave Jones
2006-02-03 22:32 ` Adrian Bunk
2006-02-04 10:56 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).