* [PATCH/RFC] arch/x86_common: more formal reuse of i386+x86_64 source code
@ 2006-02-09 6:53 Randy.Dunlap
2006-02-09 7:00 ` Randy.Dunlap
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Randy.Dunlap @ 2006-02-09 6:53 UTC (permalink / raw)
To: lkml; +Cc: akpm, ak
(not completed yet)
(patch applies to 2.6.16-rc2)
Patch is 331 KB and is at
http://www.xenotime.net/linux/patches/x86-common1.patch
From: Randy Dunlap <rdunlap@xenotime.net>
Move lots of i386 & x86_64 common code into arch/x86_common/
and modify Makefiles to use it from there.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
arch/i386/boot/edd.S | 176 --
arch/i386/boot/setup.S | 2
arch/i386/kernel/Makefile | 8
arch/i386/kernel/bootflag.c | 99 -
arch/i386/kernel/cpu/Makefile | 2
arch/i386/kernel/cpu/intel_cacheinfo.c | 655 ---------
arch/i386/kernel/cpuid.c | 245 ---
arch/i386/kernel/dmi_scan.c | 301 ----
arch/i386/kernel/early_printk.c | 2
arch/i386/kernel/i8237.c | 67
arch/i386/kernel/microcode.c | 516 -------
arch/i386/kernel/msr.c | 326 ----
arch/i386/kernel/quirks.c | 51
arch/i386/mm/Makefile | 2
arch/i386/mm/hugetlbpage.c | 289 ----
arch/i386/pci/Makefile | 10
arch/i386/pci/acpi.c | 68
arch/i386/pci/common.c | 261 ---
arch/i386/pci/direct.c | 289 ----
arch/i386/pci/fixup.c | 467 ------
arch/i386/pci/i386.c | 295 ----
arch/i386/pci/irq.c | 1199 -----------------
arch/i386/pci/legacy.c | 56
arch/i386/pci/pci.h | 83 -
arch/x86_64/boot/setup.S | 2
arch/x86_64/kernel/Makefile | 16
arch/x86_64/kernel/early_printk.c | 271 ---
arch/x86_64/mm/Makefile | 2
arch/x86_64/pci/Makefile | 19
arch/x86_common/boot/edd.S | 176 ++
arch/x86_common/kernel/bootflag.c | 99 +
arch/x86_common/kernel/cpu/intel_cacheinfo.c | 655 +++++++++
arch/x86_common/kernel/cpuid.c | 245 +++
arch/x86_common/kernel/dmi_scan.c | 301 ++++
arch/x86_common/kernel/early_printk.c | 271 +++
arch/x86_common/kernel/i8237.c | 67
arch/x86_common/kernel/microcode.c | 516 +++++++
arch/x86_common/kernel/msr.c | 326 ++++
arch/x86_common/kernel/quirks.c | 51
arch/x86_common/mm/hugetlbpage.c | 289 ++++
arch/x86_common/pci/acpi.c | 68
arch/x86_common/pci/common.c | 261 +++
arch/x86_common/pci/direct.c | 289 ++++
arch/x86_common/pci/fixup.c | 467 ++++++
arch/x86_common/pci/i386.c | 295 ++++
arch/x86_common/pci/irq.c | 1199 +++++++++++++++++
arch/x86_common/pci/legacy.c | 56
arch/x86_common/pci/pci.h | 83 +
48 files changed, 5759 insertions(+), 5734 deletions(-)
---
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH/RFC] arch/x86_common: more formal reuse of i386+x86_64 source code
2006-02-09 6:53 [PATCH/RFC] arch/x86_common: more formal reuse of i386+x86_64 source code Randy.Dunlap
@ 2006-02-09 7:00 ` Randy.Dunlap
2006-02-09 9:59 ` Andi Kleen
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Randy.Dunlap @ 2006-02-09 7:00 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: linux-kernel, akpm, ak
On Wed, 8 Feb 2006 22:53:36 -0800 Randy.Dunlap wrote:
> (not completed yet)
> (patch applies to 2.6.16-rc2)
oh, this really is an RFC. I built x86_64 but haven't built i386 yet.
and the early_printk whitespace patch conflicts with this one. :)
g/nite.
> Patch is 331 KB and is at
> http://www.xenotime.net/linux/patches/x86-common1.patch
>
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Move lots of i386 & x86_64 common code into arch/x86_common/
> and modify Makefiles to use it from there.
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> arch/i386/boot/edd.S | 176 --
> arch/i386/boot/setup.S | 2
> arch/i386/kernel/Makefile | 8
> arch/i386/kernel/bootflag.c | 99 -
> arch/i386/kernel/cpu/Makefile | 2
> arch/i386/kernel/cpu/intel_cacheinfo.c | 655 ---------
> arch/i386/kernel/cpuid.c | 245 ---
> arch/i386/kernel/dmi_scan.c | 301 ----
> arch/i386/kernel/early_printk.c | 2
> arch/i386/kernel/i8237.c | 67
> arch/i386/kernel/microcode.c | 516 -------
> arch/i386/kernel/msr.c | 326 ----
> arch/i386/kernel/quirks.c | 51
> arch/i386/mm/Makefile | 2
> arch/i386/mm/hugetlbpage.c | 289 ----
> arch/i386/pci/Makefile | 10
> arch/i386/pci/acpi.c | 68
> arch/i386/pci/common.c | 261 ---
> arch/i386/pci/direct.c | 289 ----
> arch/i386/pci/fixup.c | 467 ------
> arch/i386/pci/i386.c | 295 ----
> arch/i386/pci/irq.c | 1199 -----------------
> arch/i386/pci/legacy.c | 56
> arch/i386/pci/pci.h | 83 -
> arch/x86_64/boot/setup.S | 2
> arch/x86_64/kernel/Makefile | 16
> arch/x86_64/kernel/early_printk.c | 271 ---
> arch/x86_64/mm/Makefile | 2
> arch/x86_64/pci/Makefile | 19
> arch/x86_common/boot/edd.S | 176 ++
> arch/x86_common/kernel/bootflag.c | 99 +
> arch/x86_common/kernel/cpu/intel_cacheinfo.c | 655 +++++++++
> arch/x86_common/kernel/cpuid.c | 245 +++
> arch/x86_common/kernel/dmi_scan.c | 301 ++++
> arch/x86_common/kernel/early_printk.c | 271 +++
> arch/x86_common/kernel/i8237.c | 67
> arch/x86_common/kernel/microcode.c | 516 +++++++
> arch/x86_common/kernel/msr.c | 326 ++++
> arch/x86_common/kernel/quirks.c | 51
> arch/x86_common/mm/hugetlbpage.c | 289 ++++
> arch/x86_common/pci/acpi.c | 68
> arch/x86_common/pci/common.c | 261 +++
> arch/x86_common/pci/direct.c | 289 ++++
> arch/x86_common/pci/fixup.c | 467 ++++++
> arch/x86_common/pci/i386.c | 295 ++++
> arch/x86_common/pci/irq.c | 1199 +++++++++++++++++
> arch/x86_common/pci/legacy.c | 56
> arch/x86_common/pci/pci.h | 83 +
> 48 files changed, 5759 insertions(+), 5734 deletions(-)
>
> ---
> ~Randy
---
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH/RFC] arch/x86_common: more formal reuse of i386+x86_64 source code
2006-02-09 6:53 [PATCH/RFC] arch/x86_common: more formal reuse of i386+x86_64 source code Randy.Dunlap
2006-02-09 7:00 ` Randy.Dunlap
@ 2006-02-09 9:59 ` Andi Kleen
2006-02-14 19:22 ` Pavel Machek
2006-02-22 20:53 ` Tom Rini
3 siblings, 0 replies; 6+ messages in thread
From: Andi Kleen @ 2006-02-09 9:59 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: lkml, akpm
On Thursday 09 February 2006 07:53, Randy.Dunlap wrote:
> (not completed yet)
> (patch applies to 2.6.16-rc2)
>
> Patch is 331 KB and is at
> http://www.xenotime.net/linux/patches/x86-common1.patch
>
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Move lots of i386 & x86_64 common code into arch/x86_common/
> and modify Makefiles to use it from there.
No. That patch doesn't buy us anything and makes it hell
to forward/backward port patches.
-Andi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH/RFC] arch/x86_common: more formal reuse of i386+x86_64 source code
2006-02-09 6:53 [PATCH/RFC] arch/x86_common: more formal reuse of i386+x86_64 source code Randy.Dunlap
2006-02-09 7:00 ` Randy.Dunlap
2006-02-09 9:59 ` Andi Kleen
@ 2006-02-14 19:22 ` Pavel Machek
2006-02-22 20:53 ` Tom Rini
3 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2006-02-14 19:22 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: lkml, akpm, ak
Hi!
> (not completed yet)
> (patch applies to 2.6.16-rc2)
>
> Patch is 331 KB and is at
> http://www.xenotime.net/linux/patches/x86-common1.patch
>
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Move lots of i386 & x86_64 common code into arch/x86_common/
> and modify Makefiles to use it from there.
I like it... the way some files have main code in i386 and some is x86-64 is
rather ugly.
Pavel
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH/RFC] arch/x86_common: more formal reuse of i386+x86_64 source code
2006-02-09 6:53 [PATCH/RFC] arch/x86_common: more formal reuse of i386+x86_64 source code Randy.Dunlap
` (2 preceding siblings ...)
2006-02-14 19:22 ` Pavel Machek
@ 2006-02-22 20:53 ` Tom Rini
2006-02-22 20:55 ` Randy.Dunlap
3 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2006-02-22 20:53 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: lkml, akpm, ak
On Wed, Feb 08, 2006 at 10:53:36PM -0800, Randy.Dunlap wrote:
> (not completed yet)
> (patch applies to 2.6.16-rc2)
>
> Patch is 331 KB and is at
> http://www.xenotime.net/linux/patches/x86-common1.patch
>
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Move lots of i386 & x86_64 common code into arch/x86_common/
> and modify Makefiles to use it from there.
I know I'm quite late here, but perhaps it should be arch/common? I
remember thinking ages ago the i8259 stuff could be shared between ppc32
and i386 (it was ages ago). And there's possibly other stuff like that.
--
Tom Rini
http://gate.crashing.org/~trini/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH/RFC] arch/x86_common: more formal reuse of i386+x86_64 source code
2006-02-22 20:53 ` Tom Rini
@ 2006-02-22 20:55 ` Randy.Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy.Dunlap @ 2006-02-22 20:55 UTC (permalink / raw)
To: Tom Rini; +Cc: Randy.Dunlap, lkml, akpm, ak
On Wed, 22 Feb 2006, Tom Rini wrote:
> On Wed, Feb 08, 2006 at 10:53:36PM -0800, Randy.Dunlap wrote:
>
> > (not completed yet)
> > (patch applies to 2.6.16-rc2)
> >
> > Patch is 331 KB and is at
> > http://www.xenotime.net/linux/patches/x86-common1.patch
> >
> > From: Randy Dunlap <rdunlap@xenotime.net>
> >
> > Move lots of i386 & x86_64 common code into arch/x86_common/
> > and modify Makefiles to use it from there.
>
> I know I'm quite late here, but perhaps it should be arch/common? I
> remember thinking ages ago the i8259 stuff could be shared between ppc32
> and i386 (it was ages ago). And there's possibly other stuff like that.
Hi Tom,
Maybe, but ...
a few people like the "common" idea, but Andi has vetoed it,
so I've dropped it.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-02-22 20:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-09 6:53 [PATCH/RFC] arch/x86_common: more formal reuse of i386+x86_64 source code Randy.Dunlap
2006-02-09 7:00 ` Randy.Dunlap
2006-02-09 9:59 ` Andi Kleen
2006-02-14 19:22 ` Pavel Machek
2006-02-22 20:53 ` Tom Rini
2006-02-22 20:55 ` Randy.Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).