From: Pavel Machek <pavel@suse.cz>
To: Kristen Accardi <kristen.c.accardi@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
pcihpd-discuss@lists.sourceforge.net, greg@kroah.com,
len.brown@intel.com, muneda.takahiro@jp.fujitsu.com
Subject: Re: [patch 3/3] acpi: remove dock event handling from ibm_acpi
Date: Wed, 22 Feb 2006 23:57:41 +0100 [thread overview]
Message-ID: <20060222225740.GJ13621@elf.ucw.cz> (raw)
In-Reply-To: <1140636091.32574.21.camel@whizzy>
On St 22-02-06 11:21:31, Kristen Accardi wrote:
> Remove dock station support from ibm_acpi by default. This support has been
> put into acpiphp instead. Allow ibm_acpi to continue to provide docking
> station support via config option for laptops/docking stations that are
> not supported by acpiphp.
>
> Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
>
> ---
> drivers/acpi/Kconfig | 12 ++++++++++++
> drivers/acpi/ibm_acpi.c | 13 ++++++++++---
> 2 files changed, 22 insertions(+), 3 deletions(-)
>
> --- linux-dock-mm.orig/drivers/acpi/Kconfig
> +++ linux-dock-mm/drivers/acpi/Kconfig
> @@ -205,6 +205,18 @@ config ACPI_IBM
>
> If you have an IBM ThinkPad laptop, say Y or M here.
>
> +config ACPI_IBM_DOCK
> + bool "Legacy Docking Station Support"
> + depends on ACPI_IBM
> + default n
> + ---help---
> + Allows the ibm_acpi driver to handle docking station events.
> + This support is limited and should only be enabled if the generic
> + docking station support driver does not support your laptop/dock
> + station.
This support is obsoleted by
CONFIG_PCI_HOTPLUG_ACPIHP_or_how_it_is_called. It will allow
ejecting/locking machine in dock, but will not properly connect PCI
buses.
Pavel
--
Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted...
next prev parent reply other threads:[~2006-02-22 22:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060222190839.268403000@intel.com>
2006-02-22 19:21 ` [patch 1/3] acpi: export acpi_bus_trim Kristen Accardi
2006-02-22 19:21 ` [patch 2/3] acpiphp: add dock event handling Kristen Accardi
2006-02-22 19:21 ` [patch 3/3] acpi: remove dock event handling from ibm_acpi Kristen Accardi
2006-02-22 22:57 ` Pavel Machek [this message]
[not found] <20060223195022.747891000@intel.com>
2006-02-23 19:56 ` Kristen Accardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060222225740.GJ13621@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=greg@kroah.com \
--cc=kristen.c.accardi@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muneda.takahiro@jp.fujitsu.com \
--cc=pcihpd-discuss@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).