linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ravikiran G Thirumalai <kiran@scalex86.org>
To: Andrew Morton <akpm@osdl.org>
Cc: nickpiggin@yahoo.com.au, clameter@engr.sgi.com,
	linux-kernel@vger.kernel.org, shai@scalex86.org,
	Nippun Goel <nippun.goel@calsoftinc.com>
Subject: Re: [patch] Cache align futex hash buckets
Date: Wed, 22 Feb 2006 18:08:18 -0800	[thread overview]
Message-ID: <20060223020818.GD3663@localhost.localdomain> (raw)
In-Reply-To: <20060223015144.GC3663@localhost.localdomain>

On Wed, Feb 22, 2006 at 05:51:44PM -0800, Ravikiran G Thirumalai wrote:
> On Wed, Feb 22, 2006 at 12:50:49PM -0800, Andrew Morton wrote:
> > Ravikiran G Thirumalai <kiran@scalex86.org> wrote:
> > >
> > > We also collected hash collision statistics for 1024 slots.  We found that
> > >  50% of the slots did not take any hit!!  So maybe we should revisit the
> > >  hashing function before settling on the optimal number of hash slots. 
> > 
> > You could try switching from jhash2() to hash_long().
> 
> OK, I will try that.
> 
> > 
> > Was there any particular pattern to the unused slots?  Not something silly
> > like every second one?
> 
> The distribution seems OK with 256 buckets, but with 1024 buckets, it goes
> bad.  We see high hits every 4-6 buckets.  Attaching the distribution

This pattern might not be bad as it avoids bouncing of spinlocks on the adjacent
hash buckets...but then there are high hits on adjacent buckets too.

(instrumentation done by Nippun)

Thanks,
Kiran

  parent reply	other threads:[~2006-02-23  2:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-20 23:32 [patch] Cache align futex hash buckets Ravikiran G Thirumalai
2006-02-20 23:33 ` Andrew Morton
2006-02-20 23:34   ` Andrew Morton
2006-02-21  0:09     ` Ravikiran G Thirumalai
2006-02-21  0:23       ` Andrew Morton
2006-02-21  1:04         ` Ravikiran G Thirumalai
2006-02-21  1:09           ` Andrew Morton
2006-02-21  1:39             ` Ravikiran G Thirumalai
2006-02-21 14:44             ` Andi Kleen
2006-02-21  3:30 ` Nick Piggin
2006-02-21 18:33   ` Christoph Lameter
2006-02-21 23:14     ` Christoph Lameter
2006-02-22  0:40     ` Nick Piggin
2006-02-22  2:08       ` Andrew Morton
2006-02-22  2:35         ` Ravikiran G Thirumalai
2006-02-22  2:37         ` Nick Piggin
2006-02-22 20:17           ` Ravikiran G Thirumalai
2006-02-22 20:50             ` Andrew Morton
     [not found]               ` <20060223015144.GC3663@localhost.localdomain>
2006-02-23  2:08                 ` Ravikiran G Thirumalai [this message]
2006-02-21 20:20   ` Ravikiran G Thirumalai
2006-02-22  0:45     ` Nick Piggin
2006-02-22  2:09       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060223020818.GD3663@localhost.localdomain \
    --to=kiran@scalex86.org \
    --cc=akpm@osdl.org \
    --cc=clameter@engr.sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=nippun.goel@calsoftinc.com \
    --cc=shai@scalex86.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).