From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: clameter@engr.sgi.com, kiran@scalex86.org,
linux-kernel@vger.kernel.org, shai@scalex86.org
Subject: Re: [patch] Cache align futex hash buckets
Date: Wed, 22 Feb 2006 13:37:10 +1100 [thread overview]
Message-ID: <43FBCE56.9020001@yahoo.com.au> (raw)
In-Reply-To: <20060221180845.79a44449.akpm@osdl.org>
Andrew Morton wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>>Instead of 1MB hash with 256 entries in it covering 256 cachelines, you
>>have a 1MB hash with 65536(ish) entries covering 256 cachelines.
>>
>
>
> Good (if accidental point). Kiran, if you're going to gobble a megabyte,
> you might as well use all of it and make the hashtable larger, rather than
> just leaving 99% of that memory unused...
>
We chould probably also convert the list_head over to an hlist_head,
for a modest saving in size (although that's more important from a
cache footprint POV rather than improving cacheline bouncing).
Although speaking of cacheline footprint: making the hash table so
large will increase the "real" CPU cacheline footprint on your VSMP
systems, so perhaps it is not always such an easy decision.
Definitely for "normal" systems, we do not want to pad out to a
single entry per cacheline, so the current patch can not go upstream
as is.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-02-22 4:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-20 23:32 [patch] Cache align futex hash buckets Ravikiran G Thirumalai
2006-02-20 23:33 ` Andrew Morton
2006-02-20 23:34 ` Andrew Morton
2006-02-21 0:09 ` Ravikiran G Thirumalai
2006-02-21 0:23 ` Andrew Morton
2006-02-21 1:04 ` Ravikiran G Thirumalai
2006-02-21 1:09 ` Andrew Morton
2006-02-21 1:39 ` Ravikiran G Thirumalai
2006-02-21 14:44 ` Andi Kleen
2006-02-21 3:30 ` Nick Piggin
2006-02-21 18:33 ` Christoph Lameter
2006-02-21 23:14 ` Christoph Lameter
2006-02-22 0:40 ` Nick Piggin
2006-02-22 2:08 ` Andrew Morton
2006-02-22 2:35 ` Ravikiran G Thirumalai
2006-02-22 2:37 ` Nick Piggin [this message]
2006-02-22 20:17 ` Ravikiran G Thirumalai
2006-02-22 20:50 ` Andrew Morton
[not found] ` <20060223015144.GC3663@localhost.localdomain>
2006-02-23 2:08 ` Ravikiran G Thirumalai
2006-02-21 20:20 ` Ravikiran G Thirumalai
2006-02-22 0:45 ` Nick Piggin
2006-02-22 2:09 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43FBCE56.9020001@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shai@scalex86.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).