From: Suparna Bhattacharya <suparna@in.ibm.com>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: christoph <hch@lst.de>,
mcao@us.ibm.com, akpm@osdl.org,
lkml <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 2/3] map multiple blocks for mpage_readpages()
Date: Thu, 23 Feb 2006 08:59:03 +0530 [thread overview]
Message-ID: <20060223032903.GA31252@in.ibm.com> (raw)
In-Reply-To: <1140470635.22756.15.camel@dyn9047017100.beaverton.ibm.com>
On Mon, Feb 20, 2006 at 01:23:55PM -0800, Badari Pulavarty wrote:
> [PATCH 2/3] map multiple blocks for mpage_readpages()
>
> This patch changes mpage_readpages() and get_block() to
> get the disk mapping information for multiple blocks at the
> same time.
>
> b_size represents the amount of disk mapping that needs to
> mapped. On the successful get_block() b_size indicates the
> amount of disk mapping thats actually mapped. Only the
> filesystems who care to use this information and provide multiple
> disk blocks at a time can choose to do so.
>
> No changes are needed for the filesystems who wants to ignore this.
That's a nice way to handle this !
Just one minor suggestion on the patches - instead of adding all those
arguments to do_mpage_readpage, have you considered using
an mio structure as we did in the mpage_writepages multiple blocks case ?
Regards
Suparna
>
> Thanks,
> Badari
>
>
--
Suparna Bhattacharya (suparna@in.ibm.com)
Linux Technology Center
IBM Software Lab, India
next prev parent reply other threads:[~2006-02-23 3:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-20 21:21 [PATCH 0/3] map multiple blocks in get_block() and mpage_readpages() Badari Pulavarty
2006-02-20 21:23 ` [PATCH 1/3] pass b_size to ->get_block() Badari Pulavarty
2006-02-20 21:23 ` [PATCH 2/3] map multiple blocks for mpage_readpages() Badari Pulavarty
2006-02-23 3:29 ` Suparna Bhattacharya [this message]
2006-02-23 22:18 ` Badari Pulavarty
2006-02-20 21:24 ` [PATCH 3/3] remove ->get_blocks() support Badari Pulavarty
2006-02-20 21:59 ` [PATCH 0/3] map multiple blocks in get_block() and mpage_readpages() Nathan Scott
2006-02-20 23:06 ` Badari Pulavarty
2006-02-20 23:16 ` Nathan Scott
2006-02-21 2:41 ` Jeremy Higdon
2006-02-21 16:03 ` Badari Pulavarty
2006-02-21 21:39 ` Nathan Scott
2006-02-22 15:12 ` christoph
2006-02-22 16:58 ` Badari Pulavarty
2006-02-22 16:59 ` christoph
2006-02-23 1:40 ` Nathan Scott
2006-02-23 1:59 ` Andrew Morton
2006-02-23 16:28 ` [PATCH] change b_size to size_t Badari Pulavarty
2006-02-23 16:32 ` Benjamin LaHaise
2006-02-23 17:20 ` Badari Pulavarty
2006-02-23 17:28 ` Badari Pulavarty
2006-02-23 17:29 ` Benjamin LaHaise
2006-02-23 18:46 ` Badari Pulavarty
2006-02-23 17:40 ` Badari Pulavarty
2006-02-23 16:40 ` Dave Kleikamp
2006-02-22 17:23 ` [PATCH 0/3] map multiple blocks in get_block() and mpage_readpages() Peter Staubach
2006-02-22 18:37 ` Dave Kleikamp
2006-02-22 19:00 ` Badari Pulavarty
2006-02-24 17:19 ` Badari Pulavarty
2006-03-06 10:03 ` Suparna Bhattacharya
2006-03-06 22:39 ` Nathan Scott
2006-03-07 9:00 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060223032903.GA31252@in.ibm.com \
--to=suparna@in.ibm.com \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcao@us.ibm.com \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).