From: Benjamin LaHaise <bcrl@kvack.org>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>, Nathan Scott <nathans@sgi.com>,
christoph <hch@lst.de>,
mcao@us.ibm.com, lkml <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] change b_size to size_t
Date: Thu, 23 Feb 2006 12:29:25 -0500 [thread overview]
Message-ID: <20060223172925.GD27682@kvack.org> (raw)
In-Reply-To: <1140715738.22756.125.camel@dyn9047017100.beaverton.ibm.com>
On Thu, Feb 23, 2006 at 09:28:58AM -0800, Badari Pulavarty wrote:
> How about doing this ? Change b_state to u32 and change b_size
> to "size_t". This way, we don't increase the overall size of
> the structure on 64-bit machines. Isn't it ?
I was thinking of that too, but that doesn't work with the bit operations
on big endian machines (which require unsigned long). Oh well, I guess
that even with adding an extra 8 bytes on x86-64 we're still at the 96
bytes, or 92 bytes if the atomic_t is put at the end of the struct.
-ben
--
"Ladies and gentlemen, I'm sorry to interrupt, but the police are here
and they've asked us to stop the party." Don't Email: <dont@kvack.org>.
next prev parent reply other threads:[~2006-02-23 17:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-20 21:21 [PATCH 0/3] map multiple blocks in get_block() and mpage_readpages() Badari Pulavarty
2006-02-20 21:23 ` [PATCH 1/3] pass b_size to ->get_block() Badari Pulavarty
2006-02-20 21:23 ` [PATCH 2/3] map multiple blocks for mpage_readpages() Badari Pulavarty
2006-02-23 3:29 ` Suparna Bhattacharya
2006-02-23 22:18 ` Badari Pulavarty
2006-02-20 21:24 ` [PATCH 3/3] remove ->get_blocks() support Badari Pulavarty
2006-02-20 21:59 ` [PATCH 0/3] map multiple blocks in get_block() and mpage_readpages() Nathan Scott
2006-02-20 23:06 ` Badari Pulavarty
2006-02-20 23:16 ` Nathan Scott
2006-02-21 2:41 ` Jeremy Higdon
2006-02-21 16:03 ` Badari Pulavarty
2006-02-21 21:39 ` Nathan Scott
2006-02-22 15:12 ` christoph
2006-02-22 16:58 ` Badari Pulavarty
2006-02-22 16:59 ` christoph
2006-02-23 1:40 ` Nathan Scott
2006-02-23 1:59 ` Andrew Morton
2006-02-23 16:28 ` [PATCH] change b_size to size_t Badari Pulavarty
2006-02-23 16:32 ` Benjamin LaHaise
2006-02-23 17:20 ` Badari Pulavarty
2006-02-23 17:28 ` Badari Pulavarty
2006-02-23 17:29 ` Benjamin LaHaise [this message]
2006-02-23 18:46 ` Badari Pulavarty
2006-02-23 17:40 ` Badari Pulavarty
2006-02-23 16:40 ` Dave Kleikamp
2006-02-22 17:23 ` [PATCH 0/3] map multiple blocks in get_block() and mpage_readpages() Peter Staubach
2006-02-22 18:37 ` Dave Kleikamp
2006-02-22 19:00 ` Badari Pulavarty
2006-02-24 17:19 ` Badari Pulavarty
2006-03-06 10:03 ` Suparna Bhattacharya
2006-03-06 22:39 ` Nathan Scott
2006-03-07 9:00 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060223172925.GD27682@kvack.org \
--to=bcrl@kvack.org \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcao@us.ibm.com \
--cc=nathans@sgi.com \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).