linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] version.h should depend on .kernelrelease
@ 2006-02-22 12:29 Jan Beulich
  2006-02-23  4:04 ` Sam Ravnborg
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2006-02-22 12:29 UTC (permalink / raw)
  To: sam; +Cc: linux-kernel

Rebuilding a previously built tree while using make's -j options from time to
time results in the version.h check running at the same time as the updating
of .kernelrelease, resulting in UTS_RELEASE remaining an empty string (and as
a side effect causing the entire kernel to be rebuilt).

Signed-Off-By: Jan Beulich <jbeulich@novell.com>

diff -Npru /home/jbeulich/tmp/linux-2.6.16-rc4/Makefile 2.6.16-rc4-version.h-depends-on-kernelrelease/Makefile
--- /home/jbeulich/tmp/linux-2.6.16-rc4/Makefile	2006-02-20 09:12:27.000000000 +0100
+++ 2.6.16-rc4-version.h-depends-on-kernelrelease/Makefile	2006-02-20 09:59:29.000000000 +0100
@@ -905,7 +905,7 @@ define filechk_version.h
 	)
 endef
 
-include/linux/version.h: $(srctree)/Makefile .config FORCE
+include/linux/version.h: $(srctree)/Makefile .config .kernelrelease FORCE
 	$(call filechk,version.h)
 
 # ---------------------------------------------------------------------------


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] version.h should depend on .kernelrelease
  2006-02-22 12:29 [PATCH] version.h should depend on .kernelrelease Jan Beulich
@ 2006-02-23  4:04 ` Sam Ravnborg
  0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2006-02-23  4:04 UTC (permalink / raw)
  To: Jan Beulich; +Cc: linux-kernel

On Wed, Feb 22, 2006 at 01:29:04PM +0100, Jan Beulich wrote:
> Rebuilding a previously built tree while using make's -j options from time to
> time results in the version.h check running at the same time as the updating
> of .kernelrelease, resulting in UTS_RELEASE remaining an empty string (and as
> a side effect causing the entire kernel to be rebuilt).

Thanks Jan, applied to my kbuild.git tree.

	Sam

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-02-23  4:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-22 12:29 [PATCH] version.h should depend on .kernelrelease Jan Beulich
2006-02-23  4:04 ` Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).