From: Benjamin LaHaise <bcrl@kvack.org>
To: Arjan van de Ven <arjan@intel.linux.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, ak@suse.de
Subject: Re: [Patch 2/3] fast VMA recycling
Date: Thu, 23 Feb 2006 11:37:24 -0500 [thread overview]
Message-ID: <20060223163724.GB27682@kvack.org> (raw)
In-Reply-To: <1140687029.4672.8.camel@laptopd505.fenrus.org>
On Thu, Feb 23, 2006 at 10:30:29AM +0100, Arjan van de Ven wrote:
> One could argue that this should be a generic slab feature (the preloading) but
> that only gives some of the gains and not all, and vma's are small creatures,
> with a high "recycling" rate in typical cases.
I think this is wrong, and far too narrow in useful scope to be merged.
It's unnecessary bloat of task_struct and if this is really a problem, then
there is a [performance] bug in the slab allocator. Please at least provide
the slab statistics for what is going on, as the workload might well be
thrashing the creation and destruction of slabs, which would be a much better
thing to fix.
-ben
prev parent reply other threads:[~2006-02-23 16:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-23 9:17 [Patch 0/3] threaded mmap tweaks Arjan van de Ven
2006-02-23 9:29 ` [Patch 3/3] prepopulate/cache cleared pages Arjan van de Ven
2006-02-23 9:41 ` Andi Kleen
2006-02-23 12:41 ` Ingo Molnar
2006-02-23 13:06 ` Andi Kleen
2006-02-23 13:15 ` Nick Piggin
2006-02-23 13:29 ` Ingo Molnar
2006-02-24 6:36 ` Nick Piggin
2006-02-24 6:49 ` Ingo Molnar
2006-02-24 7:01 ` Nick Piggin
2006-02-24 12:33 ` Andi Kleen
2006-02-24 12:55 ` Hugh Dickins
2006-02-24 9:15 ` Arjan van de Ven
2006-02-24 9:26 ` Nick Piggin
2006-02-24 12:27 ` Andi Kleen
2006-02-24 15:31 ` Andrea Arcangeli
2006-02-25 16:48 ` Nick Piggin
2006-02-25 17:22 ` Nick Piggin
2006-02-28 22:30 ` Pavel Machek
2006-02-23 18:25 ` Paul Jackson
2006-02-23 9:30 ` [Patch 2/3] fast VMA recycling Arjan van de Ven
2006-02-23 9:42 ` Andi Kleen
2006-02-23 9:48 ` Arjan van de Ven
2006-02-23 10:05 ` Andi Kleen
2006-02-23 10:15 ` Arjan van de Ven
2006-02-23 11:00 ` Andi Kleen
2006-02-23 11:22 ` Arjan van de Ven
2006-02-23 11:57 ` Andi Kleen
2006-02-24 18:52 ` Christoph Hellwig
2006-02-24 19:05 ` Andi Kleen
2006-02-24 19:09 ` Christoph Hellwig
2006-02-23 16:37 ` Benjamin LaHaise [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060223163724.GB27682@kvack.org \
--to=bcrl@kvack.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=arjan@intel.linux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).