linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andi Kleen <ak@suse.de>
Cc: Dave Jones <davej@redhat.com>,
	Dmitry Torokhov <dtor_core@ameritech.net>,
	davej@codemonkey.org.uk,
	Zwane Mwaikambo <zwane@commfireservices.com>,
	Samuel Masham <samuel.masham@gmail.com>,
	Jan Engelhardt <jengelh@linux01.gwdg.de>,
	linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	cpufreq@lists.linux.org.uk
Subject: Re: Status of X86_P4_CLOCKMOD?
Date: Fri, 24 Feb 2006 03:39:37 +0100	[thread overview]
Message-ID: <20060224023937.GC3674@stusta.de> (raw)
In-Reply-To: <200602240055.30603.ak@suse.de>

On Fri, Feb 24, 2006 at 12:55:30AM +0100, Andi Kleen wrote:
> On Friday 24 February 2006 00:33, Adrian Bunk wrote:
> 
> > EMBEDDED is the wrong option, since the semantics of embedded is "show
> > more options to allow additional space savings". It is not and should
> > not be abused as an option to hide random options from users.
> 
> I disagree. And I originally added most EMBEDDED users to the kernel.
> The purpose I added it for was to hide options that only useful
> for a very limited userbase but cause big or subtle trouble when set
> wrong. P4_CLOCKMOD clearly qualifies.

This matches neither the description of the EMBEDDED option nor all 
other usages in the kernel I have seen until now.

We need an additional option for such cases, but overloading EMBEDDED 
with more than one meaning is definitely not a good idea.

> -Andi

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2006-02-24  2:39 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-14 15:22 [2.6 patch] make INPUT a bool Adrian Bunk
2006-02-14 18:14 ` Jan Engelhardt
2006-02-14 18:22   ` Adrian Bunk
2006-02-14 23:47     ` Adrian Bunk
2006-02-17 15:56     ` Jan Engelhardt
2006-02-17 16:38       ` Adrian Bunk
2006-02-20  3:33         ` Samuel Masham
2006-02-20 13:28           ` Adrian Bunk
2006-02-22  1:34             ` Herbert Poetzl
2006-02-22  2:31               ` Adrian Bunk
2006-02-22  2:44                 ` Herbert Poetzl
2006-02-22  3:10                   ` Adrian Bunk
2006-02-22  3:20                     ` Dmitry Torokhov
2006-02-23 19:59                       ` Status of X86_P4_CLOCKMOD? Adrian Bunk
2006-02-23 20:41                         ` Dave Jones
2006-02-23 23:15                           ` Andi Kleen
2006-02-23 23:33                             ` Adrian Bunk
2006-02-23 23:55                               ` Andi Kleen
2006-02-24  2:39                                 ` Adrian Bunk [this message]
2006-02-24  2:42                                   ` Andi Kleen
2006-02-24 17:33                                     ` Adrian Bunk
2006-02-25  1:57                           ` Johannes Stezenbach
2006-02-25  4:24                             ` Dave Jones
2006-02-25 12:53                               ` Johannes Stezenbach
2006-02-27 21:17                                 ` Wes Felter
2006-02-25  4:27                             ` Andi Kleen
2006-02-25 12:53                               ` Adrian Bunk
2006-02-25 13:28                                 ` Dominik Brodowski
2006-02-26 11:12                                   ` Pavel Machek
2006-02-26 20:39                                   ` Johannes Stezenbach
2006-02-26 20:55                                     ` Dominik Brodowski
2006-02-26 23:37                                       ` Johannes Stezenbach
2006-02-25 13:36                                 ` Andi Kleen
2006-02-25 13:05                               ` Johannes Stezenbach
2006-02-28 19:46                           ` Matt Mackall
2006-02-28 20:09                             ` Dave Jones
2006-02-28 20:19                               ` Dmitry Torokhov
2006-02-28 20:47                               ` Matt Mackall
2006-02-28 20:57                                 ` Dominik Brodowski
2006-02-28 21:26                                   ` Matt Mackall
2006-02-28 21:34                                     ` Dominik Brodowski
2006-02-28 21:39                                       ` Dmitry Torokhov
2006-02-28 22:22                                         ` Andi Kleen
2006-02-22 12:01                     ` [2.6 patch] make INPUT a bool Herbert Poetzl
2006-02-22 12:15                       ` Adrian Bunk
2006-02-22 18:09                         ` Herbert Poetzl
2006-02-25 11:58                 ` Geert Uytterhoeven
2006-02-25 12:46                   ` Adrian Bunk
2006-02-25 14:22                     ` Jan Engelhardt
2006-02-25 14:50                       ` Adrian Bunk
2006-02-25 15:29                         ` Jan Engelhardt
2006-02-25 15:40                           ` Adrian Bunk
2006-02-25 22:01                             ` Jan Engelhardt
2006-02-25 22:07                               ` Adrian Bunk
2006-02-25 22:23                                 ` Dmitry Torokhov
2006-02-26 18:13                                   ` Adrian Bunk
2006-02-27  7:11                                   ` Vojtech Pavlik
2006-02-27 12:59                                 ` Vojtech Pavlik
2006-02-25 14:57                       ` Jesper Juhl
2006-02-15  6:20 ` Dmitry Torokhov
2006-02-16 23:22   ` Adrian Bunk
2006-02-17  1:47     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060224023937.GC3674@stusta.de \
    --to=bunk@stusta.de \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=cpufreq@lists.linux.org.uk \
    --cc=davej@codemonkey.org.uk \
    --cc=davej@redhat.com \
    --cc=dtor_core@ameritech.net \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samuel.masham@gmail.com \
    --cc=zwane@commfireservices.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).