* Re: [patch] x86_64: don't use early_printk() during memory init
@ 2006-02-25 6:22 Chuck Ebbert
0 siblings, 0 replies; 3+ messages in thread
From: Chuck Ebbert @ 2006-02-25 6:22 UTC (permalink / raw)
To: Andi Kleen; +Cc: linux-kernel, Andrew Morton
In-Reply-To: <200602250526.06389.ak@suse.de>
On Sat, 25 Feb 2006 at 05:26:05 +0100, Andi Kleen wrote:
> > printk is working by the time this memory init message prints.
> > As it stands, output jumps to the top of the screen and prints
> > this message, then back to normal boot messages, overwriting
> > a line at the top.
>
> Using of early_printk here was intentional because it needs
> much less infrastructure than printk and is pretty good proof
> that the kernel at least started.
Well it made me think something had gone horribly wrong and was
scribbling over video memory. Especially since it left debris
at the end of the line... and you don't want to fix that either.
--
Chuck
"Equations are the Devil's sentences." --Stephen Colbert
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] x86_64: don't use early_printk() during memory init
2006-02-25 1:45 Chuck Ebbert
@ 2006-02-25 4:26 ` Andi Kleen
0 siblings, 0 replies; 3+ messages in thread
From: Andi Kleen @ 2006-02-25 4:26 UTC (permalink / raw)
To: Chuck Ebbert; +Cc: Andrew Morton, linux-kernel
On Saturday 25 February 2006 02:45, Chuck Ebbert wrote:
> printk is working by the time this memory init message prints.
> As it stands, output jumps to the top of the screen and prints
> this message, then back to normal boot messages, overwriting
> a line at the top.
Using of early_printk here was intentional because it needs
much less infrastructure than printk and is pretty good proof
that the kernel at least started.
So please don't apply the patch.
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
* [patch] x86_64: don't use early_printk() during memory init
@ 2006-02-25 1:45 Chuck Ebbert
2006-02-25 4:26 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: Chuck Ebbert @ 2006-02-25 1:45 UTC (permalink / raw)
To: Andi Kleen; +Cc: Andrew Morton, linux-kernel
printk is working by the time this memory init message prints.
As it stands, output jumps to the top of the screen and prints
this message, then back to normal boot messages, overwriting
a line at the top.
Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
---
This bug was introduced 5 weeks ago and should be fixed before 2.6.16.
--- 2.6.16-rc4-64.orig/arch/x86_64/mm/init.c
+++ 2.6.16-rc4-64/arch/x86_64/mm/init.c
@@ -312,7 +312,7 @@ static void __init find_early_table_spac
table_start >>= PAGE_SHIFT;
table_end = table_start;
- early_printk("kernel direct mapping tables up to %lx @ %lx-%lx\n",
+ printk("kernel direct mapping tables up to %lx @ %lx-%lx\n",
end, table_start << PAGE_SHIFT, table_end << PAGE_SHIFT);
}
--
Chuck
"Equations are the Devil's sentences." --Stephen Colbert
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-02-25 6:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-25 6:22 [patch] x86_64: don't use early_printk() during memory init Chuck Ebbert
-- strict thread matches above, loose matches on Subject: below --
2006-02-25 1:45 Chuck Ebbert
2006-02-25 4:26 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).