* [RFC: -mm patch] drivers/media/video/msp3400-kthreads.c: make 3 functions static
@ 2006-03-08 9:08 Adrian Bunk
2006-03-08 18:46 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2006-03-08 9:08 UTC (permalink / raw)
To: Andrew Morton, mchehab; +Cc: linux-kernel, v4l-dvb-maintainer
This patch makes three needlessly global functions static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 4 Mar 2006
drivers/media/video/msp3400-kthreads.c | 6 +++---
drivers/media/video/msp3400.h | 1 -
2 files changed, 3 insertions(+), 4 deletions(-)
--- linux-2.6.16-rc5-mm2-full/drivers/media/video/msp3400.h.old 2006-03-03 17:40:22.000000000 +0100
+++ linux-2.6.16-rc5-mm2-full/drivers/media/video/msp3400.h 2006-03-03 17:40:41.000000000 +0100
@@ -104,7 +104,6 @@
/* msp3400-kthreads.c */
const char *msp_standard_std_name(int std);
-void msp_set_source(struct i2c_client *client, u16 src);
void msp_set_audmode(struct i2c_client *client);
void msp_detect_stereo(struct i2c_client *client);
int msp3400c_thread(void *data);
--- linux-2.6.16-rc5-mm2-full/drivers/media/video/msp3400-kthreads.c.old 2006-03-03 17:39:29.000000000 +0100
+++ linux-2.6.16-rc5-mm2-full/drivers/media/video/msp3400-kthreads.c 2006-03-03 17:40:10.000000000 +0100
@@ -154,7 +154,7 @@
return "unknown";
}
-void msp_set_source(struct i2c_client *client, u16 src)
+static void msp_set_source(struct i2c_client *client, u16 src)
{
struct msp_state *state = i2c_get_clientdata(client);
@@ -217,7 +217,7 @@
/* Set audio mode. Note that the pre-'G' models do not support BTSC+SAP,
nor do they support stereo BTSC. */
-void msp3400c_set_audmode(struct i2c_client *client)
+static void msp3400c_set_audmode(struct i2c_client *client)
{
static char *strmode[] = { "mono", "stereo", "lang2", "lang1" };
struct msp_state *state = i2c_get_clientdata(client);
@@ -944,7 +944,7 @@
status, is_stereo, is_bilingual, state->rxsubchans);
}
-void msp34xxg_set_audmode(struct i2c_client *client)
+static void msp34xxg_set_audmode(struct i2c_client *client)
{
struct msp_state *state = i2c_get_clientdata(client);
int source;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC: -mm patch] drivers/media/video/msp3400-kthreads.c: make 3 functions static
2006-03-08 9:08 [RFC: -mm patch] drivers/media/video/msp3400-kthreads.c: make 3 functions static Adrian Bunk
@ 2006-03-08 18:46 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2006-03-08 18:46 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel, v4l-dvb-maintainer
Adrian,
Em Qua, 2006-03-08 às 10:08 +0100, Adrian Bunk escreveu:
> This patch makes three needlessly global functions static.
Thanks. Applied on both Mercurial and git trees.
Cheers,
Mauro.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC: -mm patch] drivers/media/video/msp3400-kthreads.c: make 3 functions static
2006-03-03 12:56 2.6.16-rc5-mm2 Andrew Morton
@ 2006-03-04 12:14 ` Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2006-03-04 12:14 UTC (permalink / raw)
To: Andrew Morton, mchehab; +Cc: linux-kernel, v4l-dvb-maintainer
On Fri, Mar 03, 2006 at 04:56:51AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc5-mm1:
>...
> git-dvb.patch
>...
> git trees
>...
This patch makes three needlessly global functions static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/media/video/msp3400-kthreads.c | 6 +++---
drivers/media/video/msp3400.h | 1 -
2 files changed, 3 insertions(+), 4 deletions(-)
--- linux-2.6.16-rc5-mm2-full/drivers/media/video/msp3400.h.old 2006-03-03 17:40:22.000000000 +0100
+++ linux-2.6.16-rc5-mm2-full/drivers/media/video/msp3400.h 2006-03-03 17:40:41.000000000 +0100
@@ -104,7 +104,6 @@
/* msp3400-kthreads.c */
const char *msp_standard_std_name(int std);
-void msp_set_source(struct i2c_client *client, u16 src);
void msp_set_audmode(struct i2c_client *client);
void msp_detect_stereo(struct i2c_client *client);
int msp3400c_thread(void *data);
--- linux-2.6.16-rc5-mm2-full/drivers/media/video/msp3400-kthreads.c.old 2006-03-03 17:39:29.000000000 +0100
+++ linux-2.6.16-rc5-mm2-full/drivers/media/video/msp3400-kthreads.c 2006-03-03 17:40:10.000000000 +0100
@@ -154,7 +154,7 @@
return "unknown";
}
-void msp_set_source(struct i2c_client *client, u16 src)
+static void msp_set_source(struct i2c_client *client, u16 src)
{
struct msp_state *state = i2c_get_clientdata(client);
@@ -217,7 +217,7 @@
/* Set audio mode. Note that the pre-'G' models do not support BTSC+SAP,
nor do they support stereo BTSC. */
-void msp3400c_set_audmode(struct i2c_client *client)
+static void msp3400c_set_audmode(struct i2c_client *client)
{
static char *strmode[] = { "mono", "stereo", "lang2", "lang1" };
struct msp_state *state = i2c_get_clientdata(client);
@@ -944,7 +944,7 @@
status, is_stereo, is_bilingual, state->rxsubchans);
}
-void msp34xxg_set_audmode(struct i2c_client *client)
+static void msp34xxg_set_audmode(struct i2c_client *client)
{
struct msp_state *state = i2c_get_clientdata(client);
int source;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-03-08 18:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-03-08 9:08 [RFC: -mm patch] drivers/media/video/msp3400-kthreads.c: make 3 functions static Adrian Bunk
2006-03-08 18:46 ` Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2006-03-03 12:56 2.6.16-rc5-mm2 Andrew Morton
2006-03-04 12:14 ` [RFC: -mm patch] drivers/media/video/msp3400-kthreads.c: make 3 functions static Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).