* [PATCH] fs/compat.c: fix 'if (a |= b )' typo
@ 2006-05-11 19:37 Alexey Dobriyan
2006-05-11 20:33 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2006-05-11 19:37 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Mentioned by Mark Armbrust somewhere on Usenet.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
--- a/fs/compat.c
+++ b/fs/compat.c
@@ -1913,7 +1913,7 @@ asmlinkage long compat_sys_ppoll(struct
}
if (sigmask) {
- if (sigsetsize |= sizeof(compat_sigset_t))
+ if (sigsetsize != sizeof(compat_sigset_t))
return -EINVAL;
if (copy_from_user(&ss32, sigmask, sizeof(ss32)))
return -EFAULT;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/compat.c: fix 'if (a |= b )' typo
2006-05-11 19:37 [PATCH] fs/compat.c: fix 'if (a |= b )' typo Alexey Dobriyan
@ 2006-05-11 20:33 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2006-05-11 20:33 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-kernel, David Woodhouse, Ulrich Drepper
Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> Mentioned by Mark Armbrust somewhere on Usenet.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> --- a/fs/compat.c
> +++ b/fs/compat.c
> @@ -1913,7 +1913,7 @@ asmlinkage long compat_sys_ppoll(struct
> }
>
> if (sigmask) {
> - if (sigsetsize |= sizeof(compat_sigset_t))
> + if (sigsetsize != sizeof(compat_sigset_t))
> return -EINVAL;
> if (copy_from_user(&ss32, sigmask, sizeof(ss32)))
> return -EFAULT;
Oh wow. I can only assume that this code leg hasn't been exercised at all.
(I'm a bit surprised that the compiler doesn't warn and demand another set
of parentheses, actually. I guess they decided not to do that for some
reason).
I'll tag this for a 2.6.16 backport, but I'm worried that what we have here
is a pretty significant codepath which just hasn't been executed.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-05-11 20:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-05-11 19:37 [PATCH] fs/compat.c: fix 'if (a |= b )' typo Alexey Dobriyan
2006-05-11 20:33 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).