[PATCH] scx200_acb: fix section mismatch warning

[PATCH] scx200_acb: fix section mismatch warning

[Randy.Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

Fix section mismatch warning reported by İsmail Dönmez:
WARNING: drivers/i2c/busses/scx200_acb.o - Section mismatch: reference
to .init.text: from .text after 'scx200_add_cs553x' (at offset 0x528)

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 drivers/i2c/busses/scx200_acb.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

--- linux-2617-rc5.orig/drivers/i2c/busses/scx200_acb.c
+++ linux-2617-rc5/drivers/i2c/busses/scx200_acb.c
@@ -491,7 +491,7 @@ static struct pci_device_id divil_pci[] 
 
 #define MSR_LBAR_SMB		0x5140000B
 
-static int scx200_add_cs553x(void)
+static __init int scx200_add_cs553x(void)
 {
 	u32	low, hi;
 	u32	smb_base;


---

Re: [PATCH] scx200_acb: fix section mismatch warning

[İsmail Dönmez]

Randy.Dunlap wrote On 25-05-2006 20:01:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Fix section mismatch warning reported by İsmail Dönmez:
> WARNING: drivers/i2c/busses/scx200_acb.o - Section mismatch: reference
> to .init.text: from .text after 'scx200_add_cs553x' (at offset 0x528)
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
>  drivers/i2c/busses/scx200_acb.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2617-rc5.orig/drivers/i2c/busses/scx200_acb.c
> +++ linux-2617-rc5/drivers/i2c/busses/scx200_acb.c
> @@ -491,7 +491,7 @@ static struct pci_device_id divil_pci[] 
>  
>  #define MSR_LBAR_SMB		0x5140000B
>  
> -static int scx200_add_cs553x(void)
> +static __init int scx200_add_cs553x(void)
>  {
>  	u32	low, hi;
>  	u32	smb_base;
> 
> 
> ---

Ack, this fixes the warning for me.

Regards,
ismail

Re: [PATCH] scx200_acb: fix section mismatch warning

[Jean Delvare]

Hi Randy, all,

> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Fix section mismatch warning reported by İsmail Dönmez:
> WARNING: drivers/i2c/busses/scx200_acb.o - Section mismatch: reference
> to .init.text: from .text after 'scx200_add_cs553x' (at offset 0x528)
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
>  drivers/i2c/busses/scx200_acb.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2617-rc5.orig/drivers/i2c/busses/scx200_acb.c
> +++ linux-2617-rc5/drivers/i2c/busses/scx200_acb.c
> @@ -491,7 +491,7 @@ static struct pci_device_id divil_pci[] 
>  
>  #define MSR_LBAR_SMB		0x5140000B
>  
> -static int scx200_add_cs553x(void)
> +static __init int scx200_add_cs553x(void)
>  {
>  	u32	low, hi;
>  	u32	smb_base;
> 

Correct, I sent exactly the same patch to the the lm-sensors list and
Greg KH yesterday:
http://lists.lm-sensors.org/pipermail/lm-sensors/2006-May/016213.html

So this one is
Signed-off-by: Jean Delvare <khali@linux-fr.org>

Note that the section mismatch is harmless here (we have a non-__init
function sandwiched between two __init functions) but nevertheless this
kind of warning is never welcome in a final kernel release so let's get
the fix merged now.

Andrew, can you please push this to Linus?

Thanks,
-- 
Jean Delvare

Re: [PATCH] scx200_acb: fix section mismatch warning

[Andrew Morton]

Jean Delvare <khali@linux-fr.org> wrote:
>
> > -static int scx200_add_cs553x(void)
>  > +static __init int scx200_add_cs553x(void)
>  >  {
>  >  	u32	low, hi;
>  >  	u32	smb_base;
>  > 
> 
>  Correct, I sent exactly the same patch to the the lm-sensors list and
>  Greg KH yesterday:
>  http://lists.lm-sensors.org/pipermail/lm-sensors/2006-May/016213.html
> 
>  So this one is
>  Signed-off-by: Jean Delvare <khali@linux-fr.org>
> 
>  Note that the section mismatch is harmless here (we have a non-__init
>  function sandwiched between two __init functions) but nevertheless this
>  kind of warning is never welcome in a final kernel release so let's get
>  the fix merged now.
> 
>  Andrew, can you please push this to Linus?

yup, I'll send that later on today.  My current 2.6.17 queue is:

s390-fix-typo-in-stop_hz_timer.patch
add-cmspar-to-termbitsh-for-powerpc-and-alpha.patch
x86-wire-up-vmsplice-syscall.patch
ads7846-conversion-accuracy.patch
affs-possible-null-pointer-dereference-in-affs_rename.patch
powermac-force-only-suspend-to-disk-to-be-valid.patch
s3c24xx-fix-spi-driver-with-config_pm.patch
scx200_acb-fix-section-mismatch-warning.patch

Re: [PATCH] scx200_acb: fix section mismatch warning

[İsmail Dönmez]

Andrew Morton wrote On 25-05-2006 21:06:
> Jean Delvare <khali@linux-fr.org> wrote:
>>> -static int scx200_add_cs553x(void)
>>  > +static __init int scx200_add_cs553x(void)
>>  >  {
>>  >  	u32	low, hi;
>>  >  	u32	smb_base;
>>  > 
>>
>>  Correct, I sent exactly the same patch to the the lm-sensors list and
>>  Greg KH yesterday:
>>  http://lists.lm-sensors.org/pipermail/lm-sensors/2006-May/016213.html
>>
>>  So this one is
>>  Signed-off-by: Jean Delvare <khali@linux-fr.org>
>>
>>  Note that the section mismatch is harmless here (we have a non-__init
>>  function sandwiched between two __init functions) but nevertheless this
>>  kind of warning is never welcome in a final kernel release so let's get
>>  the fix merged now.
>>
>>  Andrew, can you please push this to Linus?
> 
> yup, I'll send that later on today.  My current 2.6.17 queue is:
> 
> s390-fix-typo-in-stop_hz_timer.patch
> add-cmspar-to-termbitsh-for-powerpc-and-alpha.patch
> x86-wire-up-vmsplice-syscall.patch
> ads7846-conversion-accuracy.patch
> affs-possible-null-pointer-dereference-in-affs_rename.patch
> powermac-force-only-suspend-to-disk-to-be-valid.patch
> s3c24xx-fix-spi-driver-with-config_pm.patch
> scx200_acb-fix-section-mismatch-warning.patch

Is there a chance of queing Randy's other mismatch fixes? It would be
nice to eliminate them for the final release.

Regards,
ismail

Re: [PATCH] scx200_acb: fix section mismatch warning

[Randy.Dunlap]

On Thu, 25 May 2006 21:10:28 +0300 İsmail Dönmez wrote:

> Andrew Morton wrote On 25-05-2006 21:06:
> > Jean Delvare <khali@linux-fr.org> wrote:
> >>> -static int scx200_add_cs553x(void)
> >>  > +static __init int scx200_add_cs553x(void)
> >>  >  {
> >>  >  	u32	low, hi;
> >>  >  	u32	smb_base;
> >>  > 
> >>
> >>  Correct, I sent exactly the same patch to the the lm-sensors list and
> >>  Greg KH yesterday:
> >>  http://lists.lm-sensors.org/pipermail/lm-sensors/2006-May/016213.html
> >>
> >>  So this one is
> >>  Signed-off-by: Jean Delvare <khali@linux-fr.org>
> >>
> >>  Note that the section mismatch is harmless here (we have a non-__init
> >>  function sandwiched between two __init functions) but nevertheless this
> >>  kind of warning is never welcome in a final kernel release so let's get
> >>  the fix merged now.
> >>
> >>  Andrew, can you please push this to Linus?
> > 
> > yup, I'll send that later on today.  My current 2.6.17 queue is:
> > 
> > s390-fix-typo-in-stop_hz_timer.patch
> > add-cmspar-to-termbitsh-for-powerpc-and-alpha.patch
> > x86-wire-up-vmsplice-syscall.patch
> > ads7846-conversion-accuracy.patch
> > affs-possible-null-pointer-dereference-in-affs_rename.patch
> > powermac-force-only-suspend-to-disk-to-be-valid.patch
> > s3c24xx-fix-spi-driver-with-config_pm.patch
> > scx200_acb-fix-section-mismatch-warning.patch
> 
> Is there a chance of queing Randy's other mismatch fixes? It would be
> nice to eliminate them for the final release.

Well this one got quick review/feedback/ack by maintainer.
The others need something like that too....

---
~Randy

Re: [PATCH] scx200_acb: fix section mismatch warning

[Andrew Morton]

__smail Dönmez <ismail@pardus.org.tr> wrote:
>
> Andrew Morton wrote On 25-05-2006 21:06:
> > Jean Delvare <khali@linux-fr.org> wrote:
> >>> -static int scx200_add_cs553x(void)
> >>  > +static __init int scx200_add_cs553x(void)
> >>  >  {
> >>  >  	u32	low, hi;
> >>  >  	u32	smb_base;
> >>  > 
> >>
> >>  Correct, I sent exactly the same patch to the the lm-sensors list and
> >>  Greg KH yesterday:
> >>  http://lists.lm-sensors.org/pipermail/lm-sensors/2006-May/016213.html
> >>
> >>  So this one is
> >>  Signed-off-by: Jean Delvare <khali@linux-fr.org>
> >>
> >>  Note that the section mismatch is harmless here (we have a non-__init
> >>  function sandwiched between two __init functions) but nevertheless this
> >>  kind of warning is never welcome in a final kernel release so let's get
> >>  the fix merged now.
> >>
> >>  Andrew, can you please push this to Linus?
> > 
> > yup, I'll send that later on today.  My current 2.6.17 queue is:
> > 
> > s390-fix-typo-in-stop_hz_timer.patch
> > add-cmspar-to-termbitsh-for-powerpc-and-alpha.patch
> > x86-wire-up-vmsplice-syscall.patch
> > ads7846-conversion-accuracy.patch
> > affs-possible-null-pointer-dereference-in-affs_rename.patch
> > powermac-force-only-suspend-to-disk-to-be-valid.patch
> > s3c24xx-fix-spi-driver-with-config_pm.patch
> > scx200_acb-fix-section-mismatch-warning.patch
> 
> Is there a chance of queing Randy's other mismatch fixes? It would be
> nice to eliminate them for the final release.
> 

spose so.  At least, the ones which fix bugs.