* [PATCH 9/10] dm: fix block device initialisation
@ 2006-05-25 19:19 Alasdair G Kergon
0 siblings, 0 replies; only message in thread
From: Alasdair G Kergon @ 2006-05-25 19:19 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
From: Jeff Mahoney <jeffm@suse.com>
In alloc_dev(), we register the device with the block layer and then
continue to initialize the device. But register_disk() makes
the device available to be opened before we have completed
initialising it.
This patch moves the final bits of the initialization above the disk
registration.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-Off-By: Alasdair G Kergon <agk@redhat.com>
Index: linux-2.6.17-rc4/drivers/md/dm.c
===================================================================
--- linux-2.6.17-rc4.orig/drivers/md/dm.c 2006-05-23 19:37:14.000000000 +0100
+++ linux-2.6.17-rc4/drivers/md/dm.c 2006-05-23 19:38:01.000000000 +0100
@@ -891,6 +891,10 @@ static struct mapped_device *alloc_dev(u
if (!md->disk)
goto bad4;
+ atomic_set(&md->pending, 0);
+ init_waitqueue_head(&md->wait);
+ init_waitqueue_head(&md->eventq);
+
md->disk->major = _major;
md->disk->first_minor = minor;
md->disk->fops = &dm_blk_dops;
@@ -900,10 +904,6 @@ static struct mapped_device *alloc_dev(u
add_disk(md->disk);
format_dev_t(md->name, MKDEV(_major, minor));
- atomic_set(&md->pending, 0);
- init_waitqueue_head(&md->wait);
- init_waitqueue_head(&md->eventq);
-
/* Populate the mapping, nobody knows we exist yet */
spin_lock(&_minor_lock);
old_md = idr_replace(&_minor_idr, md, minor);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-05-25 19:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-05-25 19:19 [PATCH 9/10] dm: fix block device initialisation Alasdair G Kergon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).