* Re: + netlink-remove-dead-code.patch added to -mm tree
[not found] <200606212033.k5LKXw9B003804@shell0.pdx.osdl.net>
@ 2006-06-21 20:53 ` David Miller
2006-06-21 21:09 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2006-06-21 20:53 UTC (permalink / raw)
To: linux-kernel, akpm; +Cc: mm-commits
From: akpm@osdl.org
Date: Wed, 21 Jun 2006 13:33:58 -0700
> diff -puN net/netlink/af_netlink.c~netlink-remove-dead-code net/netlink/af_netlink.c
> --- a/net/netlink/af_netlink.c~netlink-remove-dead-code
> +++ a/net/netlink/af_netlink.c
> @@ -1380,9 +1380,6 @@ static int netlink_dump(struct sock *sk)
>
> netlink_destroy_callback(cb);
> return 0;
> -
> -nlmsg_failure:
> - return -ENOBUFS;
> }
>
> int netlink_dump_start(struct sock *ssk, struct sk_buff *skb,
Andrew, please type make before you commit things like this
to your tree. This breaks the build.
These code labels are referenced internally by the netlink packet
message macros, in this case the reference comes from
NLMSG_NEW_ANSWER().
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: + netlink-remove-dead-code.patch added to -mm tree
2006-06-21 20:53 ` + netlink-remove-dead-code.patch added to -mm tree David Miller
@ 2006-06-21 21:09 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2006-06-21 21:09 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel
On Wed, 21 Jun 2006 13:53:39 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: akpm@osdl.org
> Date: Wed, 21 Jun 2006 13:33:58 -0700
>
> > diff -puN net/netlink/af_netlink.c~netlink-remove-dead-code net/netlink/af_netlink.c
> > --- a/net/netlink/af_netlink.c~netlink-remove-dead-code
> > +++ a/net/netlink/af_netlink.c
> > @@ -1380,9 +1380,6 @@ static int netlink_dump(struct sock *sk)
> >
> > netlink_destroy_callback(cb);
> > return 0;
> > -
> > -nlmsg_failure:
> > - return -ENOBUFS;
> > }
> >
> > int netlink_dump_start(struct sock *ssk, struct sk_buff *skb,
>
> Andrew, please type make before you commit things like this
> to your tree.
Nope. I build-test in batches, not after every patch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-21 21:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200606212033.k5LKXw9B003804@shell0.pdx.osdl.net>
2006-06-21 20:53 ` + netlink-remove-dead-code.patch added to -mm tree David Miller
2006-06-21 21:09 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).