* [PATCH 03/15] dm mpath: support ioctls
@ 2006-06-21 19:33 Alasdair G Kergon
2006-06-22 3:56 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Alasdair G Kergon @ 2006-06-21 19:33 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Milan Broz
From: Milan Broz <mbroz@redhat.com>
When an ioctl is performed on a multipath device
simply pass it on to the underlying block device
through current_path. If current path is not yet selected,
select it.
Signed-off-by: Milan Broz <mbroz@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Index: linux-2.6.17/drivers/md/dm-mpath.c
===================================================================
--- linux-2.6.17.orig/drivers/md/dm-mpath.c 2006-06-21 17:45:15.000000000 +0100
+++ linux-2.6.17/drivers/md/dm-mpath.c 2006-06-21 18:32:08.000000000 +0100
@@ -1266,12 +1266,39 @@ error:
return -EINVAL;
}
+static int multipath_ioctl(struct dm_target *ti, struct inode *inode,
+ struct file *filp, unsigned int cmd,
+ unsigned long arg)
+{
+ struct multipath *m = (struct multipath *) ti->private;
+ struct block_device *bdev = NULL;
+ unsigned long flags;
+ int r = 0;
+
+ spin_lock_irqsave(&m->lock, flags);
+
+ if (!m->current_pgpath)
+ __choose_pgpath(m);
+
+ if (m->current_pgpath)
+ bdev = m->current_pgpath->path.dev->bdev;
+
+ if (m->queue_io)
+ r = -EAGAIN;
+ else if (!bdev)
+ r = -EIO;
+
+ spin_unlock_irqrestore(&m->lock, flags);
+
+ return r ? : blkdev_ioctl(bdev->bd_inode, filp, cmd, arg);
+}
+
/*-----------------------------------------------------------------
* Module setup
*---------------------------------------------------------------*/
static struct target_type multipath_target = {
.name = "multipath",
- .version = {1, 0, 4},
+ .version = {1, 0, 5},
.module = THIS_MODULE,
.ctr = multipath_ctr,
.dtr = multipath_dtr,
@@ -1281,6 +1308,7 @@ static struct target_type multipath_targ
.resume = multipath_resume,
.status = multipath_status,
.message = multipath_message,
+ .ioctl = multipath_ioctl,
};
static int __init dm_multipath_init(void)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 03/15] dm mpath: support ioctls
2006-06-21 19:33 [PATCH 03/15] dm mpath: support ioctls Alasdair G Kergon
@ 2006-06-22 3:56 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2006-06-22 3:56 UTC (permalink / raw)
To: Alasdair G Kergon; +Cc: linux-kernel, mbroz
On Wed, 21 Jun 2006 20:33:33 +0100
Alasdair G Kergon <agk@redhat.com> wrote:
> + return r ? : blkdev_ioctl(bdev->bd_inode, filp, cmd, arg);
Ditto.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-22 3:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-21 19:33 [PATCH 03/15] dm mpath: support ioctls Alasdair G Kergon
2006-06-22 3:56 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).