Re: fs/binfmt_aout.o, Error: suffix or operands invalid for `cmp' [was Re: 2.6.17-mm1]

[Mattia Dongili <malattia@linux.it>]

On Wed, Jun 21, 2006 at 02:34:50PM -0700, Andrew Morton wrote:
> On Wed, 21 Jun 2006 23:16:17 +0200
> Mattia Dongili <malattia@linux.it> wrote:
> 
> > On Wed, Jun 21, 2006 at 01:42:15PM -0700, Andrew Morton wrote:
> > > On Wed, 21 Jun 2006 21:39:32 +0200
> > > Mattia Dongili <malattia@linux.it> wrote:
> > > 
> > > > Thanks, this is fixed, but I have a new failure:
> > > >   CC [M]  fs/xfs/support/move.o
> > > >   CC [M]  fs/xfs/support/uuid.o
> > > >   LD [M]  fs/xfs/xfs.o
> > > >   CC      fs/dnotify.o
> > > >   CC      fs/dcookies.o
> > > >   LD      fs/built-in.o
> > > >   CC [M]  fs/binfmt_aout.o
> > > > {standard input}: Assembler messages:
> > > > {standard input}:160: Error: suffix or operands invalid for `cmp'
> > > > make[1]: *** [fs/binfmt_aout.o] Error 1
> > > > make: *** [fs] Error 2
> > > 
> > > what the heck?  Can you do `make fs/binfmt_aout.s' then send the relevant
> > > parts of that file?
> > 
> > I can't really tell which is the relevant part other than line 160 :)
> > Full file available here:
> > http://oioio.altervista.org/linux/binfmt_aout.s
> > 
> 
> It's complaining about this:
> 
> #APP
>         addl %ecx,%eax ; sbbl %edx,%edx; cmpl %eax,$-1073741824; sbbl $0,%edx   # dump.u_dsize, sum, flag,
> #NO_APP
> 
> from fs/binfmt_aout.c:154:
> 
>         if (!access_ok(VERIFY_READ, (void __user *)START_DATA(dump), dump.u_dsize << PAGE_SHIFT))
>                 dump.u_dsize = 0;
>         if (!access_ok(VERIFY_READ, (void __user *)START_STACK(dump), dump.u_ssize << PAGE_SHIFT))
>                 dump.u_ssize = 0;
> 
> the offending code comes from __range_ok()

thanks for the explanation!

> Mad guess: does reverting
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm1/broken-out/i386-use-c-code-for-current_thread_info.patch
> help?

yes, I didn't build the full kernel but a simple

make fs/binfmt_aout.o

is finally successful.
-- 
mattia
:wq!