Re: fs/binfmt_aout.o, Error: suffix or operands invalid for `cmp' [was Re: 2.6.17-mm1]

["H. Peter Anvin" <hpa@zytor.com>]

Andrew Morton wrote:
> On Wed, 21 Jun 2006 23:16:17 +0200
> Mattia Dongili <malattia@linux.it> wrote:
> 
>> On Wed, Jun 21, 2006 at 01:42:15PM -0700, Andrew Morton wrote:
>>> On Wed, 21 Jun 2006 21:39:32 +0200
>>> Mattia Dongili <malattia@linux.it> wrote:
>>>
>>>> Thanks, this is fixed, but I have a new failure:
>>>>   CC [M]  fs/xfs/support/move.o
>>>>   CC [M]  fs/xfs/support/uuid.o
>>>>   LD [M]  fs/xfs/xfs.o
>>>>   CC      fs/dnotify.o
>>>>   CC      fs/dcookies.o
>>>>   LD      fs/built-in.o
>>>>   CC [M]  fs/binfmt_aout.o
>>>> {standard input}: Assembler messages:
>>>> {standard input}:160: Error: suffix or operands invalid for `cmp'
>>>> make[1]: *** [fs/binfmt_aout.o] Error 1
>>>> make: *** [fs] Error 2
>>> what the heck?  Can you do `make fs/binfmt_aout.s' then send the relevant
>>> parts of that file?
>> I can't really tell which is the relevant part other than line 160 :)
>> Full file available here:
>> http://oioio.altervista.org/linux/binfmt_aout.s
>>
> 
> It's complaining about this:
> 
> #APP
>         addl %ecx,%eax ; sbbl %edx,%edx; cmpl %eax,$-1073741824; sbbl $0,%edx   # dump.u_dsize, sum, flag,
> #NO_APP

The cmpl should have its arguments reversed.  It's quite possible some versions of the 
assembler accepts the form given, but they're wrong (and doubly confusing when used as 
input to sbb.)

	-hpa