* [2.6 patch] fs/jffs2/: make 2 functions static
@ 2006-06-22 10:03 Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2006-06-22 10:03 UTC (permalink / raw)
To: dwmw2; +Cc: jffs-dev, linux-kernel
This patch makes two needlessly global functions static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/jffs2/malloc.c | 2 +-
fs/jffs2/nodelist.h | 2 --
fs/jffs2/scan.c | 4 ++--
3 files changed, 3 insertions(+), 5 deletions(-)
--- linux-2.6.17-mm1-full/fs/jffs2/malloc.c.old 2006-06-22 11:31:15.000000000 +0200
+++ linux-2.6.17-mm1-full/fs/jffs2/malloc.c 2006-06-22 11:31:23.000000000 +0200
@@ -190,7 +190,7 @@
kmem_cache_free(tmp_dnode_info_slab, x);
}
-struct jffs2_raw_node_ref *jffs2_alloc_refblock(void)
+static struct jffs2_raw_node_ref *jffs2_alloc_refblock(void)
{
struct jffs2_raw_node_ref *ret;
--- linux-2.6.17-mm1-full/fs/jffs2/nodelist.h.old 2006-06-22 11:31:31.000000000 +0200
+++ linux-2.6.17-mm1-full/fs/jffs2/nodelist.h 2006-06-22 11:31:38.000000000 +0200
@@ -427,8 +427,6 @@
/* scan.c */
int jffs2_scan_medium(struct jffs2_sb_info *c);
void jffs2_rotate_lists(struct jffs2_sb_info *c);
-int jffs2_fill_scan_buf(struct jffs2_sb_info *c, void *buf,
- uint32_t ofs, uint32_t len);
struct jffs2_inode_cache *jffs2_scan_make_ino_cache(struct jffs2_sb_info *c, uint32_t ino);
int jffs2_scan_classify_jeb(struct jffs2_sb_info *c, struct jffs2_eraseblock *jeb);
int jffs2_scan_dirty_space(struct jffs2_sb_info *c, struct jffs2_eraseblock *jeb, uint32_t size);
--- linux-2.6.17-mm1-full/fs/jffs2/scan.c.old 2006-06-22 11:31:47.000000000 +0200
+++ linux-2.6.17-mm1-full/fs/jffs2/scan.c 2006-06-22 11:32:11.000000000 +0200
@@ -274,8 +274,8 @@
return ret;
}
-int jffs2_fill_scan_buf (struct jffs2_sb_info *c, void *buf,
- uint32_t ofs, uint32_t len)
+static int jffs2_fill_scan_buf(struct jffs2_sb_info *c, void *buf,
+ uint32_t ofs, uint32_t len)
{
int ret;
size_t retlen;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] fs/jffs2/: make 2 functions static
2006-06-28 16:54 Adrian Bunk
@ 2006-06-29 22:14 ` David Woodhouse
0 siblings, 0 replies; 3+ messages in thread
From: David Woodhouse @ 2006-06-29 22:14 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, jffs-dev, linux-kernel
On Wed, 2006-06-28 at 18:54 +0200, Adrian Bunk wrote:
> This patch makes two needlessly global functions static.
Applied; thanks.
To be honest though, I'd _much_ rather get GCC bugs 27898 and 27899
fixed and start building stuff like file systems with -fwhole-program
--combine. It gives about a 4% reduction in code size.
--
dwmw2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] fs/jffs2/: make 2 functions static
@ 2006-06-28 16:54 Adrian Bunk
2006-06-29 22:14 ` David Woodhouse
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2006-06-28 16:54 UTC (permalink / raw)
To: Andrew Morton; +Cc: dwmw2, jffs-dev, linux-kernel
This patch makes two needlessly global functions static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 22 Jun 2006
fs/jffs2/malloc.c | 2 +-
fs/jffs2/nodelist.h | 2 --
fs/jffs2/scan.c | 4 ++--
3 files changed, 3 insertions(+), 5 deletions(-)
--- linux-2.6.17-mm1-full/fs/jffs2/malloc.c.old 2006-06-22 11:31:15.000000000 +0200
+++ linux-2.6.17-mm1-full/fs/jffs2/malloc.c 2006-06-22 11:31:23.000000000 +0200
@@ -190,7 +190,7 @@
kmem_cache_free(tmp_dnode_info_slab, x);
}
-struct jffs2_raw_node_ref *jffs2_alloc_refblock(void)
+static struct jffs2_raw_node_ref *jffs2_alloc_refblock(void)
{
struct jffs2_raw_node_ref *ret;
--- linux-2.6.17-mm1-full/fs/jffs2/nodelist.h.old 2006-06-22 11:31:31.000000000 +0200
+++ linux-2.6.17-mm1-full/fs/jffs2/nodelist.h 2006-06-22 11:31:38.000000000 +0200
@@ -427,8 +427,6 @@
/* scan.c */
int jffs2_scan_medium(struct jffs2_sb_info *c);
void jffs2_rotate_lists(struct jffs2_sb_info *c);
-int jffs2_fill_scan_buf(struct jffs2_sb_info *c, void *buf,
- uint32_t ofs, uint32_t len);
struct jffs2_inode_cache *jffs2_scan_make_ino_cache(struct jffs2_sb_info *c, uint32_t ino);
int jffs2_scan_classify_jeb(struct jffs2_sb_info *c, struct jffs2_eraseblock *jeb);
int jffs2_scan_dirty_space(struct jffs2_sb_info *c, struct jffs2_eraseblock *jeb, uint32_t size);
--- linux-2.6.17-mm1-full/fs/jffs2/scan.c.old 2006-06-22 11:31:47.000000000 +0200
+++ linux-2.6.17-mm1-full/fs/jffs2/scan.c 2006-06-22 11:32:11.000000000 +0200
@@ -274,8 +274,8 @@
return ret;
}
-int jffs2_fill_scan_buf (struct jffs2_sb_info *c, void *buf,
- uint32_t ofs, uint32_t len)
+static int jffs2_fill_scan_buf(struct jffs2_sb_info *c, void *buf,
+ uint32_t ofs, uint32_t len)
{
int ret;
size_t retlen;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-06-29 22:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-22 10:03 [2.6 patch] fs/jffs2/: make 2 functions static Adrian Bunk
2006-06-28 16:54 Adrian Bunk
2006-06-29 22:14 ` David Woodhouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).