From: Andrew Morton <akpm@osdl.org>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [Patch] [mm] More driver core fixes for -mm
Date: Tue, 25 Jul 2006 01:08:52 -0700 [thread overview]
Message-ID: <20060725010852.75afe430.akpm@osdl.org> (raw)
In-Reply-To: <20060721152000.5a59813a@gondolin.boeblingen.de.ibm.com>
On Fri, 21 Jul 2006 15:20:00 +0200
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
>
> I've looked some more into the __must_check stuff in the driver core,
> and tried to fix some functions (especially device_add() is a bit of a
> beast; I split off helper functions).
OK.
> Question: What is considered "good style" concerning symlinks? I would
> think I should remove symlinks I created, but most places don't seem to
> do this...
Removing symlinks seems like a good idea. Leaving them around might cause
a subsequent driver load to fail due to EEXIST (assuming that the caller
checks error codes, as if).
I assume you're referring to error paths here?
> --
> Cornelia Huck
> Linux for zSeries Developer
> Tel.: +49-7031-16-4837, Mail: cornelia.huck@de.ibm.com
>
> From: Cornelia Huck <cornelia.huck@de.ibm.com>
>
> Fix missing checks of return codes for driver model functions called in
> the driver core.
>
> Also fix bus_attach_device(), which didn't take into account that
> device_attach() may return 0 or 1 on success.
>
Yes, this was nasty (oopses).
> @@ -401,13 +401,33 @@ int bus_attach_device(struct device * de
>
> if (bus) {
> ret = device_attach(dev);
> - if (ret == 0)
> + if (ret >= 0)
> klist_add_tail(&dev->knode_bus, &bus->klist_devices);
> }
But I made bus_attach_device() convert the positive return value to zero.
See
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc1/2.6.18-rc1-mm2/hot-fixes/drivers-base-check-errors-fix.patch.
Is there a reason to propagate this irritating "1" back out of
bus_attach_device() as well?
next prev parent reply other threads:[~2006-07-25 8:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-20 14:59 [Patch] [mm] Fix bus_rescan_devices() in -mm Cornelia Huck
2006-07-21 13:20 ` [Patch] [mm] More driver core fixes for -mm Cornelia Huck
2006-07-24 17:00 ` [Patch] [mm] Yet further " Cornelia Huck
2006-07-25 8:08 ` Andrew Morton [this message]
2006-07-25 8:46 ` [Patch] [mm] More " Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060725010852.75afe430.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=cornelia.huck@de.ibm.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).