From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [Patch] [mm] More driver core fixes for -mm
Date: Tue, 25 Jul 2006 10:46:21 +0200 [thread overview]
Message-ID: <20060725104621.4bd0aa1a@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20060725010852.75afe430.akpm@osdl.org>
On Tue, 25 Jul 2006 01:08:52 -0700,
Andrew Morton <akpm@osdl.org> wrote:
> Removing symlinks seems like a good idea. Leaving them around might cause
> a subsequent driver load to fail due to EEXIST (assuming that the caller
> checks error codes, as if).
>
> I assume you're referring to error paths here?
Yes, that was my reasoning.
> But I made bus_attach_device() convert the positive return value to zero.
> See
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc1/2.6.18-rc1-mm2/hot-fixes/drivers-base-check-errors-fix.patch.
Missed that, sorry.
>
> Is there a reason to propagate this irritating "1" back out of
> bus_attach_device() as well?
Probably not. Nobody cares whether the device was bound to a driver or
not.
--
Cornelia Huck
Linux for zSeries Developer
Tel.: +49-7031-16-4837, Mail: cornelia.huck@de.ibm.com
prev parent reply other threads:[~2006-07-25 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-20 14:59 [Patch] [mm] Fix bus_rescan_devices() in -mm Cornelia Huck
2006-07-21 13:20 ` [Patch] [mm] More driver core fixes for -mm Cornelia Huck
2006-07-24 17:00 ` [Patch] [mm] Yet further " Cornelia Huck
2006-07-25 8:08 ` [Patch] [mm] More " Andrew Morton
2006-07-25 8:46 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060725104621.4bd0aa1a@gondolin.boeblingen.de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).