* [PATCH] 2.6.18-rc2-mm1: unresolved symbol brnf_deferred_hooks in xt_physdev module
@ 2006-07-28 11:38 Bernhard Rosenkraenzer
2006-07-29 5:00 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Bernhard Rosenkraenzer @ 2006-07-28 11:38 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
The (trivial) patch below fixes the unresolved symbol brnf_deferred_hooks in
the xt_physdev module in 2.6.18-rc2-mm1.
Signed-off-by: Bernhard Rosenkraenzer <bero@arklinux.org>
---
--- linux-2.6.17/net/netfilter/xt_physdev.c.ark 2006-07-28 13:34:31.000000000
+0200
+++ linux-2.6.17/net/netfilter/xt_physdev.c 2006-07-28 13:34:48.000000000
+0200
@@ -16,6 +16,8 @@
#define MATCH 1
#define NOMATCH 0
+extern int brnf_deferred_hooks;
+
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Bart De Schuymer <bdschuym@pandora.be>");
MODULE_DESCRIPTION("iptables bridge physical device match module");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] 2.6.18-rc2-mm1: unresolved symbol brnf_deferred_hooks in xt_physdev module
2006-07-28 11:38 [PATCH] 2.6.18-rc2-mm1: unresolved symbol brnf_deferred_hooks in xt_physdev module Bernhard Rosenkraenzer
@ 2006-07-29 5:00 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2006-07-29 5:00 UTC (permalink / raw)
To: Bernhard Rosenkraenzer; +Cc: linux-kernel, Bart De Schuymer
On Fri, 28 Jul 2006 13:38:21 +0200
Bernhard Rosenkraenzer <bero@arklinux.org> wrote:
> The (trivial) patch below fixes the unresolved symbol brnf_deferred_hooks in
> the xt_physdev module in 2.6.18-rc2-mm1.
>
> Signed-off-by: Bernhard Rosenkraenzer <bero@arklinux.org>
>
> ---
> --- linux-2.6.17/net/netfilter/xt_physdev.c.ark 2006-07-28 13:34:31.000000000
> +0200
> +++ linux-2.6.17/net/netfilter/xt_physdev.c 2006-07-28 13:34:48.000000000
> +0200
> @@ -16,6 +16,8 @@
> #define MATCH 1
> #define NOMATCH 0
>
> +extern int brnf_deferred_hooks;
> +
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Bart De Schuymer <bdschuym@pandora.be>");
> MODULE_DESCRIPTION("iptables bridge physical device match module");
OK, but please never put extern declarations in .c files. They need to go
in a header where the compiler can check that the variable's type is
consistent at all usage sites.
We already have such a declaration, so I guess this is the fix:
--- a/net/netfilter/xt_physdev.c~xt_physdev-build-fix
+++ a/net/netfilter/xt_physdev.c
@@ -10,6 +10,7 @@
#include <linux/module.h>
#include <linux/skbuff.h>
+#include <linux/netfilter/netfilter_bridge.h>
#include <linux/netfilter/xt_physdev.h>
#include <linux/netfilter/x_tables.h>
#include <linux/netfilter_bridge.h>
_
Your email client is wordwrapping patches, btw. There's a lot of it going
round at present.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-07-29 5:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-07-28 11:38 [PATCH] 2.6.18-rc2-mm1: unresolved symbol brnf_deferred_hooks in xt_physdev module Bernhard Rosenkraenzer
2006-07-29 5:00 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).